From: Dave Abrahams <dave@boostpro.com>
To: Michael Kifer <michael.kifer@stonybrook.edu>
Cc: 11319-done@debbugs.gnu.org
Subject: bug#11319: [PATCH 1/2] BUGFIX: select current-diff-comparison regions for ediff-inferior-compare-regions correctly
Date: Mon, 17 Dec 2012 18:44:32 -0500 [thread overview]
Message-ID: <m27gog6y73.fsf@cube.luannocracy.com> (raw)
In-Reply-To: <50CFAAB7.9030209@stonybrook.edu> (Michael Kifer's message of "Mon, 17 Dec 2012 18:28:55 -0500")
on Mon Dec 17 2012, Michael Kifer <michael.kifer-AT-stonybrook.edu> wrote:
> On 12/17/2012 06:22 PM, Dave Abrahams wrote:
>
> on Fri Dec 14 2012, Michael Kifer <michael.kifer-AT-stonybrook.edu> wrote:
>
>
> I think it is a good patch. One question: shouldn't the message
> "Which buffer to compare to the merge buffer (A or B)? ")
> be then changed to this?
> "Which buffer to compare to the ancestor buffer (A or B)? ")
>
> This is not part of the #11320 patch.
>
> I have no opinion about the change from "merge" to "ancestor." It makes
> absolutely no difference to me which of those words Emacs uses; I'll
> interpret it exactly the same way. I suggest you accept the patch as-is
> and open a separate issue if you think the word is wrong.
>
> The merge buffer is not the ancestor buffer, so the message would be
> wrong and confusing.
> We should change both or none.
I can't understand the idea that you can't correct the behavior without
also correcting the text. They are separate issues related only by the
region of code in which they appear. Again, I have no opinion about
whether the text should change, so if you're going to tie them together,
please change the text too. The behavior is all that matters to me
--
Dave Abrahams
BoostPro Computing Software Development Training
http://www.boostpro.com Clang/LLVM/EDG Compilers C++ Boost
next prev parent reply other threads:[~2012-12-17 23:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 19:28 bug#11318: [Patchset] A bugfix and an arguable bugfix for ediff-inferior-compare-regions Dave Abrahams
2012-04-23 19:28 ` bug#11319: [PATCH 1/2] BUGFIX: select current-diff-comparison regions for ediff-inferior-compare-regions correctly Dave Abrahams
2012-12-14 15:23 ` Stefan Monnier
2012-12-14 17:17 ` Dave Abrahams
[not found] ` <e5472cbf85e944178dd2aebb9d6ed40a@HUBCAS1.cs.stonybrook.edu>
2012-12-15 4:46 ` Michael Kifer
2012-12-17 23:22 ` Dave Abrahams
2012-12-17 23:28 ` Michael Kifer
2012-12-17 23:44 ` Dave Abrahams [this message]
2012-12-18 0:01 ` Michael Kifer
2012-04-23 19:28 ` bug#11320: [PATCH 2/2] Useful behavior for ediff-inferior-compare-regions when merging with an ancestor Dave Abrahams
2018-05-12 2:03 ` Noam Postavsky
2018-06-29 2:13 ` Noam Postavsky
2012-05-10 1:05 ` bug#11318: [Patchset] A bugfix and an arguable bugfix for ediff-inferior-compare-regions Glenn Morris
2012-05-10 1:40 ` Dave Abrahams
2012-05-10 4:04 ` Stefan Monnier
2012-05-10 4:20 ` Glenn Morris
2012-05-12 17:18 ` Stefan Monnier
2012-07-21 2:30 ` Dave Abrahams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27gog6y73.fsf@cube.luannocracy.com \
--to=dave@boostpro.com \
--cc=11319-done@debbugs.gnu.org \
--cc=michael.kifer@stonybrook.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).