From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el Date: Sat, 18 Feb 2017 12:20:02 +0100 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487416877 26165 195.159.176.226 (18 Feb 2017 11:21:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2017 11:21:17 +0000 (UTC) To: 25784@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 18 12:21:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf34f-000696-8q for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Feb 2017 12:21:09 +0100 Original-Received: from localhost ([::1]:58088 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf34k-0001cC-Rh for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Feb 2017 06:21:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf34c-0001by-PQ for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:21:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf34Y-0002OA-PE for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:21:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46026) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cf34Y-0002O2-Ko for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cf34Y-0006RM-DC for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2017 11:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.148741683424697 (code B ref -1); Sat, 18 Feb 2017 11:21:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Feb 2017 11:20:34 +0000 Original-Received: from localhost ([127.0.0.1]:44225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf342-0006QA-JO for submit@debbugs.gnu.org; Sat, 18 Feb 2017 06:20:34 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf33x-0006Pu-KM for submit@debbugs.gnu.org; Sat, 18 Feb 2017 06:20:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf33o-00024N-JG for submit@debbugs.gnu.org; Sat, 18 Feb 2017 06:20:20 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:37237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cf33o-00024H-GQ for submit@debbugs.gnu.org; Sat, 18 Feb 2017 06:20:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf33k-0001Yi-Gf for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:20:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf33f-0001wo-Vs for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:20:12 -0500 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:51708) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cf33f-0001tn-Nh for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2017 06:20:07 -0500 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 91DF022367 for ; Sat, 18 Feb 2017 11:17:03 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-type:content-type:mime-version:message-id:date:date :subject:subject:to:from:from; s=dkim; t=1487416622; x= 1488280623; bh=xazz/vZKkBO553bc/ENFX5GBa9V9k51bz9k/Bf63l/w=; b=d 4Xk4nzBElKzzlymURgy/042qyjeHN9JaXIoduENA+W03cZZhbA6dvxhzcHjPGdmz JHaZvbxocUxx3+zX+uf4Qf2jIUt7kniRpFBPpHZtmeBSDa9ywaWp4W3eGUpifuUX pNeDoVyyYDRH/bRqoMo/hGc2iSWY9vy0ZjufATEnbs= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id d5Ea2n2ayueZ for ; Sat, 18 Feb 2017 11:17:02 +0000 (UTC) Original-Received: from gray (54.4.4.85.dynamic.wline.res.cust.swisscom.ch [85.4.4.54]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 2C2A42234F for ; Sat, 18 Feb 2017 11:17:01 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129496 Archived-At: `mouse-1' is bound in debbugs-gnu.el, which means that a nil value of `mouse-1-click-follows-link' is not respected. The following patch is needed: --- debbugs-0.12/debbugs-gnu.el.~2~ 2017-02-17 17:54:15.000000000 +0100 +++ debbugs-0.12/debbugs-gnu.el 2017-02-18 12:07:56.000000000 +0100 @@ -909,7 +909,6 @@ (menu-map (make-sparse-keymap))) (set-keymap-parent map tabulated-list-mode-map) (define-key map "\r" 'debbugs-gnu-select-report) - (define-key map [mouse-1] 'debbugs-gnu-select-report) (define-key map [mouse-2] 'debbugs-gnu-select-report) (define-key map "g" 'debbugs-gnu-rescan) (define-key map "R" 'debbugs-gnu-show-all-blocking-reports) @@ -1587,7 +1586,6 @@ (let ((map (make-sparse-keymap))) (set-keymap-parent map tabulated-list-mode-map) (define-key map "\r" 'debbugs-gnu-select-usertag) - (define-key map [mouse-1] 'debbugs-gnu-select-usertag) (define-key map [mouse-2] 'debbugs-gnu-select-usertag) map)) There already was a ChangeLog entry to this effect in the past: 2012-12-23 Lars Ingebrigtsen Don't explicitly bind mouse-1. As Michael Heerdegen says: However, also binding mouse-1 is not necessary. Depending on the setting of `mouse-1-click-follows-link', which is non-nil by default, mouse-1 already follows links - see its doc. We should leave it up to the user if he wants to use mouse-1 for following or not. But the change does not seem to have been made, or maybe it was reverted at some point.