From: charles@aurox.ch (Charles A. Roelli)
To: 25784@debbugs.gnu.org
Subject: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el
Date: Sat, 18 Feb 2017 12:20:02 +0100 [thread overview]
Message-ID: <m27f4nvj8d.fsf@aurox.ch> (raw)
`mouse-1' is bound in debbugs-gnu.el, which means that a nil value of
`mouse-1-click-follows-link' is not respected. The following patch is
needed:
--- debbugs-0.12/debbugs-gnu.el.~2~ 2017-02-17 17:54:15.000000000 +0100
+++ debbugs-0.12/debbugs-gnu.el 2017-02-18 12:07:56.000000000 +0100
@@ -909,7 +909,6 @@
(menu-map (make-sparse-keymap)))
(set-keymap-parent map tabulated-list-mode-map)
(define-key map "\r" 'debbugs-gnu-select-report)
- (define-key map [mouse-1] 'debbugs-gnu-select-report)
(define-key map [mouse-2] 'debbugs-gnu-select-report)
(define-key map "g" 'debbugs-gnu-rescan)
(define-key map "R" 'debbugs-gnu-show-all-blocking-reports)
@@ -1587,7 +1586,6 @@
(let ((map (make-sparse-keymap)))
(set-keymap-parent map tabulated-list-mode-map)
(define-key map "\r" 'debbugs-gnu-select-usertag)
- (define-key map [mouse-1] 'debbugs-gnu-select-usertag)
(define-key map [mouse-2] 'debbugs-gnu-select-usertag)
map))
There already was a ChangeLog entry to this effect in the past:
2012-12-23 Lars Ingebrigtsen <larsi@gnus.org>
Don't explicitly bind mouse-1.
As Michael Heerdegen <michael_heerdegen@web.de> says:
However, also binding mouse-1 is not necessary. Depending on the
setting of `mouse-1-click-follows-link', which is non-nil by default,
mouse-1 already follows links - see its doc. We should leave it up to
the user if he wants to use mouse-1 for following or not.
But the change does not seem to have been made, or maybe it was reverted
at some point.
next reply other threads:[~2017-02-18 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 11:20 Charles A. Roelli [this message]
2017-02-18 13:43 ` bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el Andreas Schwab
2017-02-19 11:22 ` Charles A. Roelli
2017-02-20 8:16 ` Michael Albinus
2017-02-20 8:55 ` Charles A. Roelli
2017-02-20 12:32 ` Michael Albinus
2017-02-20 19:40 ` Charles A. Roelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27f4nvj8d.fsf@aurox.ch \
--to=charles@aurox.ch \
--cc=25784@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).