From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#34723: 27.0.50; customize and improve diff-mode recentering Date: Thu, 07 Mar 2019 20:12:58 +0100 Message-ID: References: <87o96rprs3.fsf@mail.linkov.net> <83y35tcnci.fsf@gnu.org> <83pnr5cbqm.fsf@gnu.org> Reply-To: charles@aurox.ch Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="86760"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34723@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 07 20:21:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1ya8-000MS4-72 for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Mar 2019 20:21:28 +0100 Original-Received: from localhost ([127.0.0.1]:57977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1ya7-0006Fq-4b for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Mar 2019 14:21:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1yGX-0005r9-FX for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 14:01:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1yGS-0005rA-Ea for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 14:01:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50297) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1yGM-0005jj-3I for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 14:01:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1yGL-0006mZ-S6 for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 14:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Mar 2019 19:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34723 X-GNU-PR-Package: emacs Original-Received: via spool by 34723-submit@debbugs.gnu.org id=B34723.155198524526039 (code B ref 34723); Thu, 07 Mar 2019 19:01:01 +0000 Original-Received: (at 34723) by debbugs.gnu.org; 7 Mar 2019 19:00:45 +0000 Original-Received: from localhost ([127.0.0.1]:35608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1yG5-0006lu-5u for submit@debbugs.gnu.org; Thu, 07 Mar 2019 14:00:45 -0500 Original-Received: from nestroy.aurox.ch ([82.195.237.20]:41558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1yG2-0006lg-PU for 34723@debbugs.gnu.org; Thu, 07 Mar 2019 14:00:43 -0500 Original-Received: from nestroy.aurox.ch (nestroy.aurox.ch [127.0.0.1]) by nestroy.aurox.ch (Postfix) with ESMTP id 44Fg1w4g0RznBy for <34723@debbugs.gnu.org>; Thu, 7 Mar 2019 19:00:36 +0000 (UTC) Authentication-Results: nestroy.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim2; t=1551985235; x=1554577236; bh=W trjDYRutJtW+Pri0FmxbJMXIPmPRLixEIS0euwG02o=; b=uE5yHyPDch5AGXqW2 O6erUsXw8ulz2C0pDBXYvN3JRN9wLQ5ZcID8sdAES2jpRCuAHKe+wGQu8Z1ACZm+ ePw9uE2jBwdHMDXEQ6MGFY4s5Gip74TLiWY1q1hTeeS0g0gqlqzzWplzx4im4+XG 5myTKyWWPA/G5TU/kuqtiMLYms= X-Virus-Scanned: Debian amavisd-new at nestroy.aurox.ch Original-Received: from nestroy.aurox.ch ([127.0.0.1]) by nestroy.aurox.ch (nestroy.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id K1lftVGy1NbY for <34723@debbugs.gnu.org>; Thu, 7 Mar 2019 19:00:35 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1206:4512:5f50:c62c:3ff:fe30:b864]) by nestroy.aurox.ch (Postfix) with ESMTPSA id 44Fg1t5mMNznBf; Thu, 7 Mar 2019 19:00:34 +0000 (UTC) In-reply-to: <83pnr5cbqm.fsf@gnu.org> (message from Eli Zaretskii on Tue, 05 Mar 2019 22:22:41 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156126 Archived-At: > Date: Tue, 05 Mar 2019 22:22:41 +0200 > From: Eli Zaretskii > > It keeps point closer to the center of the window and away from the > window edges. I though that's what you wanted, because doing that > will show more context around the match. Right. I spoke earlier about calling reposition-window from diff-hunk-next as a possible replacement for recenter, and Juri suggested an equivalent behavior for Isearch, and the aim of these changes is to show the most useful context around point -- which does not necessarily mean keeping point close to the center of the window. For example, with the Isearch example I gave, point can end up anywhere in the window after searching, since reposition-window tries to position the first line of the function definition on the first screen line.