From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Philipp Newsgroups: gmane.emacs.bugs Subject: bug#39960: 28.0.50; Incompatible change to sql-add-product in Emacs 27 Date: Fri, 06 Mar 2020 23:39:16 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="98570"; mail-complaints-to="usenet@ciao.gmane.io" To: 39960@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 06 23:40:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jALdf-000PWE-FP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Mar 2020 23:40:15 +0100 Original-Received: from localhost ([::1]:43134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jALde-0007td-I5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Mar 2020 17:40:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47040) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jALdT-0007tI-W1 for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:40:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jALdS-0006YE-Jv for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40009) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jALdS-0006Xx-GW for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jALdS-00058P-9Q for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Mar 2020 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39960 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158353436619688 (code B ref -1); Fri, 06 Mar 2020 22:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Mar 2020 22:39:26 +0000 Original-Received: from localhost ([127.0.0.1]:45982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jALcs-00057U-5G for submit@debbugs.gnu.org; Fri, 06 Mar 2020 17:39:26 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:58223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jALcq-00057M-Tt for submit@debbugs.gnu.org; Fri, 06 Mar 2020 17:39:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46024) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jALco-0007PU-An for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:39:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jALcm-0004xW-Os for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:39:22 -0500 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:42035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jALcm-0004tT-G9 for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2020 17:39:20 -0500 Original-Received: by mail-wr1-x432.google.com with SMTP id v11so4134706wrm.9 for ; Fri, 06 Mar 2020 14:39:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=+kNaoSHDSh0WGpBEcoqgGmpb8ajgjrMtL9u2ku25sZ0=; b=QoCmFytkoBlQJpfmnKcGsM5/IZ7LfuncAq+y+s6BwjykG0m5jS07zNMC69XOyPgweV O9yEY9BFNEAqxdoEOHRIM3px5gbOtv+WyMufYhIKMvE9wJZBN9an1Z2pgYgzhWVJv0RA 6NuoLrFXPNZ8IjgIW2AaiqbrL3AIH28gO3wCIyqLGOwWbLtu84Y8lS8m/0KaDmgkhxGF Mu4dQRbgXYJevQwwrEhPF3uV1IUYNegaJWdH0EGa9RiCgk9E8F0+RCw+3/xGYUW6bjh2 FgALjNwX2hvamRZZe/XVe3T7FnMJwGnMlm5eKFXvnE54gocVr0GNhqdudSjdPBuLzFKO 3tSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=+kNaoSHDSh0WGpBEcoqgGmpb8ajgjrMtL9u2ku25sZ0=; b=eNDomoPau3N89A+xUS14K7ss9AHqmfPWU5vzMqwks2IzErf9Tf4roB+ZoeJI8MkvhK wdTtkqu+cL4bBoNmctxmG0yudEp1jKn3Zh1Hj0yz1iVhriyTmZq9PERq5wbXUlDPAUi0 /jXEMJqEDUp3obLHVIcLtt0yVS//3JOyBp+DiCYRrqPvlJb2mSFuE2POeFp+iN4Ehc5z 0ckcjX3WM870KnTNdXUhUpppc8EiT83gYRoV7DXNlCziHflKQ7h8jqfqg6v8/IC+dtog yaeqTATtR1SL/DWjZwCY1Ly+KDmFuZYhcwV4+4faf3x8BOxuttygBdXDFpOpRIVLny64 mK2Q== X-Gm-Message-State: ANhLgQ3ODhDvm8+8r+vZuAEakTawAuz/MV7SOEbjC3C2+LSJm7Hrc43c PDEFDk9ibJm/BYgMaRfN7ipUbpl1 X-Google-Smtp-Source: ADFU+vtq4e5lRUG0KBfknYfM+WSY3lgKCTyl8cx7EboYh6gF8H4Gfm+ke5D1ZrL34BNSKuHb1PAIZg== X-Received: by 2002:adf:e506:: with SMTP id j6mr5903557wrm.309.1583534358378; Fri, 06 Mar 2020 14:39:18 -0800 (PST) Original-Received: from p (85.233.42.145.dynamic.cablesurf.de. [85.233.42.145]) by smtp.gmail.com with ESMTPSA id c62sm15676994wmd.7.2020.03.06.14.39.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 14:39:17 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176978 Archived-At: In Emacs 26, sql-add-product has the signature (sql-add-product PRODUCT DISPLAY &rest PLIST) However, in the Emacs 27 pretest the signature is now (sql-add-product PRODUCT DISPLAY &optional PLIST) Note the change from &rest to &optional. This is a breaking change that breaks all users of sql-add-product. I've found quite a few uses of the old signature in the wild, e.g. https://github.com/kat-co/sql-prestodb/blob/f4a74d88dcb166445bb41efb865147c0faf1de3a/src/sql-presto.el#L59 or https://github.com/r0man/vertica-el/blob/3c9647b425c5c13c30bf0cba483646af18196588/vertica.el#L68 or https://github.com/jterk/sql-impala/blob/466e7c0c789ec3e5e8a276c8f6754f91bb584c3e/sql-impala.el#L71. This change was introduced in commit c124d5323c05a4010db9b2d330575d029936ade1. I don't think we should introduce such a breaking change to a widely-used public function; at the very least, Emacs 27 should accept both signatures. In GNU Emacs 28.0.50 (build 39, x86_64-apple-darwin19.3.0, NS appkit-1894.30 Version 10.15.3 (Build 19D76)) of 2020-02-29 Repository revision: 3d2c82ac96a7f37e60b2b85a5c9c1d792084ab54 Repository branch: master Windowing system distributor 'Apple', version 10.3.1894 System Description: Mac OS X 10.15.3 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --with-modules --without-xml2 --without-pop --with-mailutils --enable-gcc-warnings=warn-only --enable-checking=all --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0'' Configured features: NOTIFY KQUEUE ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars subr-x rx gnutls puny seq byte-opt gv bytecomp byte-compile cconv dbus xml cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 60470 5746) (symbols 48 8045 0) (strings 32 20761 1931) (string-bytes 1 688813) (vectors 16 12996) (vector-slots 8 167493 10214) (floats 8 27 19) (intervals 56 196 0) (buffers 1000 11))