From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gemini Lasswell Newsgroups: gmane.emacs.bugs Subject: bug#25068: 25.1; Edebug fails to instrument code which uses propertized strings Date: Sat, 04 Feb 2017 17:49:49 -0800 Message-ID: References: <83inoq8adw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1486259476 6506 195.159.176.226 (5 Feb 2017 01:51:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Feb 2017 01:51:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (darwin) Cc: 25068@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 05 02:51:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caBys-0001Iw-IH for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Feb 2017 02:51:06 +0100 Original-Received: from localhost ([::1]:41496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caByx-0005LB-Qr for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 20:51:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caByr-0005Kl-CX for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 20:51:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caByo-0003KP-7c for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 20:51:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1caByo-0003KL-3t for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 20:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1caByn-0007o5-QW for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 20:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2017 01:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25068-submit@debbugs.gnu.org id=B25068.148625941829960 (code B ref 25068); Sun, 05 Feb 2017 01:51:01 +0000 Original-Received: (at 25068) by debbugs.gnu.org; 5 Feb 2017 01:50:18 +0000 Original-Received: from localhost ([127.0.0.1]:56404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caBy5-0007n9-N3 for submit@debbugs.gnu.org; Sat, 04 Feb 2017 20:50:17 -0500 Original-Received: from aibo.runbox.com ([91.220.196.211]:50942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caBy4-0007n1-6K for 25068@debbugs.gnu.org; Sat, 04 Feb 2017 20:50:16 -0500 Original-Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1caBy1-0005Bh-L8; Sun, 05 Feb 2017 02:50:13 +0100 Original-Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=rainbow.local) by mailfront11.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1caBxn-0004hZ-RN; Sun, 05 Feb 2017 02:50:00 +0100 In-Reply-To: (Gemini Lasswell's message of "Sat, 04 Feb 2017 09:39:51 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128974 Archived-At: --=-=-= Content-Type: text/plain Gemini Lasswell writes: > This could be fixed by updating the list in edebug-read-function of > characters that might possibly follow # to keep up with the changes to > read1 since the last time that list was updated (in 2001). But I think > it's better to remove the test entirely. If there is an invalid > character then read1 will report a syntax error. Ooops, attached the wrong patch. Here's the right one: --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-Remove-syntax-error-check-from-edebug-read-function-.patch >From 781b23e55488f80ab310f376cf27b5066fea7114 Mon Sep 17 00:00:00 2001 From: Gemini Lasswell Date: Sat, 4 Feb 2017 08:39:55 -0800 Subject: [PATCH] Remove syntax error check from edebug-read-function (Bug#25068) * lisp/emacs-lisp/edebug.el (edebug-read-function): Allow `read' to decide what is and isn't a syntax error. --- lisp/emacs-lisp/edebug.el | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index ec0f08d..a883804 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -880,11 +880,9 @@ edebug-read-function (list (edebug-storing-offsets (- (point) 2) 'function) (edebug-read-storing-offsets stream))) - ((memq (following-char) '(?: ?B ?O ?X ?b ?o ?x ?1 ?2 ?3 ?4 ?5 ?6 - ?7 ?8 ?9 ?0)) + (t (backward-char 1) - (read stream)) - (t (edebug-syntax-error "Bad char after #")))) + (read stream)))) (defun edebug-read-list (stream) (forward-char 1) ; skip \( -- 2.10.1 --=-=-=--