From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#33780: network-stream.el: network-stream-certificate always returns nil Date: Mon, 14 Jan 2019 18:40:59 +0100 Message-ID: References: <36f7918ec93135504092dc856a4490c846f6e947.camel@dracon.is> <97b430dc5524473a7ed3af1b903644880db057ff.camel@dracon.is> <83o98mf7sv.fsf@gnu.org> <83imyrdyae.fsf@gnu.org> <83bm4jdw86.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1547487609 5716 195.159.176.226 (14 Jan 2019 17:40:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Jan 2019 17:40:09 +0000 (UTC) Cc: darael@dracon.is, tzz@lifelogs.com, 33780@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 14 18:40:05 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj6DV-0001MB-4k for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jan 2019 18:40:05 +0100 Original-Received: from localhost ([127.0.0.1]:57454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj6Fb-00036I-Vn for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jan 2019 12:42:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj6FU-00036C-UA for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 12:42:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj6FQ-0005Y3-Vn for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 12:42:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60007) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gj6FO-0005Wr-1t for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 12:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gj6FN-0001iA-U5 for bug-gnu-emacs@gnu.org; Mon, 14 Jan 2019 12:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Jan 2019 17:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33780 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33780-submit@debbugs.gnu.org id=B33780.15474876706514 (code B ref 33780); Mon, 14 Jan 2019 17:42:01 +0000 Original-Received: (at 33780) by debbugs.gnu.org; 14 Jan 2019 17:41:10 +0000 Original-Received: from localhost ([127.0.0.1]:59288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj6EX-0001h0-Q7 for submit@debbugs.gnu.org; Mon, 14 Jan 2019 12:41:10 -0500 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:32963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gj6EW-0001gi-CD for 33780@debbugs.gnu.org; Mon, 14 Jan 2019 12:41:08 -0500 Original-Received: by mail-wr1-f46.google.com with SMTP id c14so24007776wrr.0 for <33780@debbugs.gnu.org>; Mon, 14 Jan 2019 09:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=JU4fJPi1lWrGC+mm5lRsf7D3HNZa9fERpTdaaSXMgZo=; b=b03xDKKT4AH/1IC4+rPEAKf2wjGW1JRyyJ+1BwmeKt9EDmWs1PR9NUHa8oubSZxfga UBThsuXIf/VqClrB5Y+9akQaKBD+HoxGV0JWH0lWKv/lBqQfXXkfmhHhpHu8Ck/e6BD4 A/KJWz30NFeddPv6owCGF+cM/qqfedVblH3aXG81m6myuRqO3GFexrB+mXS+XGAolCc5 TG068YGSTM9EwKapitYSHrRHngLGDjOlf2blTDSyEuNbrBsOT/77k99usPFGugTmsun8 BasWQUB+wnT6uSedCKU3Iba4vVowIu9hr7L92aFR2XKX++8WPfcK6qsGm4AZLxzigIyX yz5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=JU4fJPi1lWrGC+mm5lRsf7D3HNZa9fERpTdaaSXMgZo=; b=EtN5XRrXz6ZQdk8f5qzs30H68cIx0osAf9Oknp3Y1oU3GWcmt/3029qTvaYWC7GWRT Sk8gI2Riqj1DH6Iac1RyOYc5S2y+Ap/8r3bhqDno7B7OKn3p8Efy6CaJnlnQp3Z+s50j zUSpatVUapsTIputceIHX69hdGtDwtvmksUMctB4FtRgvcMb4WIYhn7gBxbSsZIxzLbV n67Y5tbH6QBjGdY4z3sHcqBA56KgMyqsZs8hVlmdcOeqLLHjftjaQtLw8oSNnkykZWIn Zot+0ZaLptv1G/UrFUgKd8nLQXvgRBNUuapAi0St2DpmBqYmuPJdZV6e/rTWhxO7bWdG EsKQ== X-Gm-Message-State: AJcUukc/l2ADFt3xMyQ5ebHXk5V3Pxwl1HQFx4UTBPRm5FFyHUj5O1SW L5t++DGMYM/sHXp3mJadCEhupyvH X-Google-Smtp-Source: ALg8bN501XK2F4jmtc5VUza/XX/M27aPetuAEivXRmu3W9e4g5Dvd8sHLLmmuISyW2ET0JSoVhlQGg== X-Received: by 2002:a5d:50c5:: with SMTP id f5mr24354432wrt.37.1547487661958; Mon, 14 Jan 2019 09:41:01 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id g67sm54064182wmd.38.2019.01.14.09.41.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 09:41:00 -0800 (PST) In-Reply-To: <83bm4jdw86.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Jan 2019 18:45:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154440 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: darael@dracon.is, tzz@lifelogs.com, 33780@debbugs.gnu.org >> Date: Mon, 14 Jan 2019 17:25:55 +0100 >>=20 >> When running the test suite, we=CA=BCre in batch mode, so there=CA=BCs n= o way to >> answer that question, as far as I know, so turning off the nsm is the >> only way to go. > > You could also override the nsm-query-user function, I think. > True. >> This only fails for the existing tests with ':nowait t', since then I >> suspect nsm gets called automatically, whilst in the ':nowait nil' >> case nsm never gets called (the existing tests all use >> 'make-network-process' directly, rather than 'open-network-stream', so >> they bypass nsm). > > I don't think I understood why nsm gets called only in the ":nowait t" > case. What did I miss? process.c has: #ifdef HAVE_GNUTLS static void finish_after_tls_connection (Lisp_Object proc) { struct Lisp_Process *p =3D XPROCESS (proc); Lisp_Object contact =3D p->childp; Lisp_Object result =3D Qt; if (!NILP (Ffboundp (Qnsm_verify_connection))) result =3D call3 (Qnsm_verify_connection, proc, Fplist_get (contact, QChost), Fplist_get (contact, QCservice)); so loading nsm.el causes nsm-verify-connection to get called in the ':nowait t' case. Presumably in the ':nowait nil' case gnutls-boot has already completed the tls connection, and finish_after_tls_connection never gets called (that=CA=BCs speculation on my part). I don=CA=BCt know t= he GnuTLS code well enough to know if this is a bug. Ted? Robert