From: Robert Pluim <rpluim@gmail.com>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: Evgeny Zajcev <lg.zevlg@gmail.com>, 39133@debbugs.gnu.org
Subject: bug#39133: 28.0.50; Emacs slowdown on special char
Date: Wed, 15 Jan 2020 09:25:43 +0100 [thread overview]
Message-ID: <m25zhdqg6w.fsf@gmail.com> (raw)
In-Reply-To: <CAO=W_ZrSPweeZ+kKUruMnuHuaJD3KqLMSKr53qoGe4X5-f8LeA@mail.gmail.com>
>>>>> On Wed, 15 Jan 2020 13:26:11 +0900, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> said:
YAMAMOTO> 0xFFFFFFFF comes from FONT_INVALID_CODE. font->driver->text_extents
YAMAMOTO> shouldn't be called if font->font->driver->encode_char returns it.
YAMAMOTO> diff --git a/src/font.c b/src/font.c
YAMAMOTO> index 2b90903c90..03e6176220 100644
YAMAMOTO> --- a/src/font.c
YAMAMOTO> +++ b/src/font.c
YAMAMOTO> @@ -4420,15 +4420,19 @@ font_fill_lglyph_metrics (Lisp_Object glyph, Lisp_Object font_object)
YAMAMOTO> {
YAMAMOTO> struct font *font = XFONT_OBJECT (font_object);
YAMAMOTO> unsigned code = font->driver->encode_char (font, LGLYPH_CHAR (glyph));
YAMAMOTO> - struct font_metrics metrics;
YAMAMOTO> -
YAMAMOTO> - LGLYPH_SET_CODE (glyph, code);
YAMAMOTO> - font->driver->text_extents (font, &code, 1, &metrics);
YAMAMOTO> - LGLYPH_SET_LBEARING (glyph, metrics.lbearing);
YAMAMOTO> - LGLYPH_SET_RBEARING (glyph, metrics.rbearing);
YAMAMOTO> - LGLYPH_SET_WIDTH (glyph, metrics.width);
YAMAMOTO> - LGLYPH_SET_ASCENT (glyph, metrics.ascent);
YAMAMOTO> - LGLYPH_SET_DESCENT (glyph, metrics.descent);
YAMAMOTO> +
YAMAMOTO> + if (code != FONT_INVALID_CODE)
YAMAMOTO> + {
YAMAMOTO> + struct font_metrics metrics;
YAMAMOTO> +
YAMAMOTO> + LGLYPH_SET_CODE (glyph, code);
YAMAMOTO> + font->driver->text_extents (font, &code, 1, &metrics);
YAMAMOTO> + LGLYPH_SET_LBEARING (glyph, metrics.lbearing);
YAMAMOTO> + LGLYPH_SET_RBEARING (glyph, metrics.rbearing);
YAMAMOTO> + LGLYPH_SET_WIDTH (glyph, metrics.width);
YAMAMOTO> + LGLYPH_SET_ASCENT (glyph, metrics.ascent);
YAMAMOTO> + LGLYPH_SET_DESCENT (glyph, metrics.descent);
YAMAMOTO> + }
YAMAMOTO> }
YAMAMOTO> But I'm not sure if it is ok to leave the code and metrics-related
YAMAMOTO> fields nil when encode_char returns FONT_INVALID_CODE. Handa-san?
I donʼt know either, but your patch fixes the slowdown and Iʼve seen
no negative effects yet.
Robert
next prev parent reply other threads:[~2020-01-15 8:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 13:21 bug#39133: 28.0.50; Emacs slowdown on special char Evgeny Zajcev
2020-01-14 15:26 ` Eli Zaretskii
2020-01-14 16:24 ` Robert Pluim
2020-01-15 4:26 ` YAMAMOTO Mitsuharu
2020-01-15 8:25 ` Robert Pluim [this message]
2020-01-15 10:47 ` Evgeny Zajcev
2020-01-15 16:19 ` Eli Zaretskii
2020-01-24 10:13 ` Robert Pluim
2020-01-24 10:22 ` Eli Zaretskii
2020-01-24 13:09 ` Robert Pluim
2020-01-24 13:40 ` Eli Zaretskii
2020-01-24 13:50 ` Robert Pluim
2020-01-24 15:41 ` Robert Pluim
2020-01-24 15:52 ` Eli Zaretskii
2020-03-02 7:40 ` Robert Pluim
2020-03-02 8:49 ` Eli Zaretskii
2020-03-02 9:25 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m25zhdqg6w.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=39133@debbugs.gnu.org \
--cc=lg.zevlg@gmail.com \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).