From: Robert Pluim <rpluim@gmail.com>
To: Philip Kaludercic <philip.kaludercic@fau.de>
Cc: 39965@debbugs.gnu.org
Subject: bug#39965: [PATCH] Add support for multiple gravatar-like services
Date: Mon, 09 Mar 2020 16:35:45 +0100 [thread overview]
Message-ID: <m25zfdee26.fsf@gmail.com> (raw)
In-Reply-To: <ykgnh7yxpnrb.fsf@fau.de> (Philip Kaludercic's message of "Mon, 09 Mar 2020 16:10:48 +0100")
>>>>> On Mon, 09 Mar 2020 16:10:48 +0100, Philip Kaludercic <philip.kaludercic@fau.de> said:
Philip> In that case I'm attaching the patch to this mail, I hope Gnus handels
Philip> it corretly.
I hand't realised you were using the One True Emacs Mail Agent. Of
course it works.
Philip> From 5c967bc9e2c3bc72e3803d84b23b8b121328c49c Mon Sep 17 00:00:00 2001
Philip> From: Philip K <philip@warpmail.net>
Philip> Date: Fri, 6 Mar 2020 12:40:28 +0100
Philip> Subject: [PATCH] Add support for multiple gravatar-like services
Philip> Specifically, the non-proprietary services libravatar (now default)
Philip> and unicornify have been added. The behaviour is customised via the
Philip> new variable `gravatar-service'.
This is missing a ChangeLog style comment. There are various ways to
produce that, the easiest is probably:
C-x v d ; vc-dir
m ; mark the files you want to commit
v ; vc-next-action, which will put you in a commit message buffer
C-c C-w ; this will look through the diffs of the files youʼre
; commiting and pre-populate the commit message with
; file/function/variable names. You then fill in the details
; of what you changed.
Of course, a preamble like you had explaining the 'why' of the change
is also good.
See "** Commit messages" in CONTRIBUTE for a more detailed description
of the desired format for commit messages.
Philip> +---
Philip> +*** New variable `gravatar-service' changes avatar service.
Philip> +Now supports Libravatar (as default) and Unicornify, next to the
Philip> +already implemented Gravatar.
Philip> +
We normally call these 'user options', and donʼt use back-quotes in
NEWS, and try to have the first line be a complete sentence, so:
** Gravatar
===
*** New user-option 'gravatar-service' for host to query for gravatars.
Defaults to Libravatar, with Unicornify and Gravatar as options.
Thanks for your patch.
Robert
next prev parent reply other threads:[~2020-03-09 15:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87mu8ej1pg.fsf@bulbul>
2020-03-07 0:11 ` bug#39965: [PATCH] Add support for multiple gravatar-like services Philip K
2020-03-07 7:51 ` Eli Zaretskii
2020-03-09 10:39 ` Robert Pluim
[not found] ` <ykgnr1y1poro.fsf@fau.de>
2020-03-09 15:04 ` Robert Pluim
2020-03-09 15:10 ` Philip Kaludercic
2020-03-09 15:35 ` Robert Pluim [this message]
2020-03-09 23:53 ` Philip K.
2020-03-10 1:58 ` Noam Postavsky
2020-03-10 9:31 ` Philip K.
2020-03-11 7:38 ` Robert Pluim
2020-03-11 8:50 ` Philip Kaludercic
2020-03-11 16:09 ` Eli Zaretskii
2020-03-11 16:08 ` Eli Zaretskii
2020-03-11 17:00 ` Philip K.
2020-03-12 7:41 ` Robert Pluim
2020-03-17 13:51 ` Robert Pluim
2020-03-17 14:37 ` Philip K.
2020-03-24 17:00 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m25zfdee26.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=39965@debbugs.gnu.org \
--cc=philip.kaludercic@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).