bug#48865: [PATCH] Allow ‘ns-hide-emacs’ to bring only the selected frame forward

[Matt Beshara <m@mfa.pw>]

[-- Attachment #1.1: Type: text/plain, Size: 1091 bytes --]


Alan Third <alan@idiocy.org> writes:

Hi Alan,
I’ve attached an updated patch.
Is the commit message OK?

Matt

> On Sun, Jun 06, 2021 at 03:23:31PM +1000, Matt Beshara wrote:
>> Hi there,
>> I have attached a patch which adds a new capability to the 
>> ‘ns-hide-emacs’
>> function in the NS port.  Specifically, it causes the 
>> ‘ns-hide-emacs’
>> function to respond to being called with the argument 
>> 'activate-front in a
>> similar way to how it responds when called with 'activate.  The 
>> difference
>> is, instead of layering every Emacs frame in front of every 
>> other
>> application’s windows, it only brings the selected frame 
>> forward.  I have
>> uploaded a small video of the new functionality in action here:
>> https://mfa.pw/activate-front.mp4
>
> Hi, I don't see any problems with this.
>
>> Please let me know if any modifications would need to be made 
>> to
>> this patch before it could be accepted.
>
> If you could fill out the commit message in line with 
> CONTRIBUTE, that
> would be great.
>
> Thanks!


[-- Attachment #1.2: activate-front-2.patch --]
[-- Type: text/x-patch, Size: 1835 bytes --]

From 6458bf34fd29dbc34ac0f91a087dbaaccc6c13a3 Mon Sep 17 00:00:00 2001
From: Matt Beshara <m@mfa.pw>
Date: Sun, 6 Jun 2021 13:06:47 +1000
Subject: [PATCH] * src/nsfns.m (Fns_hide_emacs): Allow activating only
 selected frame
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Causes ‘ns-hide-emacs’ to layer the selected frame in front of every other
application’s windows, and give that frame keyboard focus, when called with
'activate-front.
---
 src/nsfns.m | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/src/nsfns.m b/src/nsfns.m
index 98801d8526..454a6fdab6 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -1953,8 +1953,11 @@ Frames are listed from topmost (first) to bottommost (last).  */)
        doc: /* If ON is non-nil, the entire Emacs application is hidden.
 Otherwise if Emacs is hidden, it is unhidden.
 If ON is equal to `activate', Emacs is unhidden and becomes
-the active application.  */)
-     (Lisp_Object on)
+the active application.
+If ON is equal to `activate-front', Emacs is unhidden and
+becomes the active application, but only the selected frame
+is layered in front of the windows of other applications.  */)
+  (Lisp_Object on)
 {
   check_window_system (NULL);
   if (EQ (on, intern ("activate")))
@@ -1962,6 +1965,12 @@ Frames are listed from topmost (first) to bottommost (last).  */)
       [NSApp unhide: NSApp];
       [NSApp activateIgnoringOtherApps: YES];
     }
+  else if (EQ (on, intern ("activate-front")))
+    {
+      [NSApp unhide: NSApp];
+      [[NSRunningApplication currentApplication]
+        activateWithOptions: NSApplicationActivateIgnoringOtherApps];
+    }
   else if (NILP (on))
     [NSApp unhide: NSApp];
   else
-- 
2.24.3 (Apple Git-128)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 239 bytes --]