From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#57727: 29.0.50; Optimize tty display updates Date: Sun, 18 Sep 2022 07:34:54 +0200 Message-ID: References: <877d21g12q.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7457"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: 57727@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 18 07:36:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZmyS-0001iO-Cu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 07:36:12 +0200 Original-Received: from localhost ([::1]:42774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZmyQ-0000Yy-O3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 01:36:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZmyI-0000Ya-6j for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 01:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZmyH-0004s4-UX for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 01:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZmyH-0004dE-PS for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 01:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 05:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57727 X-GNU-PR-Package: emacs Original-Received: via spool by 57727-submit@debbugs.gnu.org id=B57727.166347930417732 (code B ref 57727); Sun, 18 Sep 2022 05:36:01 +0000 Original-Received: (at 57727) by debbugs.gnu.org; 18 Sep 2022 05:35:04 +0000 Original-Received: from localhost ([127.0.0.1]:47559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZmxL-0004bv-M5 for submit@debbugs.gnu.org; Sun, 18 Sep 2022 01:35:03 -0400 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:38435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZmxJ-0004bM-Oc for 57727@debbugs.gnu.org; Sun, 18 Sep 2022 01:35:02 -0400 Original-Received: by mail-wr1-f48.google.com with SMTP id b5so42168436wrr.5 for <57727@debbugs.gnu.org>; Sat, 17 Sep 2022 22:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=jCGw78XSxoYU2Xt43l9PwsPMM6DtEt8xF1oQOZgC8Sc=; b=XWz2E50DtiGlzXza1aBvn6hTt8HoBWZ9L7ONYAauG3pxJOYesBPmp7ICk+gh3MpZjN mxC+MJpN+YPLUSChKfvz4vKvTX9F+3U4oTb3L+15BZNWWNP/MFS+mCmPwy1HYyrMLC2F kUxjzzscvLPr7UpDn4ibYcWe6g2Nw2XywQaCQpQI9nRqthRjW+FmhRMy0nmKoMfxuJ8O 8PT+rXCj0mldEexoWvyDtJqVLl9v0A6T6vaUCIIVTQPuTq5lhmFCtYoxkqzXMflxDmZ3 WzDSKhxK20zsc2QA7hs0PJsg5vhcNMCqcgEzERb926NgZ35kxIN27MyqHm31xgB97Iy8 lVOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=jCGw78XSxoYU2Xt43l9PwsPMM6DtEt8xF1oQOZgC8Sc=; b=6SQlqxappBm3Ls3Ssms1f8+xHKtHmqUFAhwjwocRBbAvYbOhDe9QiwR3I9gF8Pjl2Z fGcMie4bnUOKrLkUoTbsRvyd+IGLTgGp3CInsII2+Ul2k9kRt3uIhnaiYT6V+CFqd3Ml CqJoOAga0mApPe5dcHymJmKFtBOFhpYgJ8PuJUlr4Bc0aV+oV8QFuDmzqaacNtf/5It7 qOeeyRj2t7K2AKAyKMYVEk4osPy7DGJlsxrXsG85IDFycJppkD8rCt8DZbKu81rmGhvB Uval/11T+nOLcZpxdw5xPFLHKuBTfnYqRaU092CTobCqHg84HEeCga3isbLVjtk+bnPk y5dw== X-Gm-Message-State: ACrzQf1pbt5N/ATgQi9F3auoQDFJibA3Ap21PFRHVEAk747fL4H/Hxy6 CM6iiFfVVwVAQFLoTVVcfk9ndJQBQLD0ug== X-Google-Smtp-Source: AMsMyM7eusNhKoEz2fsekIJ46hTG15GH1QsTt90CPNyXvEJMTLrLnUvD4cWWNZQVaCUSx6qWqIfWiQ== X-Received: by 2002:a05:6000:1881:b0:222:c899:cac6 with SMTP id a1-20020a056000188100b00222c899cac6mr6900190wri.283.1663479295465; Sat, 17 Sep 2022 22:34:55 -0700 (PDT) Original-Received: from Mini.fritz.box (pd9e3614c.dip0.t-ipconnect.de. [217.227.97.76]) by smtp.gmail.com with ESMTPSA id o38-20020a05600c512600b003b47b913901sm2749614wms.1.2022.09.17.22.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 22:34:54 -0700 (PDT) In-Reply-To: <877d21g12q.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 18 Sep 2022 00:09:33 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242920 Archived-At: "Basil L. Contovounesios" writes: > What should tty--output-buffer-size do when called from a graphical > terminal (i.e. when decode_tty_terminal returns NULL)? > > It currently crashes, but that's what every other C program is doing, > very banal. Maybe Emacs should do something more eccentric, like return > 0 or -1, signal an error, or do my taxes as consolation. Oops, it should signal. > Just curious: given this is an internal "--" function, do we want to > tell the user what a valid size would be? E.g. along the lines of: > > size_t sz = check_uinteger_max (size, min (MOST_POSITIVE_FIXNUM, SIZE_MAX)); > > Or would that be too much? > > BTW, is there a known upper limit for the buffer size in the OS? I didn't want to do that because I don't know how to determine SIZE_MAX, so I let users do what the like, as long as it doesn't make Emacs crash :-). > >> + Fsuspend_tty(tty); >> + struct terminal *terminal = decode_tty_terminal (tty); > > Here, terminal should theoretically be non-NULL, as Fsuspend_tty would > have otherwise signalled. Maybe we should eassert this assumption, or > explicitly check for NULL? I don't think that's necessary, or in other words, I think eassert wouldn't give as valuable addtional information here.