From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: Re: bug#831: 23.0.60; error in nsfonts.m Date: Sun, 07 Sep 2008 06:26:03 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: References: <9oljyep93x.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1220787634 25318 80.91.229.12 (7 Sep 2008 11:40:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Sep 2008 11:40:34 +0000 (UTC) Cc: emacs-app-dev-@lists.sourceforge.net, Kenichi Handa To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 07 13:41:29 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KcIe0-0003CE-2i for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Sep 2008 13:41:28 +0200 Original-Received: from localhost ([127.0.0.1]:60517 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcId0-0001iO-62 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Sep 2008 07:40:26 -0400 Original-Path: news.stanford.edu!newsfeed.stanford.edu!news.tele.dk!news.tele.dk!small.news.tele.dk!newsgate.cistron.nl!xs4all!news2.euro.net!newsfeed.freenet.de!news.albasani.net!not-for-mail Original-Newsgroups: gnu.emacs.bug Original-Lines: 43 Original-X-Trace: news.albasani.net gY8IfhH2W99OiEVzjCw4rXt9jGoEVnZMzgQR8aDslUirl3N2nMBdifRMi8I5nHl9ANvifV38uuzGsy5gAnPLIj/G3Hd/zecXvaJm0bc4QLqG6Ov7Y1HTWnGl31BbzV1s Original-X-Complaints-To: abuse@albasani.net Original-NNTP-Posting-Date: Sun, 7 Sep 2008 11:26:03 +0000 (UTC) X-User-ID: SHPtLYOR0Vn4EIuxsf1MYDZvaKzoSWCrx9vrngNcJSM= X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Cancel-Lock: sha1:Buxq2vcUBB+wb2asCbP3kBQRQyA= sha1:grC6+MqYzpyqtq2FqeUuwmQg83E= User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (darwin) X-NNTP-Posting-Host: ASjWsC5i3JE0bMUifJXDKTbZd7RQ2Q9JazlkXaBxXHk= Original-Xref: news.stanford.edu gnu.emacs.bug:47480 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20276 Archived-At: On Sun, 31 Aug 2008 13:49:32 -0400 "Austin Frank" wrote: AF> On Sat, Aug 30, 2008 at 3:59 PM, Glenn Morris wrote: >> Austin Frank wrote: >> >>> I'm trying to build emacs from a current CVS checkout on OSX 10.4.11 >>> with the configure option --with-ns. >>> >>> Build fails because of error in nsfonts.m. That file references a >>> variable called gidx, which is not defined in the relevant structure. >>> The attached patch changes all instances of gidx to x, and allows emacs >>> to build on my system. >> >> That may happen to build, but I don't believe it to be the correct fix. >> >> This is fallout from: >> >> 2008-08-29 Kenichi Handa >> >> * dispextern.h (struct glyph_string): Delete the member gidx. >> New members cmp_id, cmp_from, and cmp_to. >> >> (There are also some out-of-date comments in xdisp.c that still refer >> to gidx.) AF> Yes, you're right that this builds but doesn't actually work. Sorry AF> that I didn't dive deeper in debugging! Unfortunately I don't have AF> time to work on a patch-- apologies. I'll keep an eye on CVS for AF> changes to nsfonts.m and xdisp.c. I used the data member rename patch Austin and others suggested for two days now without problems. It lets Emacs build on Mac OS X and despite being insufficient as a full fix, at least the users don't have to wait for the full fix to have a working compile. I comitted this change to the Emacs CVS HEAD, including fixing the references to gidx in the xdisp.c docs, and will back it out (or anyone else can back it out) if it's a problem. I apologize in advance if that's the case. All the gidx references are changed to cmp_from, that's all it does. Thanks Ted