From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#11508: 24.1.50; Off-by-one error in xg_select? Date: Sat, 19 May 2012 11:52:50 +0200 Message-ID: References: <4FB64B05.6020709@cornell.edu> <3B902B7C-C59A-4933-A6AA-E23DB052704C@swipnet.se> <73ED1C31-12C1-4424-9DEC-632A1F0050D4@swipnet.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1337421231 26227 80.91.229.3 (19 May 2012 09:53:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 19 May 2012 09:53:51 +0000 (UTC) Cc: 11508@debbugs.gnu.org To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 19 11:53:50 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SVgM3-0006UZ-7R for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 May 2012 11:53:43 +0200 Original-Received: from localhost ([::1]:54900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVgM2-0007Mj-N9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 May 2012 05:53:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVgLz-0007Mc-2X for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 05:53:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVgLx-0008O1-Ai for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 05:53:38 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVgLx-0008Nx-7Q for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 05:53:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SVgMM-0005fN-8i for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 05:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 May 2012 09:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11508 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11508-submit@debbugs.gnu.org id=B11508.133742122321757 (code B ref 11508); Sat, 19 May 2012 09:54:02 +0000 Original-Received: (at 11508) by debbugs.gnu.org; 19 May 2012 09:53:43 +0000 Original-Received: from localhost ([127.0.0.1]:33659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVgM2-0005es-Jj for submit@debbugs.gnu.org; Sat, 19 May 2012 05:53:43 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:58572) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVgLi-0005eN-Am for 11508@debbugs.gnu.org; Sat, 19 May 2012 05:53:41 -0400 Original-Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3VvhPy2VMXz3hhY6; Sat, 19 May 2012 11:52:53 +0200 (CEST) Original-Received: from linux.local (ppp-88-217-120-22.dynamic.mnet-online.de [88.217.120.22]) by mail.mnet-online.de (Postfix) with ESMTPA id 3VvhPx0RjBz4KKDq; Sat, 19 May 2012 11:52:53 +0200 (CEST) Original-Received: by linux.local (Postfix, from userid 501) id 69FC91E5614; Sat, 19 May 2012 11:52:51 +0200 (CEST) X-Yow: Everybody gets free BORSCHT! In-Reply-To: <73ED1C31-12C1-4424-9DEC-632A1F0050D4@swipnet.se> ("Jan =?UTF-8?Q?Dj=C3=A4rv?="'s message of "Sat, 19 May 2012 10:29:32 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60210 Archived-At: Jan Dj=C3=A4rv writes: > So the question is, is it more effective to give select the exact value > (select works fine if nfds has a higher value than strictly neccessary)= , > or always increment by one in lines 78 and 83? IMHO it doesn't hurt to be exact, and the patch removes an inconsistency which makes it easier to understand the code. Andreas. --=20 Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED= 5 "And now for something completely different."