From: Andreas Schwab <schwab@linux-m68k.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: 11508@debbugs.gnu.org
Subject: bug#11508: 24.1.50; Off-by-one error in xg_select?
Date: Sat, 19 May 2012 11:52:50 +0200 [thread overview]
Message-ID: <m24nrclcp9.fsf@linux-m68k.org> (raw)
In-Reply-To: <73ED1C31-12C1-4424-9DEC-632A1F0050D4@swipnet.se> ("Jan Djärv"'s message of "Sat, 19 May 2012 10:29:32 +0200")
Jan Djärv <jan.h.d@swipnet.se> writes:
> So the question is, is it more effective to give select the exact value
> (select works fine if nfds has a higher value than strictly neccessary),
> or always increment by one in lines 78 and 83?
IMHO it doesn't hurt to be exact, and the patch removes an inconsistency
which makes it easier to understand the code.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-05-19 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 13:13 bug#11508: 24.1.50; Off-by-one error in xg_select? Ken Brown
2012-05-19 8:05 ` Jan Djärv
2012-05-19 8:29 ` Jan Djärv
2012-05-19 9:52 ` Andreas Schwab [this message]
2012-05-20 22:44 ` Ken Brown
2012-05-21 5:30 ` Jan Djärv
2012-05-21 13:38 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24nrclcp9.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=11508@debbugs.gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).