unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive
@ 2020-08-23 21:26 Stephen Berman
  2020-08-24 12:27 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 17+ messages in thread
From: Stephen Berman @ 2020-08-23 21:26 UTC (permalink / raw)
  To: 43003

On one of my systems, when using ssh in shell-mode (M-x shell), the
password prompt does not appear in the minibuffer but only in the
*shell* buffer directly under the ssh invocation, and the password is
not hidden when it's entered.  I've determined that reason is that the
password prompt string passed to comint-output-filter begins with a
carriage return character (^M), and when the rest of the prompt string
begins with "Password" (which it can on this system),
comint-password-prompt-regexp does not match it and thus
comint-watch-for-password-prompt returns nil instead of calling
comint-send-invisible.

So far I haven't found out where the carriage return is coming from,
maybe it's from openssh (on the system where the carriage return occurs
in the prompt string I have openssh-8.2p1, another system where the
carriage return does not occur has openssh-7.9p1; if anyone knows the
answer, or has a suggestion for how to find out, I'd appreciate hearing
it).

As a workaround, I can customize comint-password-prompt-regexp to match
the prompt with the carriage return.  But this problem could be seen as
a datapoint in favor of changing the default value of
comint-password-prompt-regexp.  Already in bug#31075 Noam Postavsky
pondered whether eshell-password-prompt-regexp should replace
comint-password-prompt-regexp, noting that "the eshell regexp looks much
simpler".  And indeed, on the system where the carriage return occurs in
the prompt string, using ssh in the Emacs shell (M-x eshell) does use
the minibuffer for password input and it is hidden; and if I set
comint-password-prompt-regexp to eshell-password-prompt-regexp, then I
also get minibuffer hidden input in shell-mode.

So this bug report is basically a plea to change the default value of
comint-password-prompt-regexp to be the same as that of
eshell-password-prompt-regexp.  Or is there a good reason not to do
this?


In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, cairo version 1.17.3)
 of 2020-08-21 built on strobe-jhalfs
Repository revision: 3e10174fb65f4eb601b1921271bdcf10c933b879
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Linux From Scratch SVN-20200401

Configured using:
 'configure 'CFLAGS=-Og -g3' PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD PDUMPER LCMS2





^ permalink raw reply	[flat|nested] 17+ messages in thread
end of thread, other threads:[~2020-09-01 17:44 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-23 21:26 bug#43003: 28.0.50; comint-password-prompt-regexp too restrictive Stephen Berman
2020-08-24 12:27 ` Lars Ingebrigtsen
2020-08-26 10:10   ` Stephen Berman
2020-08-27 13:02     ` Lars Ingebrigtsen
2020-08-27 15:09       ` Stephen Berman
2020-08-28 14:08         ` Lars Ingebrigtsen
2020-08-28 14:53           ` Stephen Berman
2020-08-30 13:41             ` Lars Ingebrigtsen
2020-08-31  9:26               ` Stephen Berman
2020-08-31 10:11                 ` Robert Pluim
2020-08-31 12:05                   ` Stephen Berman
2020-09-01 14:28                   ` Lars Ingebrigtsen
2020-09-01 15:03                     ` Robert Pluim
2020-09-01 15:06                       ` Lars Ingebrigtsen
2020-09-01 15:40                         ` Robert Pluim
2020-09-01 16:46                           ` Lars Ingebrigtsen
2020-09-01 17:44                             ` Robert Pluim

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).