From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.bugs Subject: bug#43464: 28.0.50; vc: Error calling vc-revert for repo root Date: Mon, 05 Oct 2020 09:02:35 +0300 Message-ID: References: <0b1c72d0-f8fb-a256-1563-1c43296c8edb@yandex.ru> <11761d79-1893-fdf3-843d-bea4a026fc7f@yandex.ru> <7b4d0bcf-c622-b2db-34d6-e587fe516f8d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37935"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 43464@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 05 08:03:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPJah-0009iz-9c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Oct 2020 08:03:19 +0200 Original-Received: from localhost ([::1]:60474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPJag-0007U1-8t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Oct 2020 02:03:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPJaQ-0007Tl-Mp for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 02:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPJaQ-0007NA-Cp for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 02:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPJaQ-0002hA-8T for bug-gnu-emacs@gnu.org; Mon, 05 Oct 2020 02:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrii Kolomoiets Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Oct 2020 06:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 43464-submit@debbugs.gnu.org id=B43464.160187776710107 (code B ref 43464); Mon, 05 Oct 2020 06:03:02 +0000 Original-Received: (at 43464) by debbugs.gnu.org; 5 Oct 2020 06:02:47 +0000 Original-Received: from localhost ([127.0.0.1]:47514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPJaA-0002cp-GE for submit@debbugs.gnu.org; Mon, 05 Oct 2020 02:02:47 -0400 Original-Received: from mail-lj1-f175.google.com ([209.85.208.175]:37010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPJa8-0002as-Iw for 43464@debbugs.gnu.org; Mon, 05 Oct 2020 02:02:45 -0400 Original-Received: by mail-lj1-f175.google.com with SMTP id n25so6278695ljj.4 for <43464@debbugs.gnu.org>; Sun, 04 Oct 2020 23:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kEqsNj+tXsfmk98/tgBhdN6fiY1RpGfhSHa858lYfbg=; b=jTKXCy97nMeyc082QKlgoQ9VMQFaDGocvpjD4m1eXbIcjQHbT9ZvnuUsxMEj6V+Yjg EjUte7cVLGS3RTz5WjXfBRX5sLkipQ19LqD1g98JaKNy/1RWYrrZMfnVdRWcWM1BuCkk KdcXMuYWEw/0Q/sk6RjQzslT/IHpsCln1d2AoxBL1ud62AwHbcPACAsldKgUzCpuPfBh n8xqq0y0nCSozO3RA2qWO9fN24xmoTb+MNwVsmQj8CbFtT9dFUDnnjcYeSNVE7eB/jUu 586D9hBR8OHelinmNeswIY6WQeO4B2r30jXbO4+FHvTn5BdSySCX1sMvvTXdA2buARYe 4ABg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kEqsNj+tXsfmk98/tgBhdN6fiY1RpGfhSHa858lYfbg=; b=eH1bFu1wZJ4te24MlYup+RA5dh6ieFp5KOzA49vKL65tlf+diDMQ3IaZVVXuIzNDUn cMQYTmWlhMaLD7wrvnin213zCIZodjynbDsfvWN9A8AGzybRpLw1C5UoqovWPnAZzvTI umrfsPoUCz8Km1eTCTkKx+xHUNwJifsXoS0cNEC/R3OEWTYrlbcDS9JzhSyXex38Cd8l /JNnjMB9vlinloFapPyhAlW6eDSDSAKvRqtjg3OPrwQBW7U5bHzF7NjX18ligNEQSCAB WoPuYV6Qb47wsiaqtXcIFhCi/MQ7NI9okxZfCgCJD/61MUIpouKA/KjJNXmJB1kdT9J/ uAMQ== X-Gm-Message-State: AOAM531EKHpZ4KayM3zEq3kH2qM5ox90lAD+12+6MXwaX7K6SqAG/WXL Qj5Vhvpyy1KKo2l7emPDqK/LQUmQ5aE= X-Google-Smtp-Source: ABdhPJxXfMkCzWgxKDoLdOH8xoF8xFMOYKp79oDIpDiNODfEM1Bm9PyqUxsfOAukgB0FOr1Gneqfeg== X-Received: by 2002:a2e:9bc5:: with SMTP id w5mr3607769ljj.454.1601877758080; Sun, 04 Oct 2020 23:02:38 -0700 (PDT) Original-Received: from muffinmac ([91.206.110.145]) by smtp.gmail.com with ESMTPSA id z141sm2675806lfc.171.2020.10.04.23.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2020 23:02:37 -0700 (PDT) In-Reply-To: <7b4d0bcf-c622-b2db-34d6-e587fe516f8d@yandex.ru> (Dmitry Gutov's message of "Mon, 5 Oct 2020 01:32:10 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189786 Archived-At: Dmitry Gutov writes: > Where is that vc-backend called from, in our scenario? It's called from 'vc-call'. The 'vc-revert-file' used it twice to call the 'make-version-backups-p' and the 'revert' backend functions. > Could we make do with changing that code to use vc-responsible-backend > instead of vc-backend instead? If it's not a function called > frequently. I went a little different way and made the 'vc-backend' return correct backend for directories. In case you missed it somehow here is the link to the message: https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-09/msg02508.html