From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Thu, 18 Nov 2021 16:51:35 +0300 Message-ID: References: <86tuhvmtpl.fsf@runbox.com> <877deqec10.fsf@gnus.org> <83fste2u4i.fsf@gnu.org> <87ily94662.fsf@gnus.org> <83fstd1bth.fsf@gnu.org> <87czogslm4.fsf@gnus.org> <86ily2mjtq.fsf@runbox.com> <87r1cp89o4.fsf@gnus.org> <86fst5m48v.fsf@runbox.com> <87a6jd5891.fsf@gnus.org> <86mtmykxro.fsf@runbox.com> <87y26hz24c.fsf@gnus.org> <86bl3blcgm.fsf@runbox.com> <87wnlya9sj.fsf@gnus.org> <86wnlbmooj.fsf@runbox.com> <87fsry7qdy.fsf@gnus.org> <87bl2m7q9g.fsf@gnus.org> <86zgq5kn9y.fsf@runbox.com> <87ilws7d7e.fsf@gnus.org> <87pmqxlsob.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35969"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: Michael , 51037@debbugs.gnu.org, gazally@runbox.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 18 14:55:01 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnhsP-0008zQ-OP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 14:55:00 +0100 Original-Received: from localhost ([::1]:59976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnhsN-0006BB-Oc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 08:54:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnhpa-0001Vw-G7 for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 08:52:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnhpa-0005WF-8M for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 08:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnhpa-0006Ov-7F for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 08:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Nov 2021 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.163724350724573 (code B ref 51037); Thu, 18 Nov 2021 13:52:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 18 Nov 2021 13:51:47 +0000 Original-Received: from localhost ([127.0.0.1]:35189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnhpL-0006OH-FT for submit@debbugs.gnu.org; Thu, 18 Nov 2021 08:51:47 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnhpI-0006Nx-Ed for 51037@debbugs.gnu.org; Thu, 18 Nov 2021 08:51:45 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 445495C01BE; Thu, 18 Nov 2021 08:51:39 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 18 Nov 2021 08:51:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=t3COXIOaNAAOgXLS3sbFen3Gm0 EenWk2nfp7drLru/s=; b=hpgfU4Rm5fgsfw8dSEGl4tzzG+IoK+hr6Fp4eZyAcZ m6eA/3FsmO+fyArVz4z/P562Qy3li1UlTe/aTWoP7WuaCffUW665t9daiONrjlsA fhJ7Ohd3c9aLAsjilX00Jt6iz/jgv/55RkSVvKS5C4rLIgUpyjqlsPq+cojfC3NI kIbg5FjV0JjnW1gwgQ/LIce9uB7IZxWhOIuQcMFf+K+0c7eDaXNEDZcEMUBkHnmw yF31V4eB1L0nyuNoNxgWwNsMNwNKCjCnf1fVFaRG/S9XeYl4HJ1Cta9bXce2hMKw gAYiDdJlN5Fot5/EmRfT4fgFc+w0kIM6m3NA2vPi/pIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=t3COXI OaNAAOgXLS3sbFen3Gm0EenWk2nfp7drLru/s=; b=JoHaXU2J+ylVmNM1wRdqiu PA81rSfIXaaZMpeBNtZ9lTSuWilNh+fPGOToOo0xxeMkGTWZnTypVZLD6pmNpaNQ e33zYmM1Ym6Z00ds0HSS3+3GfWRKAuxjXLueotKjxMcTTdvNAoFjbfiA87I/Y3TA TIeGX9GOGvotmsshRfU2+ZmW3GIiO6AsTWz9Msgv9Qq0ypwBEWdH6Si/IYMKSyQO o3AHvGzryuBOzNeGUe5XOoDEO/8FBcVP6UEZdVajPtZ1IyQt3wbGutOjo8n8+5LJ cLNPMdfmNbJUrtMFYA3P0F/jIVoQAsLbv9w66+0EFrXVPVDLxxkLEGnnrA0fxaQw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfeeigdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesthdtredttdertdenucfhrhhomhephfhilhhiphhp ucfiuhhnsghinhcuoehfghhunhgsihhnsehfrghsthhmrghilhdrfhhmqeenucggtffrrg htthgvrhhnpedvveekffdvueevhfdutdejheekvdeufeevtedttdevuddugfeiffeiveei vefhtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hfghhunhgsihhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 18 Nov 2021 08:51:37 -0500 (EST) In-Reply-To: <87pmqxlsob.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 18 Nov 2021 10:27:48 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220318 Archived-At: On 18/11/2021 10:27 +0100, Lars Ingebrigtsen wrote: > Filipp Gunbin writes: > >> The docstring for backtrace-line-length says: "If set to nil or zero, >> backtrace mode will not abbreviate the forms it prints." So the above >> sentence, which I removed, was indeed not true? (a quick look over >> its usages confirmed that to me, but I'd like someone else to check) > > I think the intention is that a nil value of backtrace-line-length > shouldn't limit the lengths -- but I haven't tested it. Doesn't it > work? ert-batch-print-length/level are 10 by default, and print-length/level are let-bound to them during ert batch runs. With these values, the backtraces should be limited, if backtrace-line-length says so. Then we go: emacs --batch -l ert \ --eval " (setq ert-batch-backtrace-right-margin nil backtrace-line-length 50 ert-batch-backtrace-line-length t) " \ --eval '(ert-deftest my-test () (error "test error"))' \ -f ert-run-tests-batch-and-exit The output is limited. Try the same with ert-batch-backtrace-line-length nil in --eval, and the output is not limited at all. So none of (ert-batch-)print-level/length get into play. So I think I'll install my patch now.. Filipp