From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Hyatt Newsgroups: gmane.emacs.bugs Subject: bug#58885: 29.0.50; Incorrect sqlite-select docstring Date: Sun, 30 Oct 2022 00:54:17 -0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17933"; mail-complaints-to="usenet@ciao.gmane.io" To: 58885@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 05:55:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1op0Lz-0004Se-NM for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 05:55:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op0Lh-00045h-Gt; Sun, 30 Oct 2022 00:55:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op0Le-00045S-Fl for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 00:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1op0Le-00049S-60 for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 00:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1op0Ld-0004y6-V7 for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 00:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrew Hyatt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 04:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58885 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166710567319052 (code B ref -1); Sun, 30 Oct 2022 04:55:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Oct 2022 04:54:33 +0000 Original-Received: from localhost ([127.0.0.1]:37021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op0LB-0004xD-07 for submit@debbugs.gnu.org; Sun, 30 Oct 2022 00:54:33 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:41708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op0L9-0004x6-BJ for submit@debbugs.gnu.org; Sun, 30 Oct 2022 00:54:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op0L8-0003zK-IT for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 00:54:31 -0400 Original-Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1op0L6-00042I-Sa for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 00:54:30 -0400 Original-Received: by mail-qk1-x735.google.com with SMTP id l9so5884522qkk.11 for ; Sat, 29 Oct 2022 21:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=MIvxRAwxznzGuKL1Hx0jxFMvydswx+xVbnbcbpD3JN8=; b=RGKcHNKNGsMuVjvewKLjwZZB7lFaIjhlODjIwkNt3XAwYNgv1EWkgzpINc11hHOLcD wxLqOgzIQ8jHJLg2DfuMmqbbJyo4X7xZkRwRezNPnZtkFYypyqQ2RExqcqYwZ4x62cht v55Kbpa4B7NZynKATzI7uL4LSJdpEqFWC0yiik+w+aUCcGLmr870Eer7YzEYyEib4SXL cNahxePrABT0wp3T11U6Dxb8tnF2figB1Ht8mIcfAKHuQSWZwO+PXMoyJzfJHXcusywc ACOmVdFCJWS8jruKvGAcyssFSUTT9SGtvwbNpJ1wa5gAiDcbfXbbUStcnyg2RUe3nkFX 6xwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MIvxRAwxznzGuKL1Hx0jxFMvydswx+xVbnbcbpD3JN8=; b=4jQEvezt1BhGq50ZTyIyEan/qIpVi3W+ft3oyqzU6X/5m6AnRzWTGPy0i2i+ru8AGe +ViC9dHcegFxM/qtmKqcYMWBXOYp29Afd1chLr8ayLHJ/yHwN1uWM72wqyZzl5LGlnDg v3ck1j6IeTYXIL5lO+rSSfB08I9z4+6v8drYPz6pUg1wWMImb9QLiw2KxJZLfKHKgPn6 o3jKynktX1Y7Zb8tWh5xHlYWX+A+H7FGkPuzAvHlH13HuKgEfOT39mW4wf3P0uiG4QEJ BXQv/xoyJ1hgUAROGmruI4zAhvJPRIKkM6Pf/4bvDBu0yAMxjyTfKyLXcmxiuu5kMknE i7NQ== X-Gm-Message-State: ACrzQf3IKYZO29X1WyYxk+bmlWaKdpmkOsJk/dt1xfq29rvSfuHl/0a3 F8HiRGPgVbNqoRAptbarseRSmke3yfQ= X-Google-Smtp-Source: AMsMyM4twJgx6Uj/BOE0cDjmjfNoqTF8DSGjcI/r9tpQf6JcpvcHVKyu3216/VLrAt5GZRseL/sTOg== X-Received: by 2002:a05:620a:bcc:b0:6ce:c077:acf3 with SMTP id s12-20020a05620a0bcc00b006cec077acf3mr4912818qki.263.1667105666315; Sat, 29 Oct 2022 21:54:26 -0700 (PDT) Original-Received: from andrews-mbp.lan (pool-71-183-193-81.nycmny.fios.verizon.net. [71.183.193.81]) by smtp.gmail.com with ESMTPSA id j11-20020ac8440b000000b0039d085a2571sm1781051qtn.55.2022.10.29.21.54.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Oct 2022 21:54:24 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::735; envelope-from=ahyatt@gmail.com; helo=mail-qk1-x735.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246584 Archived-At: --=-=-= Content-Type: text/plain; format=flowed The docstring for sqlite-select says "By default, the return value is a list where the first element is a list of column names, and the rest of the elements are the matching data." But this isn't true, by default, the value of RETURN-TYPE in that function is nil, which does not prepend the list of column names. I don't think anything more is necessary then removing this line, because the rest of the docstring has sufficient explanation. Patch included. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-fix-incorrect-sqlite-select-docstring.patch Content-Description: docstring fix diff --git a/src/sqlite.c b/src/sqlite.c index d6cb38a29a..095ce73030 100644 --- a/src/sqlite.c +++ b/src/sqlite.c @@ -528,9 +528,6 @@ DEFUN ("sqlite-select", Fsqlite_select, Ssqlite_select, 2, 4, 0, If VALUES is non-nil, it should be a list or a vector specifying the values that will be interpolated into a parameterized statement. -By default, the return value is a list where the first element is a -list of column names, and the rest of the elements are the matching data. - RETURN-TYPE can be either nil (which means that the matching data should be returned as a list of rows), or `full' (the same, but the first element in the return list will be the column names), or `set', --=-=-=--