From: Andrew Hyatt <ahyatt@gmail.com>
To: 58885@debbugs.gnu.org
Subject: bug#58885: 29.0.50; Incorrect sqlite-select docstring
Date: Sun, 30 Oct 2022 00:54:17 -0400 [thread overview]
Message-ID: <m24jvlykqu.fsf@andrews-mbp.lan> (raw)
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
The docstring for sqlite-select says "By default, the return value
is a list where the first element is a list of column names, and
the rest of the elements are the matching data." But this isn't
true, by default, the value of RETURN-TYPE in that function is
nil, which does not prepend the list of column names. I don't
think anything more is necessary then removing this line, because
the rest of the docstring has sufficient explanation.
Patch included.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: docstring fix --]
[-- Type: text/x-patch, Size: 691 bytes --]
diff --git a/src/sqlite.c b/src/sqlite.c
index d6cb38a29a..095ce73030 100644
--- a/src/sqlite.c
+++ b/src/sqlite.c
@@ -528,9 +528,6 @@ DEFUN ("sqlite-select", Fsqlite_select, Ssqlite_select, 2, 4, 0,
If VALUES is non-nil, it should be a list or a vector specifying the
values that will be interpolated into a parameterized statement.
-By default, the return value is a list where the first element is a
-list of column names, and the rest of the elements are the matching data.
-
RETURN-TYPE can be either nil (which means that the matching data
should be returned as a list of rows), or `full' (the same, but the
first element in the return list will be the column names), or `set',
next reply other threads:[~2022-10-30 4:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 4:54 Andrew Hyatt [this message]
2022-10-30 8:32 ` bug#58885: 29.0.50; Incorrect sqlite-select docstring Eli Zaretskii
2022-10-30 14:30 ` Andrew Hyatt
2022-10-30 14:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24jvlykqu.fsf@andrews-mbp.lan \
--to=ahyatt@gmail.com \
--cc=58885@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).