From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jimmy Yuen Ho Wong Newsgroups: gmane.emacs.bugs Subject: bug#63891: 29.0.91; customize-save-variable should not save all variables if a custom file exists Date: Sun, 04 Jun 2023 13:36:30 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24322"; mail-complaints-to="usenet@ciao.gmane.io" To: 63891@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 04 14:37:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5mz7-0006FG-FL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jun 2023 14:37:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5myq-0006Eo-DE; Sun, 04 Jun 2023 08:37:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5myl-0006DT-Dy for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:37:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5myl-0002ir-5A for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5myk-0008BZ-0f for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2023 12:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63891 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168588219831431 (code B ref -1); Sun, 04 Jun 2023 12:37:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Jun 2023 12:36:38 +0000 Original-Received: from localhost ([127.0.0.1]:45302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5myM-0008At-Cw for submit@debbugs.gnu.org; Sun, 04 Jun 2023 08:36:38 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5myL-0008Al-0O for submit@debbugs.gnu.org; Sun, 04 Jun 2023 08:36:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5myK-00068k-Lu for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:36:36 -0400 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5myJ-0002XR-4H for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 08:36:36 -0400 Original-Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-30ad99fa586so3809068f8f.2 for ; Sun, 04 Jun 2023 05:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685882192; x=1688474192; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=XsmQBwXtCCL9cFp/MnemsFJkwQf+vkaQjRdKHi4/aUs=; b=M41GM02KakoBS1/s/rW+A/CwlAXTUE6OC7aNh0JKe+CtAkD7zJQ41mJIxB5pqlJLgh 20BAXzRbxch68e0qb6dTEsJsIwM9b2ZCg5DOTiWYL//u7H1vCfhqRprMGyCuVsb3XX1r kwM9v/dS6rqRRttSXe55Nr86U4OfDVEoz01VBSr6lBiBgSVFWpkxFoN9vqr4rJYmHH0L Ks5dnK92fnSyxGUK3zqL/nYoShtIA5EXvfNcWyNNgg/CJQdKhNvrmdLS6m4LjiUWmZa9 vuT6lWNqYiu0sWhK3M2q1zOpekdLvDHxl/wmGdFkXw+xSFqUglRIdhhYlUXVNOGg82ra TLEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685882192; x=1688474192; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XsmQBwXtCCL9cFp/MnemsFJkwQf+vkaQjRdKHi4/aUs=; b=giQ7brqgku41XgHgjnrDCp/0Ewsiypt3eIqjvsXUR501yKDcRM7N5s2Jb3TA7k+op7 uA2pPCW4Jzgzu5wNnu/B7Ww6tTSo9+KUHNtkKdGrIvXUYLj/QJ65GBdTZL9AA1lVAEzn 9OGRMUg47L/rrOGBF7Ike1DorjqRi5kEwmFHTgW9dCSZOtqweia3SQIDz37hvgJs0pEj 0PswrWsjFD+rG+q9dtZCTT3FvNxNoBLbVr3AOUdBSqVYAjF4pUdPLiPXiNK2HvfNsYLB w1euannzq0sC3aQN/Q3y2mQttpgsZ3eF0GFUOzio2VnVniF0Ov6nvKUzOcWKyyxM5f/z kuBg== X-Gm-Message-State: AC+VfDzrwoXJjmnTltzxydHAd3E0+/lupuwo/k8F3KYtPXYliOibbFxd ZqKk7fuQFBYAPsL1NKrqn0kWeMLncww= X-Google-Smtp-Source: ACHHUZ57Jv5g5fHoen9x5NxPRlKHPPlmeZU4T+R4eXcFfdAXkweKkEhTZ8mFHFQI9ADBh4nPh7uLXg== X-Received: by 2002:adf:cd12:0:b0:309:4da8:7713 with SMTP id w18-20020adfcd12000000b003094da87713mr4355561wrm.64.1685882191607; Sun, 04 Jun 2023 05:36:31 -0700 (PDT) Original-Received: from MobileCat.localdomain ([2a01:4b00:89a0:2400:6063:8212:189a:b65]) by smtp.gmail.com with ESMTPSA id h15-20020a5d688f000000b002f6176cc6desm6972977wru.110.2023.06.04.05.36.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Jun 2023 05:36:31 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=wyuenho@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262946 Archived-At: As a discussion from bug #63300, it appears this long standing undocumented behavior of `custom-save-variable` is coming into conflict with the introduction of `connection-local-*` variables being user customizable and the fact that Tramp in Emacs 29 sets them on load. Here's a scenario where the combination of these behaviors results in one too many surprises: 0. (setf custom-file "~/.emacs.d/custom.el") 1. M-x load-library tramp (or install a package that transitively requires tramp, without the user knowning) 2. Now `connection-local-profile-alist` and `connection-local-criteria-alist` are set by `hack-connection-local-variables-apply`. 3. M-x list-packages 4. Installs a new package 5. Now in addition to `package-selected-packages` being updated, 2 gigantic variables are also saved. Since these connection-local variables are highly machine, application and connection dependent, saving them into the custom file will make it very annoying to be shared across multiple machines. This violates the principle of least astonishment. Expectation: `custom-save-variable` should only save the value of one variable regardless of whether a custom file exists.