From: Arash Esbati <arash@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 69187@debbugs.gnu.org, Ikumi Keita <ikumi@ikumi.que.jp>, johnw@gnu.org
Subject: bug#69187: 29.2; Poor compatibility in align.el
Date: Sat, 06 Apr 2024 22:14:46 +0200 [thread overview]
Message-ID: <m24jcep7t5.fsf@macmutant.fritz.box> (raw)
In-Reply-To: <86h6ge3g8u.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Apr 2024 14:03:29 +0300")
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Ikumi Keita <ikumi@ikumi.que.jp>
>>
>> > . what is the rationale for not using align-tex-modes here, only
>> > latex-mode?
>>
>> Because the current `tex-tabbing-separator' entry in `align-rules-list'
>> excludes other modes by `run-if' form.
Which is correct, in general. The tabbing environment looks like this
and is only available in LaTeX and not in other formats (AFAICT):
\begin{tabbing}
Zero \=One \=Two \=Three\\
\>First tab stop\\
\>A\>\>B\\
\>\>Second tab stop
\end{tabbing}
And the rule is designed to match these separators.
> Then I'm okay with installing the proposed change.
Thanks, the change is attached; I can push it myself, or you can do it
in case you want to change the commit message etc. I will close the
report once the change is installed.
@Keita: Thanks for the report and answering Eli's questions.
Best, Arash
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-tex-tabbing-separator-alignment-rule.patch --]
[-- Type: text/x-patch, Size: 1043 bytes --]
From 76f30b873a0e358606ad92e2df799e5c0cea474d Mon Sep 17 00:00:00 2001
From: Arash Esbati <arash@gnu.org>
Date: Sat, 6 Apr 2024 21:58:03 +0200
Subject: [PATCH] Fix tex-tabbing-separator alignment rule
* lisp/align.el (align-rules-list): Remove the check of
`latex-mode' with `eq' which doesn't work with newer AUCTeX mode
names and modes defined by user with `define-derived-mode'.
(bug#69187)
---
lisp/align.el | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lisp/align.el b/lisp/align.el
index 81ccc4b5e2d..0e77a857585 100644
--- a/lisp/align.el
+++ b/lisp/align.el
@@ -537,10 +537,8 @@ align-rules-list
(regexp . ,(lambda (end reverse)
(align-match-tex-pattern "\\\\[=>]" end reverse)))
(group . (1 2))
- (modes . align-tex-modes)
- (repeat . t)
- (run-if . ,(lambda ()
- (eq major-mode 'latex-mode))))
+ (modes . '(latex-mode))
+ (repeat . t))
(tex-record-break
(regexp . "\\(\\s-*\\)\\\\\\\\")
--
2.44.0
next prev parent reply other threads:[~2024-04-06 20:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 12:03 bug#69187: 29.2; Poor compatibility in align.el Ikumi Keita
2024-02-18 19:02 ` Ikumi Keita
2024-04-03 12:22 ` Arash Esbati
2024-04-05 16:57 ` Ikumi Keita
2024-04-05 19:59 ` Arash Esbati
2024-04-06 6:21 ` Eli Zaretskii
2024-04-06 9:30 ` Ikumi Keita
2024-04-06 11:03 ` Eli Zaretskii
2024-04-06 20:14 ` Arash Esbati [this message]
2024-04-07 5:49 ` Eli Zaretskii
2024-04-07 8:49 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24jcep7t5.fsf@macmutant.fritz.box \
--to=arash@gnu.org \
--cc=69187@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=ikumi@ikumi.que.jp \
--cc=johnw@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).