bug#70573: 30.0.50; Setting gud-gud-lldb-command-name does not take effect

["Gerd Möllmann" <gerd.moellmann@gmail.com>]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Gerd Möllmann <gerd.moellmann@gmail.com>
>> Date: Thu, 25 Apr 2024 19:56:12 +0200
>> 
>> 
>> 1. emacs -Q
>> 2. (setq gud-gud-lldb-command-name "hansi")
>> 3. M-x lldb RET
>> 
>> The new command name "hansi" is not used when prompting the user.
>
> It looks like this part:
>
>   (interactive (list (gud-query-cmdline 'lldb)))
>
> is the culprit: the minor-mode, which is the argument to
> gud-query-cmdline, should be 'gud-lldb, not 'lldb.  Here's my
> evidence:
>
>   (when (and gud-comint-buffer
> 	     (buffer-name gud-comint-buffer)
> 	     (get-buffer-process gud-comint-buffer)
> 	     (with-current-buffer gud-comint-buffer (eq gud-minor-mode 'gud-lldb)))
>
> Btw, this line seems also to be confused wrt the name of
> gud-minor-mode:
>
>   (setq-local gud-minor-mode 'lldb)

I'm currently seriously confused by gud.el, I'm afraid. And I was
already confused when I tried to mimic gud-gdb here, which does

  (interactive (list (gud-query-cmdline 'gud-gdb)))

  (when (and gud-comint-buffer
	   (buffer-name gud-comint-buffer)
	   (get-buffer-process gud-comint-buffer)
	   (with-current-buffer gud-comint-buffer (eq gud-minor-mode 'gdbmi)))
    (gdb-restore-windows)
    (error
     "Multiple debugging requires restarting in text command mode"))

  (gud-common-init command-line nil 'gud-gdb-marker-filter)
  (setq-local gud-minor-mode 'gdb)

Would you agree that the interactive form should use gud-lldb, but that
the setq-local is right? The setq-local is gud-gdb uses gdb, not
gud-gdb. Or am I confusing myself here?

(Sorry, it's probably too late in the evening for me, or I have compiled
too many LLVM versions today, or whatever.)