From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Keith David Bershatsky Newsgroups: gmane.emacs.bugs Subject: bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil. Date: Sun, 20 Mar 2016 22:08:43 -0700 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by - "") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1458536969 16482 80.91.229.3 (21 Mar 2016 05:09:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 05:09:29 +0000 (UTC) To: 23074@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 06:09:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ahs5a-0003Fi-Fa for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 06:09:14 +0100 Original-Received: from localhost ([::1]:55649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahs5Z-0008Dk-PF for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 01:09:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahs5W-0008D7-2e for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 01:09:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahs5O-0003iv-IS for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 01:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahs5O-0003ir-Ep for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 01:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ahs5O-0006AA-BS for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 01:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Keith David Bershatsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 05:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145853694023680 (code B ref -1); Mon, 21 Mar 2016 05:09:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Mar 2016 05:09:00 +0000 Original-Received: from localhost ([127.0.0.1]:56117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahs5L-00069r-R7 for submit@debbugs.gnu.org; Mon, 21 Mar 2016 01:09:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ahs5J-00069e-KF for submit@debbugs.gnu.org; Mon, 21 Mar 2016 01:08:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahs5D-0003hl-H2 for submit@debbugs.gnu.org; Mon, 21 Mar 2016 01:08:52 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahs5D-0003hb-DY for submit@debbugs.gnu.org; Mon, 21 Mar 2016 01:08:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahs5C-0008BJ-JJ for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 01:08:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahs59-0003h9-Cb for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 01:08:50 -0400 Original-Received: from cobb.liquidweb.com ([50.28.13.150]:58853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahs59-0003h0-4t for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 01:08:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com; s=default; h=Content-Type:MIME-Version:Subject:To:From:Message-ID:Date; bh=ftvP5pjhAav8hr7glqr3qdp12VPJNKoKshUKm4Zp/MI=; b=EyTYHraXnh4qNZeoEl2YrHXKY2LfDtSITQPxmiQlY1xr0mg2PaEgX92+sqe2nkgCuwbBGxF4qr0p+FhuALHOiyLO12xrjTGjAZV5+maGEIVy8IbrMBMVbmClEfLW2Iqi; Original-Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:51864 helo=server.local.localhost) by cobb.liquidweb.com with esmtp (Exim 4.82) (envelope-from ) id 1ahs54-0001Ix-PM for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 01:08:42 -0400 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cobb.liquidweb.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-Get-Message-Sender-Via: cobb.liquidweb.com: acl_c_relayhosts_text_entry: lawlist|lawlist.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115209 Archived-At: Emacs master branch built `--with-x --with-ns=no` with full image support on an OSX machine (10.6.8) does not display the Emacs logo on the Welcome screen because the final test of `use-fancy-splash-screen-p` returns nil. If we use 17 instead of 19, the test returns `t` and the Emacs logo is displayed. I would suggest using a better test like `one-window-p`, because 19 is too big. (defun use-fancy-splash-screens-p () "Return t if fancy splash screens should be used." (when (and (display-graphic-p) (or (and (display-color-p) (image-type-available-p 'xpm)) (image-type-available-p 'pbm))) (let ((frame (fancy-splash-frame))) (when frame (let* ((img (create-image (fancy-splash-image-file))) (image-height (and img (cdr (image-size img nil frame)))) ;; We test frame-height so that, if the frame is split ;; by displaying a warning, that doesn't cause the normal ;; splash screen to be used. (frame-height (1- (frame-height frame)))) ;; The original value added to the `image-height' for the test was 19; however, ;; that causes the test to fail on X11 by about 1.5 -- so use 17 instead. (> frame-height (+ image-height 17))))))) Thanks, Keith