From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#48494: 28.0.50; [PATCH] AngeFTP fails on macOS 10.14 with GNU inetutils FTP Date: Thu, 20 May 2021 10:49:23 -0700 Message-ID: References: <83mtsss1gn.fsf@gnu.org> <83o8d7rjl8.fsf@gnu.org> <8735uh4ky4.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19151"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 48494@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 20 19:50:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljmoT-0004m3-8u for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 19:50:25 +0200 Original-Received: from localhost ([::1]:59874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljmoS-0006UQ-7f for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 13:50:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljmo6-0005sA-6u for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 13:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljmo5-0004Yc-Uv for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 13:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljmo5-0002vb-RW for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 13:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 May 2021 17:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48494 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48494-submit@debbugs.gnu.org id=B48494.162153297111199 (code B ref 48494); Thu, 20 May 2021 17:50:01 +0000 Original-Received: (at 48494) by debbugs.gnu.org; 20 May 2021 17:49:31 +0000 Original-Received: from localhost ([127.0.0.1]:35166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljmna-0002uZ-Pv for submit@debbugs.gnu.org; Thu, 20 May 2021 13:49:31 -0400 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:61536 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljmnW-0002uO-DA for 48494@debbugs.gnu.org; Thu, 20 May 2021 13:49:30 -0400 Original-Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:f9b8:daee:26db:e874]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FmHLD04JBz3pk9P; Thu, 20 May 2021 10:49:23 -0700 (PDT) In-Reply-To: <8735uh4ky4.fsf@gmx.de> (Michael Albinus's message of "Thu, 20 May 2021 15:02:43 +0200") Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206954 Archived-At: Michael Albinus writes: > Alex Bochannek writes: > >>>> > How about making the default value depend on the value of system-type? >>>> >>>> You mean something like this? >>> >>> Yes. >>> >>>> The more I think about it, the more I am leaning against changing the >>>> default. I don't fully understand what inetutils ftp is doing and why -e >>>> is needed. Maybe submitting a bug against inetutils is the right >>>> approach here? >>> >>> Could be. >> >> I am sending in a report to bug-inetutils@gnu.org and see if they can >> offer some insight. >> >>>> Are there any automated cross-platform tests to see on which platform >>>> removing -v might break AngeFTP? >>> >>> I don't know. maybe Michael (CC'ed) does. >> >> I take back my comment about Windows and -v. On the command line >> (cmd.exe), it absolutely does behave as the documentation indicated, but >> I just tried out AngeFTP under Windows 7 (Version 6.1.7601) and it only >> works with -v. Maybe Michael can explain what is going on there? > > Well, I'm not an expert in ftp, and especially, I'm not an expert in ftp > client command line arguments. While I agree that adding the "-e" option > to the ftp call in ange-ftp.el sounds reasonable, I have no idea what > would be broken with some clients. That was my primary concern. I looked at EMBA to see if there are any regression tests that would catch something like this, but didn't see anything. I am happy to help out with EMBA if need be, by the way. > A check for system-type is not sufficient, for every system there are > different ftp clients, which could behave different. If we want to add a > check for command argument availability, we would need to fire a test > call, and to analyze, whether given command arguments are supported. While I agree in principle, the way AngeFTP works pretty clearly assumes the client to present the BSD FTP command line interface. > We should take into consideration, that the default value for > ange-ftp-ftp-program-args hasn't been changed for at least 21 years. We > should also take into consideration, that ftp is being phased out in > browsers like Chrome and Firefox; its importance is decreasing. So I Which is why I am using AngeFTP. The convenient browser-based interfaces are gone and I am reverting to the same interface I use for other remote file access (TRAMP). > propose to not change anything, and let users customize > ange-ftp-ftp-program-args to their needs. I agree with that and I am fine with this bug being closed out as "won't fix" or some equivalent thereof. I submitted a bug against inetutils (don't have a bug number yet) and the underlying issue I saw on macOS should probably be addressed there. Until then I can either set ange-ftp-ftp-program-args or use tnftp. > Best regards, Michael. Thanks for the reply, much appreciated! -- Alex.