unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "James N. V. Cash" <james.nvc@gmail.com>
To: 57023@debbugs.gnu.org
Subject: bug#57023: [PATCH] Take last libgccjit.dylib or .so from homebrew
Date: Sat, 06 Aug 2022 19:22:43 -0400	[thread overview]
Message-ID: <m235e9t0sc.fsf@occasionallycogent.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

Tags: patch


This patch fixes a bug where building with native-compilation with the
latest libgccjit from homebrew fails, because an extra copy of the dylib showing up
in the output of brew ls results in a malformed CFLAG.

James Cash


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Take-last-libgccjit.dylib-or-.so-from-homebrew.patch --]
[-- Type: text/patch, Size: 1163 bytes --]

From b5ec156fb396ca4567e900c64ab6faeae1702400 Mon Sep 17 00:00:00 2001
From: "James N. V. Cash" <james.nvc@gmail.com>
Date: Sat, 6 Aug 2022 18:18:42 -0400
Subject: [PATCH] Take last libgccjit.dylib or .so from homebrew

Homebrew now shows multiple dylibs, under "<version-number>/" and
"current/". One is a symlink to the other, so it doesn't matter which
we choose, but otherwise the linker flag gets malformed (ends up as
"-L/whatever/12/libgccjit.dylib\n/whatever/current/")
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 1a264275bd..f55ffaa339 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4241,7 +4241,8 @@ AC_DEFUN
           MAC_CFLAGS="-I$(dirname $($BREW ls -v libgccjit | \
                                                 grep libgccjit.h))"
           MAC_LIBS="-L$(dirname $($BREW ls -v libgccjit| \
-                                            grep -E 'libgccjit\.(so|dylib)$'))"
+                                            grep -E 'libgccjit\.(so|dylib)$'| \
+                                            tail -n 1))"
         fi
       fi
 
-- 
2.32.1 (Apple Git-133)


             reply	other threads:[~2022-08-06 23:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06 23:22 James N. V. Cash [this message]
2022-08-07 12:58 ` bug#57023: [PATCH] Take last libgccjit.dylib or .so from homebrew Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m235e9t0sc.fsf@occasionallycogent.com \
    --to=james.nvc@gmail.com \
    --cc=57023@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).