unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dave Abrahams <dave@boostpro.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 12351@debbugs.gnu.org
Subject: bug#12351: 24.1; parse-colon-path turns empty paths into nil
Date: Sun, 30 Dec 2012 14:53:44 -0500	[thread overview]
Message-ID: <m21ue7b9kn.fsf@cube.luannocracy.com> (raw)
In-Reply-To: <cdwqvzqso4.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 30 Dec 2012 13:52:11 -0500")


on Sun Dec 30 2012, Glenn Morris <rgm-AT-gnu.org> wrote:

> Dave Abrahams wrote:
>
>> (parse-colon-path ":") yields (nil nil) but there's nothing in the
>> docstring to indicate that empty path entries will get turned into nil.
>> Either the docstring needs to be updated, or parse-colon-path should
>> return (delq nil cd-list).
>
> Making a change equivalent to the latter has caused
>
> http://debbugs.gnu.org/13296
>
> Obviously we need the nils to remain, so I will put them back and just
> mention that empty elements return nil. It's not worth handling the
> minor aesthetic annoyance of (nil nil) specially.

FWIW, I disagree. IMO you should at least consider fixing eshell and any
other things that break because of this change.  This discontinuity in
behavior is not merely aesthetic; it makes parse-colon-path difficult to
use correctly and leads to hard-to-find bugs in any code that fails to
account for the possible nils.

-- 
Dave Abrahams
BoostPro Computing                  Software Development        Training
http://www.boostpro.com             Clang/LLVM/EDG Compilers  C++  Boost





  reply	other threads:[~2012-12-30 19:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04 18:58 bug#12351: 24.1; parse-colon-path turns empty paths into nil Dave Abrahams
2012-09-16 15:57 ` Chong Yidong
2012-12-30 18:52 ` Glenn Morris
2012-12-30 19:53   ` Dave Abrahams [this message]
2012-12-30 20:22     ` Eli Zaretskii
2012-12-30 20:37       ` Dave Abrahams
2012-12-30 22:08         ` Andreas Schwab
2012-12-31  3:08           ` Dave Abrahams
2012-12-31  7:14             ` Glenn Morris
2012-12-31 12:59               ` Dave Abrahams
2012-12-31 10:07             ` Andreas Schwab
2012-12-31  1:40         ` Wolfgang Jenkner
2012-12-31  3:11           ` Dave Abrahams
2012-12-31  6:56             ` Glenn Morris
2012-12-31  7:07               ` Glenn Morris
2012-12-31 12:58                 ` Dave Abrahams
2012-12-31 16:10             ` Wolfgang Jenkner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m21ue7b9kn.fsf@cube.luannocracy.com \
    --to=dave@boostpro.com \
    --cc=12351@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).