* bug#12500: 24.2.50; (search-failed "\n debug(") in debugger
@ 2012-09-24 6:34 Helmut Eller
2012-12-07 4:21 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Helmut Eller @ 2012-09-24 6:34 UTC (permalink / raw)
To: 12500
When stepping, the (search-forward "\n debug(") in
debugger-setup-buffer sometimes fails. To reproduce this
1. eval this
(progn
(defun foo ()
(debug nil 1)
(debug nil 2))
(setq toggle-debug-on-error t)
(foo))
2. The debugger pops up with the message:
Debugger entered: (1)
foo()
3. At the line with foo(), press d (i.e. debugger-step-through).
4. Now the buffer starts with:
Debugger entered--beginning evaluation of function call form:
* (debug nil 2)
5. Now press c (i.e. debugger-continue) on the line with the *.
6. The debugger enters recursively with the error:
Debugger entered--Lisp error: (search-failed "\n debug(")
In GNU Emacs 24.2.50.1 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
of 2012-09-22 on ix
Bzr revision: 110128 cyd@gnu.org-20120922032937-yf6yua64ed45tzap
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
Configured using:
`configure '--with-jpeg=no' '--with-gif=no' '--with-tiff=no''
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#12500: 24.2.50; (search-failed "\n debug(") in debugger
2012-09-24 6:34 bug#12500: 24.2.50; (search-failed "\n debug(") in debugger Helmut Eller
@ 2012-12-07 4:21 ` Stefan Monnier
2016-01-29 18:20 ` Marcin Borkowski
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2012-12-07 4:21 UTC (permalink / raw)
To: Helmut Eller; +Cc: 12500
> When stepping, the (search-forward "\n debug(") in
> debugger-setup-buffer sometimes fails. To reproduce this
The patch below seems to fix the problem in your test case; can you
confirm that it fixes your problem?
Stefan
=== modified file 'lisp/emacs-lisp/debug.el'
--- lisp/emacs-lisp/debug.el 2012-11-13 03:06:56 +0000
+++ lisp/emacs-lisp/debug.el 2012-12-07 04:19:04 +0000
@@ -333,7 +333,7 @@
(goto-char (point-min))
(delete-region (point)
(progn
- (search-forward "\n debug(")
+ (re-search-forward "\n. debug(")
(forward-line (if (eq (car args) 'debug)
;; Remove debug--implement-debug-on-entry
;; and the advice's `apply' frame.
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#12500: 24.2.50; (search-failed "\n debug(") in debugger
2012-12-07 4:21 ` Stefan Monnier
@ 2016-01-29 18:20 ` Marcin Borkowski
2016-01-29 18:37 ` Helmut Eller
2016-01-29 19:10 ` Eli Zaretskii
0 siblings, 2 replies; 6+ messages in thread
From: Marcin Borkowski @ 2016-01-29 18:20 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 12500, Helmut Eller
On 2012-12-06, at 23:21, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> When stepping, the (search-forward "\n debug(") in
>> debugger-setup-buffer sometimes fails. To reproduce this
>
> The patch below seems to fix the problem in your test case; can you
> confirm that it fixes your problem?
Just wondering: should this bug be closed? It's apparently been fixed
more than 3 years ago, and there are no further reports. What is the
right course of action?
Best,
--
Marcin Borkowski
http://mbork.pl/en
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#12500: 24.2.50; (search-failed "\n debug(") in debugger
2016-01-29 18:20 ` Marcin Borkowski
@ 2016-01-29 18:37 ` Helmut Eller
2016-01-29 19:12 ` Marcin Borkowski
2016-01-29 19:10 ` Eli Zaretskii
1 sibling, 1 reply; 6+ messages in thread
From: Helmut Eller @ 2016-01-29 18:37 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: 12500, Stefan Monnier
On Fri, Jan 29 2016, Marcin Borkowski wrote:
>> The patch below seems to fix the problem in your test case; can you
>> confirm that it fixes your problem?
>
> Just wondering: should this bug be closed?
Closing it is ok with me.
Helmut
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#12500: 24.2.50; (search-failed "\n debug(") in debugger
2016-01-29 18:37 ` Helmut Eller
@ 2016-01-29 19:12 ` Marcin Borkowski
0 siblings, 0 replies; 6+ messages in thread
From: Marcin Borkowski @ 2016-01-29 19:12 UTC (permalink / raw)
To: Helmut Eller; +Cc: 12500-done, Stefan Monnier
On 2016-01-29, at 19:37, Helmut Eller <eller.helmut@gmail.com> wrote:
> On Fri, Jan 29 2016, Marcin Borkowski wrote:
>
>>> The patch below seems to fix the problem in your test case; can you
>>> confirm that it fixes your problem?
>>
>> Just wondering: should this bug be closed?
>
> Closing it is ok with me.
As you wish. ;-)
> Helmut
Thanks, and best regards,
--
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#12500: 24.2.50; (search-failed "\n debug(") in debugger
2016-01-29 18:20 ` Marcin Borkowski
2016-01-29 18:37 ` Helmut Eller
@ 2016-01-29 19:10 ` Eli Zaretskii
1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2016-01-29 19:10 UTC (permalink / raw)
To: Marcin Borkowski; +Cc: 12500, eller.helmut, monnier
> From: Marcin Borkowski <mbork@mbork.pl>
> Date: Fri, 29 Jan 2016 19:20:29 +0100
> Cc: 12500@debbugs.gnu.org, Helmut Eller <eller.helmut@gmail.com>
>
> On 2012-12-06, at 23:21, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> >> When stepping, the (search-forward "\n debug(") in
> >> debugger-setup-buffer sometimes fails. To reproduce this
> >
> > The patch below seems to fix the problem in your test case; can you
> > confirm that it fixes your problem?
>
> Just wondering: should this bug be closed?
Yes, please.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-29 19:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-24 6:34 bug#12500: 24.2.50; (search-failed "\n debug(") in debugger Helmut Eller
2012-12-07 4:21 ` Stefan Monnier
2016-01-29 18:20 ` Marcin Borkowski
2016-01-29 18:37 ` Helmut Eller
2016-01-29 19:12 ` Marcin Borkowski
2016-01-29 19:10 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).