From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Keith David Bershatsky Newsgroups: gmane.emacs.bugs Subject: bug#29594: Emacs 26 -- xdisp.c:21657 OR xdisp.c:21671? Date: Wed, 06 Dec 2017 13:49:24 -0800 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1512597018 24766 195.159.176.226 (6 Dec 2017 21:50:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 6 Dec 2017 21:50:18 +0000 (UTC) To: 29594@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 06 22:50:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMhZz-0006GB-B1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Dec 2017 22:50:12 +0100 Original-Received: from localhost ([::1]:57929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMha3-0008NW-IW for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Dec 2017 16:50:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMhZt-0008NP-Qg for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 16:50:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMhZq-0003Uj-PW for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 16:50:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40923) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eMhZq-0003Uf-Km for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 16:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eMhZq-00084z-D9 for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 16:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Keith David Bershatsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Dec 2017 21:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29594 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Emacs Bug Reports Original-Received: via spool by submit@debbugs.gnu.org id=B.151259698231026 (code B ref -1); Wed, 06 Dec 2017 21:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Dec 2017 21:49:42 +0000 Original-Received: from localhost ([127.0.0.1]:49604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMhZW-00084M-Ag for submit@debbugs.gnu.org; Wed, 06 Dec 2017 16:49:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMhZT-000848-U5 for submit@debbugs.gnu.org; Wed, 06 Dec 2017 16:49:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMhZN-000393-R6 for submit@debbugs.gnu.org; Wed, 06 Dec 2017 16:49:34 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:56511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMhZN-00038v-NM for submit@debbugs.gnu.org; Wed, 06 Dec 2017 16:49:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMhZM-0008LN-EZ for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 16:49:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMhZJ-00035S-9w for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 16:49:32 -0500 Original-Received: from gateway30.websitewelcome.com ([192.185.145.3]:44454) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMhZJ-00034n-1w for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 16:49:29 -0500 Original-Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway30.websitewelcome.com (Postfix) with ESMTP id BF8D1D89A for ; Wed, 6 Dec 2017 15:49:25 -0600 (CST) Original-Received: from gator3053.hostgator.com ([50.87.144.69]) by cmsmtp with SMTP id MhZFefprN0aRHMhZFeAm2Z; Wed, 06 Dec 2017 15:49:25 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com ; s=default; h=Content-Type:MIME-Version:Subject:To:From:Message-ID:Date: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ce4jHejP+FolcYZBsFL1gJnsMgLz8zIIQ6P1eawbKIU=; b=aiwApsWAQGshI/u03C+GD5l1s2 flPH47aJMb8XxByr7bopyN1dctpmiazDG+4WLffSl6PTqCoBebydgORvHFuXFiBFE170nXl/RKvyh a+n4tu6iNWZoWNs1YEEdGIgwFFPay/w57gd5bX5ZChBBobfH7NCP2ToiiNmwTwUcWj84cKxSeBOOx aBthKCmMsljaKzs4enSFWYNfYWKpMzDie+xiNKW12hCvevl5rS5G/B4s2IQzxWxTWI0o2Y3iTrwzO /VyJybWXdGjJiIqvKEd2C/qOSYYPm0tJXoxedoW0RTERRKvPihpaAc+tcWchpxhnn3Scdn63Qtmcm 9ZG3fvFQ==; Original-Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:51166 helo=server.private) by gator3053.hostgator.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.89) (envelope-from ) id 1eMhZE-001NIi-Ni for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2017 15:49:24 -0600 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3053.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-BWhitelist: no X-Source-IP: 45.48.239.195 X-Source-L: No X-Exim-ID: 1eMhZE-001NIi-Ni X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: cpe-45-48-239-195.socal.res.rr.com (server.private) [45.48.239.195]:51166 X-Source-Auth: lawlist X-Email-Count: 2 X-Source-Cap: bGF3bGlzdDtsYXdsaXN0O2dhdG9yMzA1My5ob3N0Z2F0b3IuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140769 Archived-At: In the Emacs 26 branch downloaded this morning, I see: xdisp.c:21657 it->continuation_lines_width += wrap_x; and, I see: xdisp.c:21671 it->continuation_lines_width += x; If only one of these is needed, then it may be appropriate to remove whichever one is not needed. I understand that the second occurrence supersedes the first occurrence in this section of code, but it would be cleaner if there were only one setting. If both occurrences are needed, then perhaps a comment in the code at that particular location would be helpful. There is an ongoing thread on Emacs Devel relating to this section of code (among one other location) affecting the calculation of it->pixel_width at xdisp.c:28212; however, that discussion may or may not yet be ripe for a bug report: https://lists.gnu.org/archive/html/emacs-devel/2017-12/msg00209.html Thanks, Keith