unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: David PONCE <da_vid@orange.fr>
Cc: 40788@debbugs.gnu.org
Subject: bug#40788: 28.0.50; Error running timer ‘custom-magic-reset’
Date: Fri, 24 Apr 2020 13:56:10 +0200	[thread overview]
Message-ID: <m21rodyu5h.fsf@gmail.com> (raw)
In-Reply-To: <1699699799.16404.1587663566588.JavaMail.www@wwinf1p24> (David PONCE's message of "Thu, 23 Apr 2020 19:39:26 +0200 (CEST)")

>>>>> On Thu, 23 Apr 2020 19:39:26 +0200 (CEST), David PONCE <da_vid@orange.fr> said:

    David> Hello again,
    David> Below is a possible patch that seems to have fixed the issue for me.
    David> But I am not sure the approach is correct 

Rather than defining a new function, you can add an argument to the
existing one. Something like (untested)

diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index d3d17fda7a..93012b134f 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -2102,11 +2102,12 @@ custom-magic-value-create
 	(insert " "))
       (widget-put widget :children children))))
 
-(defun custom-magic-reset (widget)
+(defun custom-magic-reset (widget &optional buffer)
   "Redraw the :custom-magic property of WIDGET."
-  (let ((magic (widget-get widget :custom-magic)))
-    (when magic
-      (widget-value-set magic (widget-value magic)))))
+  (with-current-buffer (or buffer (current-buffer))
+    (let ((magic (widget-get widget :custom-magic)))
+      (when magic
+        (widget-value-set magic (widget-value magic))))))
 
 ;;; The `custom' Widget.
 
@@ -2217,7 +2218,7 @@ custom-notify
       ;; commands like `M-u' (that work on a region in the buffer)
       ;; will upcase the wrong part of the buffer, since more text has
       ;; been inserted before point.
-      (run-with-idle-timer 0.0 nil #'custom-magic-reset widget)
+      (run-with-idle-timer 0.0 nil #'custom-magic-reset widget (current-buffer))
       (apply 'widget-default-notify widget args))))
 
 (defun custom-redraw (widget)





  reply	other threads:[~2020-04-24 11:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23  5:10 bug#40788: 28.0.50; Error running timer ‘custom-magic-reset’ David Ponce
2020-04-23 17:39 ` David PONCE
2020-04-24 11:56   ` Robert Pluim [this message]
2020-04-24 15:56     ` David Ponce
2020-07-21  8:39       ` Robert Pluim
2020-07-21 14:20         ` Eli Zaretskii
2020-07-21 14:39           ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m21rodyu5h.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=40788@debbugs.gnu.org \
    --cc=da_vid@orange.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).