From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#48801: 28.0.50; [PATCH] Feature suggestion gnus-retrieve-headers check for nov-is-evil when agent is enabled Date: Thu, 03 Jun 2021 11:01:49 -0700 Message-ID: References: <87im2v9y4u.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29357"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 48801@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 03 20:15:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lorsE-0007Nl-2Y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Jun 2021 20:15:18 +0200 Original-Received: from localhost ([::1]:33082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lorsD-00036U-5B for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Jun 2021 14:15:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lorry-00035n-HF for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 14:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lorry-0006dP-A7 for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 14:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lorry-0007bB-1W for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 14:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Jun 2021 18:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48801 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48801-submit@debbugs.gnu.org id=B48801.162274406729153 (code B ref 48801); Thu, 03 Jun 2021 18:15:01 +0000 Original-Received: (at 48801) by debbugs.gnu.org; 3 Jun 2021 18:14:27 +0000 Original-Received: from localhost ([127.0.0.1]:44659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lorrP-0007a9-5W for submit@debbugs.gnu.org; Thu, 03 Jun 2021 14:14:27 -0400 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:49479 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lorrL-0007Zx-71 for 48801@debbugs.gnu.org; Thu, 03 Jun 2021 14:14:25 -0400 Original-Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:17:d08d:a8df:703e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4FwvDX1lckz3pklh; Thu, 3 Jun 2021 11:14:20 -0700 (PDT) In-Reply-To: <87im2v9y4u.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 03 Jun 2021 09:59:45 +0200") Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207965 Archived-At: Lars Ingebrigtsen writes: > Alex Bochannek writes: > >> 2) Is it possible to set `nntp-nov-is-evil' as a group parameter? It >> looks like header retrieval may be too early for this and I may need to >> use a hook? > > How about setting it in an early group entry hook depending on the group > name? And you can also set it to nil in an agent hook. I have experimented with this a bit and it looks like it works. Here's what I did: (add-hook 'gnus-summary-mode-hook 'nov-is-evil-for-nnvirtual) (defun nov-is-evil-for-nnvirtual () (if (string-match "^nnvirtual:.*" gnus-newsgroup-name) (setq gnus-nov-is-evil t))) This, combined with the patch I sent in, will cause `Newsgroups' to be recorded in the .overview files when using the agent for new messages. Is there any documentation you would like to see before accepting this change? -- Alex.