From: Filipp Gunbin <fgunbin@fastmail.fm>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 54613@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#54613: 29.0.50; uncomment-region in sh-mode deletes extra char
Date: Tue, 29 Mar 2022 22:07:29 +0300 [thread overview]
Message-ID: <m21qyk7f2m.fsf@fastmail.fm> (raw)
In-Reply-To: <m2zgl8bxf4.fsf@fastmail.fm> (Filipp Gunbin's message of "Tue, 29 Mar 2022 18:17:35 +0300")
On 29/03/2022 18:17 +0300, Filipp Gunbin wrote:
> On 29/03/2022 14:59 +0200, Lars Ingebrigtsen wrote:
>
>> Filipp Gunbin <fgunbin@fastmail.fm> writes:
>>
>>> - Notice that `-' after "cat" disappeared
>>
>> I can reproduce this issue, too.
>>
>> What happens is that we have the following:
>>
>> curl -s -d @- http://example.org <<EOF \
>> # cat -
>>
>> with point after "cat -". In that case, (comment-enter-backward) will
>> skip back past the " -", because comment-end-skip is
>>
>> "[ ]*\\(\\s>\\|
>> \\)"
>>
>> And... \s> matches the " -\\'"? Hm. I'm not sure what's the real
>> problem here is. Should comment-end-skip have that value in shell
>> scripts? On the other hand, commenting out bits of a heredoc-introduced
>> command with a continuation line is pretty hairy in itself.
>>
>
> I'm seeing in debugging that "-" after "cat" gets syntax-class "comment
> end", which seems wrong. Just in buffer, outside of running
> uncomment-region, it doesn't happen.
>
> Filipp
This is the suspect, in sh-font-lock-open-heredoc:
--8<---------------cut here---------------start------------->8---
(if (nth 4 ppss)
;; The \n not only starts the heredoc but also closes a comment.
;; Let's close the comment just before the \n.
(put-text-property (1- eol) eol 'syntax-table '(12))) ;">"
--8<---------------cut here---------------end--------------->8---
So we put ">" syntax on the "-" char, and it gets removed in
uncomment-region.
Don't know how to fix it, though.
Filipp
prev parent reply other threads:[~2022-03-29 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 17:19 bug#54613: 29.0.50; uncomment-region in sh-mode deletes extra char Filipp Gunbin
2022-03-28 18:21 ` Filipp Gunbin
2022-03-29 12:59 ` Lars Ingebrigtsen
2022-03-29 15:17 ` Filipp Gunbin
2022-03-29 19:07 ` Filipp Gunbin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21qyk7f2m.fsf@fastmail.fm \
--to=fgunbin@fastmail.fm \
--cc=54613@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).