From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#69525: 30.0.50; MacOS: New warnings on stderr Date: Fri, 26 Jul 2024 11:56:21 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2741"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Third To: 69525@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 26 11:58:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sXHiM-0000Rc-Hi for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Jul 2024 11:58:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sXHhz-0005Kl-8p; Fri, 26 Jul 2024 05:57:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXHhx-0005Kb-Mn for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2024 05:57:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sXHhx-0006E2-EY for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2024 05:57:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sXHi5-0002li-KT for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2024 05:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jul 2024 09:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69525 X-GNU-PR-Package: emacs Original-Received: via spool by 69525-submit@debbugs.gnu.org id=B69525.172198786110609 (code B ref 69525); Fri, 26 Jul 2024 09:58:01 +0000 Original-Received: (at 69525) by debbugs.gnu.org; 26 Jul 2024 09:57:41 +0000 Original-Received: from localhost ([127.0.0.1]:38810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXHhk-0002l0-RA for submit@debbugs.gnu.org; Fri, 26 Jul 2024 05:57:41 -0400 Original-Received: from mail-lf1-f50.google.com ([209.85.167.50]:51651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXHhj-0002kn-1S for 69525@debbugs.gnu.org; Fri, 26 Jul 2024 05:57:40 -0400 Original-Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52f025bc147so1446821e87.3 for <69525@debbugs.gnu.org>; Fri, 26 Jul 2024 02:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721987784; x=1722592584; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=jDD2g4RDGXacA9El5AHpE2xwKfXD3risY2EE8GekaMU=; b=hU6zJ4CXt2QYObT55HzKZaTYSjloz5MsWc0AalUg8E7TcBfvlz7r/fE3w65fODGcRN b57LFNfuXhZSxsOQ5mcXl8GWMZ2hT/FUan1cC7oVB87/Ns6h01x0hVOlcC2Qya+ry8J3 8EMY0rgfeq2dJEcQR//FCFL1I7CI3Wa8AYh9dw3cF6htA2HRwJAbQORc98lPuyS/NM0p Y6XwutvvmwjpGZSh9SScwNkr5rAapQzhqd1YpeLOLAFtnnsyqfJCmMAIWa9z4Wh1EVCj vqGqi7iwBn+wWi4QgCOBTGoomJbouyTRYQj8C6ty7NCdnnOcIocCGPYXn2FofIF4+QcV c+JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721987784; x=1722592584; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jDD2g4RDGXacA9El5AHpE2xwKfXD3risY2EE8GekaMU=; b=N39pqScqkhyj6BPxuDrnZhRLC+NnkaU0uqJ8J20I1+n3A0J/CzXP8wn6/iAQ8v2Epv XMTnosOg6NZAP+TT5YUyfTCxXZhakhWx+iuEqj6enQZiPIO4BdMbeze0SzkHj+VXIYa2 m5MElJYLcJy+mc6CXF+xPT4T/IJ1viGfjQG4CcerjePDBLQL8MOivz1D/OiIab/lSRT8 pKz4rQJw5lmySsyAtoVflSO9qLH5oEsWm0jfKDH1/B4jCGcs3XxyKFqkGUUCmhhPUYYl Xhnx5zmbLQ3m5PvkcwS7UPPMnXRPGE/M6BdZo4f/tYtp0PP8fTaLxNo/idis61JJ8BUc WrvA== X-Gm-Message-State: AOJu0YwUM9hqbU+/a8Ld/G2RFC+UABIIJMn71UMQw6yvNMFyth3+cv2P 3JNJco6s6cELOQHiI+nUQVgjEzmnSMnLOiF+N1CMvJZxwTQxh7BO23/EgQ== X-Google-Smtp-Source: AGHT+IGE/1O2M2g2LnA5CIWB/tmHG+R/K64VOqoCQE/KAfRoyV/NtFE0W6be2+yccEOrAglA9L4nmw== X-Received: by 2002:a05:6512:308d:b0:52e:be14:7012 with SMTP id 2adb3069b0e04-52fd3f24d19mr3959195e87.32.1721987783973; Fri, 26 Jul 2024 02:56:23 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a2c4.dip0.t-ipconnect.de. [79.227.162.196]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acad90130sm158938566b.144.2024.07.26.02.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 02:56:23 -0700 (PDT) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Sun, 03 Mar 2024 17:18:42 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289353 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Gerd M=C3=B6llmann writes: > The following warnings are printed to stderr, which I haven't seen > previously. Maybe canBecomeKeyWindow should be implemented? > > 2024-03-03 17:10:16.334906+0100 emacs[12805:61381] [Window] Warning: -[NS= Window makeKeyWindow] called on EmacsWindow 0x7f7d90a34030 which returned N= O from -[NSWindow canBecomeKeyWindow]. > 2024-03-03 17:10:35.434255+0100 emacs[12805:61381] [CursorUI] -[TUINSCurs= orUIController activate:]: EmacsView doesn't conform to NSTextInputClient p= rotocol. > 2024-03-03 17:10:37.073109+0100 emacs[12805:61381] [Window] Warning: -[NS= Window makeKeyWindow] called on EmacsWindow 0x7f7d90a34030 which returned N= O from -[NSWindow canBecomeKeyWindow]. > 2024-03-03 17:13:19.141805+0100 emacs[12805:61381] [CursorUI] -[TUINSCurs= orUIController activate:]: EmacsView doesn't conform to NSTextInputClient p= rotocol. > > In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin23.3.0, NS > appkit-2487.40 Version 14.3.1 (Build 23D60)) of 2024-03-01 built on > Pro.fritz.box > Repository revision: 862dfef88d8e62d12bac3ca2e44e035a2ff5b298 > Repository branch: master > Windowing system distributor 'Apple', version 10.3.2487 > System Description: macOS 14.3.1 The attached patch fixes this for me, and seems logical. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-NS-prevent-makeKeyWindow-warnings-bug-69525.patch Content-Description: makeKeyWindow >From c447ae1512cb274b5f7d47ffe479520c12392c67 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerd=20M=C3=B6llmann?= Date: Fri, 26 Jul 2024 11:48:24 +0200 Subject: [PATCH] NS: prevent makeKeyWindow warnings (bug#69525) * src/nsterm.m (ns_raise_frame): Don't makeKeyWindow if frame has no_accept_focus set. --- src/nsterm.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nsterm.m b/src/nsterm.m index b9193f62e80..cd6ffabddde 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -1413,7 +1413,7 @@ -(void)remove block_input (); if (FRAME_VISIBLE_P (f)) { - if (make_key) + if (make_key && !f->no_accept_focus) [[view window] makeKeyAndOrderFront: NSApp]; else [[view window] orderFront: NSApp]; -- 2.45.2 --=-=-=--