From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#14395: 24.3; [PATCH] new feature smie-highlight-matching-block Date: Fri, 17 May 2013 00:06:23 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1368720426 24150 80.91.229.3 (16 May 2013 16:07:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 May 2013 16:07:06 +0000 (UTC) Cc: 14395@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 18:07:05 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ud0ht-0006c8-8M for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 18:07:05 +0200 Original-Received: from localhost ([::1]:54379 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud0hs-0002Pv-Ox for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 12:07:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud0hj-0002Ht-Us for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 12:07:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ud0hf-0006zC-8Z for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 12:06:55 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud0hf-0006z7-2k for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 12:06:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ud0hp-0001yC-Rw for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 12:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2013 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14395 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14395-submit@debbugs.gnu.org id=B14395.13687204167562 (code B ref 14395); Thu, 16 May 2013 16:07:01 +0000 Original-Received: (at 14395) by debbugs.gnu.org; 16 May 2013 16:06:56 +0000 Original-Received: from localhost ([127.0.0.1]:47569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud0hh-0001xs-Gi for submit@debbugs.gnu.org; Thu, 16 May 2013 12:06:55 -0400 Original-Received: from mail-pb0-f45.google.com ([209.85.160.45]:48324) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud0hf-0001xe-1U for 14395@debbugs.gnu.org; Thu, 16 May 2013 12:06:52 -0400 Original-Received: by mail-pb0-f45.google.com with SMTP id mc8so2454159pbc.18 for <14395@debbugs.gnu.org>; Thu, 16 May 2013 09:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=X1Oei4pbv47ell/5Ye1+JVK/zGtS2/lC96S5n6Kll2A=; b=JU6npMtet7AMVhDilSkjHX5oXsdrfwc5/TGJ85XRDIFT/PSqW2kHK7pZRKA0C1QOzT 3on6DWhP7ualowuhEyNlxDEanguxrYOjyXakI7P8vzhKvuEVRHNtNRFFLXg6vyNhSDXt Yr14XD/IWruCEfspo5rrZzXLUi18AlnhjxpX5maoHH8nhvzw/x4TWVGBMGHlxDIOrL8n fEBYcxUEKjrzrrcwOzbc3+P8qvjxaOrw/7/s6/ey/5uoRGz0t58hQ13ITfZ+S9j5tBhs yHBqfaYBVHj7KbE5XQR35Tn31mlgld8jR7wm+OM5SosFfG6+xMw7L30zpt117nl4Q1hu 3Zzg== X-Received: by 10.68.89.36 with SMTP id bl4mr43658093pbb.59.1368720393904; Thu, 16 May 2013 09:06:33 -0700 (PDT) Original-Received: from Zeuss-MacBook.local ([119.161.133.157]) by mx.google.com with ESMTPSA id b7sm7281284pba.39.2013.05.16.09.06.31 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 16 May 2013 09:06:33 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Thu, 16 May 2013 09:24:08 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74330 Archived-At: On 2013-05-16 21:24 +0800, Stefan Monnier wrote: > I think the `remove-hook' should be done within the body of the > smie-highlight-matching-block-mode minor mode rather than here. > In here, you just need to wrap the add-hook within a test of > smie-highlight-matching-block-mode. But the post insert hook is buffer-local. Seems too much trouble to find all of them and remove-hook. > BTW. Is there a non-SMIE version of "highlight-matching-block-mode", > which does it for parentheses? If yes, maybe > smie-highlight-matching-block-mode should integrate into it. I am not sure there is. > One more thought, maybe you were right that futzing around with > add/remove-hook is too complicated and it's easier to check a variable. > But then maybe smie-highlight-matching-block-mode should set > blink-matching-paren to nil (which brings us back to whether there's > a global highlight-matching-block-mode working not just for modes using > SMIE). Maybe checking smie-highlight-matching-block-mode in smie-blink-matching-open is the better solution because post-self-insert-hook is buffer-local. Leo