From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Unknown Newsgroups: gmane.emacs.bugs Subject: bug#44905: 27.1; Packages that customize xref-show-xrefs-function can break Dired's dired-do-find-regexp-and-replace Date: Fri, 27 Nov 2020 21:14:39 +0100 Message-ID: References: Reply-To: =?UTF-8?Q?Reply-to=3A_Daniel_Mart=C3=83=C2=ADn_=3Cmardani29=40yahoo=2Ees?= =?UTF-8?Q?=3E=0A?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12012"; mail-complaints-to="usenet@ciao.gmane.io" To: 44905@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 27 21:15:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kik9K-000309-6N for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Nov 2020 21:15:22 +0100 Original-Received: from localhost ([::1]:38106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kik9I-0005CJ-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Nov 2020 15:15:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kik91-0005C7-OR for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2020 15:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kik91-0000GK-G4 for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2020 15:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kik91-00036X-B0 for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2020 15:15:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Nov 2020 20:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44905 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160650810211884 (code B ref -1); Fri, 27 Nov 2020 20:15:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Nov 2020 20:15:02 +0000 Original-Received: from localhost ([127.0.0.1]:46305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kik8z-00035O-HV for submit@debbugs.gnu.org; Fri, 27 Nov 2020 15:15:01 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:37512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kik8x-00035G-Jm for submit@debbugs.gnu.org; Fri, 27 Nov 2020 15:15:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kik8x-0005BT-DX for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2020 15:14:59 -0500 Original-Received: from sonic311-31.consmr.mail.ir2.yahoo.com ([77.238.176.163]:43125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kik8t-00009E-0h for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2020 15:14:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1606508085; bh=vZVCh1ivrakBJotZr2HhfhpWSrIiUgw1PCscdWfcL6c=; h=From:To:Subject:Date:References:From:Subject; b=pQrwNHb3Q05QXI7RG6XWWaF+7yRAAlFBsTY/57+c6nnT9vmIlqNwvhd+ZqcpVocf9K56csCxRDuK1+KaY6IJswJ9q93lVLUE/ADhd1gJcNzLqVO7zFmMW/5G1H/qHwvVeFUbQO8AFANlgH11gkn/SkjrJ+my0mkADKZAbtj3y/sfeb3E2CVWAHMSnyqhbegQsuEftVbSyO9DKP6+xVptyYywel4/SVgIsfnzymTYrOT4ueDww/IrxEFYgsNHFAji3eT3DuEcArrHApy4CZVAXs5oLXpa3qxenu8XMkP7i2Ia8ZPNGXHcZlaMB6fRi3/NqtrL3nWIP+W3CGVQkrUQ4A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1606508085; bh=wO5QxLh/lFWrlLgHx7KZ5l51saSsLif9EQoUqhRyGy5=; h=From:To:Subject:Date:From:Subject; b=Ic4TQb9gsLqfpsmWDafxRN+l1xhF6aHUioBs46ANJHIZKkcebkfvUv2xc6txKbcW4UdRJ9I0FAEcI8vyUSGfGoYEllA7xaxYJjVfmcglj1I7WvqANkpifZuChXP3AJR7ciF1yalTAilcF+/KvnnFCNsNc3JGKSX/Oy5nqbIMkYUH8AeJtcRmVUlfe56yyTUD872G7QLCEd16hTb2qBrPXQCu451YJlGZxIZbostcRDvjzfsUyipKfrUTunLLHgx2kLhnvuUBeOtvh/PSZ9q7L2Zf0PxF1YP+Ha0IlH0UxPeIaIKDVCMxoewmmeuJSFR0ir6eubOZ4YofnjM+IHcGpg== X-YMail-OSG: DtGgxl0VM1nxgxYwtJen6IBgJtgexpm0qLy6itxcNNgHKa92tzAl0OVjghFXD7Z ldOZrfNAzw0Rl_kyFYK7KQ7Q1hm7mD13NPnjXpukQI6N7le3dZuVIKzuPNvG3N61gdmCAszslCa3 vHbXCHc9h9mbEDfJqYVK_P3wAW5aEzhM47qKdOE7j8u0WHg_nxOJlghTC2s1laGJm6fNg1.1P3VV VCtUp88fF2wItXPf4SFu3BgX4DBoQlKloE8RE9HvHRMZOO_csaLDbRNurzQDfv_d_4r78xfr9jV8 M8jJH7GTIyl27dtLN6ywdh054S1372_HtmupaJTuE0PT.Xu1_WflbjJkj6GHK7hr9tZyLOEuwWKN bcP.IgjiGr2xJdU33R4Z8Fe1G0LRUJ0DV05kG4rz8DmQ4P7oAMA7aLLwBeeVFLnjC26afSWsOVtf Iel0Ugc2x0IHm_slMoUwJJ74awDNVExCMNkN7r88GDFiuqAs0MkpoT2fhsWhURAV3..jqVyOdNya eFu69XchSewvN4fpGH1TJesZXhsB4zNQAf1vPJXry.gMpEMqLFCXznnLXT3qc9moqMPrM6qiJbqL zqH1U_HFHHDbBrPt9xB420H_A0bodHvbvZeu6CSo.qlRd5YbVJ4_lyP9OHA3b8MRwnCae7PUqCIs ZOMl2fXP7Ummk81mGlWWY.p_OkeMIC9UL.iYZ1IgwzzO.87scr.ahOt3M_loBPPYU8FRmTnRqWyz m3J_U.Aerr00zBAC4lvspmPgeyZPb4Z_LKY5H6UfZUnAIYERwMn7LJtczh3ZmdrA7.HPKjq7r_I0 4cqiZA.W2xHcHFZ492IuxrE74oQzand7dX0WKHWfI9 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Fri, 27 Nov 2020 20:14:45 +0000 Original-Received: by smtp422.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 21e8074cfbca8f817904049b23506598; Fri, 27 Nov 2020 20:14:41 +0000 (UTC) X-Mailer: WebService/1.1.17111 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=77.238.176.163; envelope-from=mardani29@yahoo.es; helo=sonic311-31.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Original-From: Xref: news.gmane.io gmane.emacs.bugs:194455 Archived-At: Scenario: A package customizes xref-show-refs-function to use a different UI to show xref results. If that function does not return a valid xref buffer, then Dired's dired-do-find-regexp-and-replace (bound to Q by default) won't work anymore because it calls xref-query-replace-in-results on the buffer returned by xref--show-xrefs. A workaround is that the package explicitly calls xref--show-xref-buffer, which is done for example at https://github.com/alexmurray/ivy-xref/commit/aa97103ea8ce6ab8891e34deff7d43aa83fe36dd, but it doesn't feel like an ideal solution because of the duplicated work. Is there a way dired-do-find-regexp-and-replace could not depend on an actual xref buffer to perform the replacement?