From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69809: 30.0.50; flymake: error in process sentinel Date: Wed, 17 Jul 2024 08:12:39 +0200 Message-ID: References: <867chv3mtf.fsf@gnu.org> <87le696o86.fsf@catern.com> <86v81bktv5.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2502"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gerd.moellmann@gmail.com, sbaugh@catern.com, Eli Zaretskii , 69809@debbugs.gnu.org To: Spencer Baugh , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 17 08:13:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTxui-0000Sj-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jul 2024 08:13:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTxuS-0001Kr-UQ; Wed, 17 Jul 2024 02:13:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTxuN-0000w3-7S for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 02:13:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTxuM-000637-Tu for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 02:12:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sTxuP-00048i-Lt for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 02:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jul 2024 06:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69809 X-GNU-PR-Package: emacs Original-Received: via spool by 69809-submit@debbugs.gnu.org id=B69809.172119676915895 (code B ref 69809); Wed, 17 Jul 2024 06:13:01 +0000 Original-Received: (at 69809) by debbugs.gnu.org; 17 Jul 2024 06:12:49 +0000 Original-Received: from localhost ([127.0.0.1]:34924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sTxuD-00048I-9f for submit@debbugs.gnu.org; Wed, 17 Jul 2024 02:12:49 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:54702 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sTxuA-000489-Cs for 69809@debbugs.gnu.org; Wed, 17 Jul 2024 02:12:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1721196762; bh=4gBtRo57xh7RsOAFTyA11FZ/tv7v1zRCJZfHDTmeoD4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qL5NqIJKLuS9DmAvFRHZ9bEofgYczY9SUbrRpt3x9UX3oST2hpFFn/4v5tQU9QO5U YvWYcwpOqkCkj/S2Ep7PGy5FudK0BLmgqq2SD/PhF8bmI07nRi8ngMlWrAU8n6OCyY McrUgFdbTdN0m9Aeopn/9lKl/ZlRZw420WYXDzzr2t67gJbb9sBU/kGLQm6BfqacmH fbBCZWPlZldRMwFCW7lm9oxF+tES4/SkZxNJJDxh7c8SkzfIUAsXnDfY9KeIpGEsMV wYO5enY7RYTAeqCWGUi+5DYqdIOzUZ49FLVT2WwQab0Xdi0znXxfK1UDNGGTqlls0H FR+3uVcScKX7g== In-Reply-To: (Spencer Baugh's message of "Tue, 16 Jul 2024 16:48:25 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288910 Archived-At: Spencer Baugh writes: > Eli Zaretskii writes: > >>> From: Eshel Yaron >>> >>> [...]maybe something like the following is better: >>>=20 >>> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el >>> index a893a8d749a..6cd48917d47 100644 >>> --- a/lisp/progmodes/eglot.el >>> +++ b/lisp/progmodes/eglot.el >>> @@ -2040,7 +2040,8 @@ eglot--managed-mode >>> (unless (eglot--stay-out-of-p 'imenu) >>> (add-function :before-until (local 'imenu-create-index-function) >>> #'eglot-imenu)) >>> - (unless (eglot--stay-out-of-p 'flymake) (flymake-mode 1)) >>> + (unless (eglot--stay-out-of-p 'flymake) >>> + (if flymake-mode (flymake-start) (flymake-mode 1))) >>> (unless (eglot--stay-out-of-p 'eldoc) >>> (add-hook 'eldoc-documentation-functions #'eglot-hover-eldoc-fun= ction >>> nil t) >> >> Spencer, any comments? >> >> From where I stand, this is okay for the emacs-30 release branch, >> unless you think it could break some legitimate workflow. > > Yes, this seems good for emacs-30. Thanks Eshel! Great, thanks. Since this is a change in eglot.el, let me also ask Jo=C3= =A3o before installing: Jo=C3=A3o, any objections to the change above? Cheers, Eshel