From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#3274: ido-completing-read doesn't work unless ido-mode is executed Date: Sun, 28 Nov 2010 13:53:26 +0000 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1290953718 32199 80.91.229.12 (28 Nov 2010 14:15:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 28 Nov 2010 14:15:18 +0000 (UTC) Cc: Daniel Colascione To: 3274@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 28 15:15:14 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PMi25-0001LT-IW for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Nov 2010 15:15:13 +0100 Original-Received: from localhost ([127.0.0.1]:36396 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMi24-0004DZ-SZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Nov 2010 09:15:12 -0500 Original-Received: from [140.186.70.92] (port=50954 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMi1n-00046c-SE for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2010 09:14:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PMi1m-0001Ea-NM for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2010 09:14:55 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PMi1m-0001EW-KK for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2010 09:14:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PMhck-0006GT-Dy; Sun, 28 Nov 2010 08:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Nov 2010 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3274 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3274-submit@debbugs.gnu.org id=B3274.129095208524011 (code B ref 3274); Sun, 28 Nov 2010 13:49:02 +0000 Original-Received: (at 3274) by debbugs.gnu.org; 28 Nov 2010 13:48:05 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMhbo-0006FE-Av for submit@debbugs.gnu.org; Sun, 28 Nov 2010 08:48:04 -0500 Original-Received: from ppsw-41.csi.cam.ac.uk ([131.111.8.141]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMhbl-0006Ef-LX for 3274@debbugs.gnu.org; Sun, 28 Nov 2010 08:48:02 -0500 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Original-Received: from cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com ([86.9.122.85]:60021 helo=Victoria.local) by ppsw-41.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1PMhh1-0006B7-Qd (Exim 4.72) (return-path ); Sun, 28 Nov 2010 13:53:27 +0000 In-Reply-To: (Leo's message of "Sun, 28 Nov 2010 13:37:41 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (Mac OS X 10.6.5) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 28 Nov 2010 08:49:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41957 Archived-At: On 2010-11-28 13:37 +0000, Leo wrote: > I also ran into this bug a while back but didn't stop to fix it. > > Could you verify the following patch fixes the bug? Please consider this patch instead. While the previous fix is minimal it does a bit too much by calling (ido-mode 1). commit eb3f3a514c7ebd2db402ca8c2f3ce7088dd8736a (HEAD, refs/heads/Ferrari) Date: Sun Nov 28 13:32:44 2010 +0000 Fix initialisation in ido-completing-read (#3274) Modified lisp/ido.el diff --git a/lisp/ido.el b/lisp/ido.el index 70d2d98..2cc10b2 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -1490,6 +1490,11 @@ Removes badly formatted data and ignored directories." ;; ido kill emacs hook (ido-save-history)) +(defun ido-common-initilization () + (ido-init-completion-maps) + (add-hook 'minibuffer-setup-hook 'ido-minibuffer-setup) + (add-hook 'choose-completion-string-functions 'ido-choose-completion-string)) + (define-minor-mode ido-everywhere "Toggle using ido speed-ups everywhere file and directory names are read. With ARG, turn ido speed-up on if arg is positive, off otherwise." @@ -1533,12 +1538,9 @@ This function also adds a hook to the minibuffer." (t nil))) (ido-everywhere (if ido-everywhere 1 -1)) - (when ido-mode - (ido-init-completion-maps)) (when ido-mode - (add-hook 'minibuffer-setup-hook 'ido-minibuffer-setup) - (add-hook 'choose-completion-string-functions 'ido-choose-completion-string) + (ido-common-initilization) (ido-load-history) (add-hook 'kill-emacs-hook 'ido-kill-emacs-hook) @@ -4853,6 +4855,8 @@ DEF, if non-nil, is the default value." (ido-directory-too-big nil) (ido-context-switch-command 'ignore) (ido-choice-list choices)) + ;; Initialize ido before invoking ido-read-internal + (ido-common-initilization) (ido-read-internal 'list prompt hist def require-match initial-input))) (defun ido-unload-function ()