From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#8744: 23.3.50; rcirc prints gibberish Date: Sun, 29 May 2011 22:26:22 +0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306679230 17933 80.91.229.12 (29 May 2011 14:27:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 29 May 2011 14:27:10 +0000 (UTC) To: 8744@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 29 16:27:06 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QQgxN-00067w-RK for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 May 2011 16:27:06 +0200 Original-Received: from localhost ([::1]:60870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQgxN-0002ry-EQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 May 2011 10:27:05 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:34988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQgxL-0002rq-Lb for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 10:27:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQgxK-0007IN-G0 for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 10:27:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQgxK-0007II-Dr for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 10:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QQgxK-0007yM-2q; Sun, 29 May 2011 10:27:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2011 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8744 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.130667920930628 (code B ref -1); Sun, 29 May 2011 14:27:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 May 2011 14:26:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQgx5-0007xw-Rl for submit@debbugs.gnu.org; Sun, 29 May 2011 10:26:48 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQgx3-0007xk-Ss for submit@debbugs.gnu.org; Sun, 29 May 2011 10:26:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQgwx-0007FU-Oc for submit@debbugs.gnu.org; Sun, 29 May 2011 10:26:40 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:43697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQgwx-0007FQ-MT for submit@debbugs.gnu.org; Sun, 29 May 2011 10:26:39 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:34867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQgww-0002ZJ-PA for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 10:26:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQgwv-0007Ey-Kw for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 10:26:38 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:47801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQgwv-0007Ec-CC for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 10:26:37 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QQgwt-0005wB-9A for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 16:26:35 +0200 Original-Received: from th041120.ip.tsinghua.edu.cn ([59.66.41.120]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 29 May 2011 16:26:35 +0200 Original-Received: from sdl.web by th041120.ip.tsinghua.edu.cn with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 29 May 2011 16:26:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 37 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: th041120.ip.tsinghua.edu.cn Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) Cancel-Lock: sha1:lpjwLQmUucfb22oiNq5+eYD1KEE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 29 May 2011 10:27:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46780 Archived-At: On 2011-05-29 22:04 +0800, Leo wrote: > The culprit is this line in rcirc-print: > > ;; only decode text from other senders, not ours > (setq text (decode-coding-string text rcirc-decode-coding-system)) > > Any idea why not also decode message to ourselves? OK, found the reason. Will install the following patch soonish. commit 0cd01fb856ec13223446cb77adf65a6b9867a455 (HEAD, refs/heads/leo-lisp-reader) Date: Sun May 29 22:17:23 2011 +0800 Fix decoding issue for text to self in rcirc.el (#8744) Decoding is required due to change on 2006-04-08 by Eli Zaretskii. --- lisp/net/rcirc.el | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) Modified lisp/net/rcirc.el diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index cbcac886..8fb5a98a 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -1428,9 +1428,8 @@ (defun rcirc-print (process sender response target text &optional activity) (old-point (point-marker)) (fill-start (marker-position rcirc-prompt-start-marker))) + (setq text (decode-coding-string text rcirc-decode-coding-system)) (unless (string= sender (rcirc-nick process)) - ;; only decode text from other senders, not ours - (setq text (decode-coding-string text rcirc-decode-coding-system)) ;; mark the line with overlay arrow (unless (or (marker-position overlay-arrow-position) (get-buffer-window (current-buffer))