unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: 8744@debbugs.gnu.org
Subject: bug#8744: 23.3.50; rcirc prints gibberish
Date: Sun, 29 May 2011 22:26:22 +0800	[thread overview]
Message-ID: <m1wrh960s1.fsf@th041120.ip.tsinghua.edu.cn> (raw)
In-Reply-To: <m17h9c3vqd.fsf@th041091.ip.tsinghua.edu.cn>

On 2011-05-29 22:04 +0800, Leo wrote:
> The culprit is this line in rcirc-print:
>
>   ;; only decode text from other senders, not ours
>   (setq text (decode-coding-string text rcirc-decode-coding-system))
>
> Any idea why not also decode message to ourselves?

OK, found the reason. Will install the following patch soonish.

commit 0cd01fb856ec13223446cb77adf65a6b9867a455 (HEAD, refs/heads/leo-lisp-reader)
Date:   Sun May 29 22:17:23 2011 +0800

    Fix decoding issue for text to self in rcirc.el (#8744)
    
    Decoding is required due to change on 2006-04-08 by Eli Zaretskii.
---
 lisp/net/rcirc.el |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

	Modified lisp/net/rcirc.el
diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index cbcac886..8fb5a98a 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -1428,9 +1428,8 @@ (defun rcirc-print (process sender response target text &optional activity)
 	      (old-point (point-marker))
 	      (fill-start (marker-position rcirc-prompt-start-marker)))
 
+	  (setq text (decode-coding-string text rcirc-decode-coding-system))
 	  (unless (string= sender (rcirc-nick process))
-	    ;; only decode text from other senders, not ours
-	    (setq text (decode-coding-string text rcirc-decode-coding-system))
 	    ;; mark the line with overlay arrow
 	    (unless (or (marker-position overlay-arrow-position)
 			(get-buffer-window (current-buffer))







  reply	other threads:[~2011-05-29 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27 17:21 bug#8744: 23.3.50; rcirc prints gibberish Leo
2011-05-28 17:53 ` Deniz Dogan
2011-05-29  1:11   ` Leo
2011-05-29 14:04 ` Leo
2011-05-29 14:26   ` Leo [this message]
2011-05-29 18:49 ` bug#8744: Also use detect-coding-string? Marco Pessotto
2011-05-30  2:39   ` Leo
2011-05-30  6:42     ` Marco Pessotto
2011-05-30 12:36       ` Leo
2011-05-30 13:33       ` Stefan Monnier
2011-05-30 14:18         ` Marco Pessotto
2011-05-31  3:16           ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1wrh960s1.fsf@th041120.ip.tsinghua.edu.cn \
    --to=sdl.web@gmail.com \
    --cc=8744@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).