From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#16346: 24.3; electric-pair-mode close-paren issue Date: Sun, 05 Jan 2014 23:30:47 +0800 Message-ID: References: <878uuuy7g1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1388935876 23413 80.91.229.3 (5 Jan 2014 15:31:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Jan 2014 15:31:16 +0000 (UTC) Cc: 16346@debbugs.gnu.org To: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 05 16:31:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vzpfc-00074Z-Qq for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jan 2014 16:31:21 +0100 Original-Received: from localhost ([::1]:58299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vzpfc-0003uR-Dw for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jan 2014 10:31:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzpfS-0003u7-8W for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 10:31:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzpfK-0006qh-Rp for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 10:31:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzpfK-0006qd-Og for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 10:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzpfJ-00080M-Ud for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 10:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2014 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16346 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16346-submit@debbugs.gnu.org id=B16346.138893585830761 (code B ref 16346); Sun, 05 Jan 2014 15:31:01 +0000 Original-Received: (at 16346) by debbugs.gnu.org; 5 Jan 2014 15:30:58 +0000 Original-Received: from localhost ([127.0.0.1]:36321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzpfF-000804-Ex for submit@debbugs.gnu.org; Sun, 05 Jan 2014 10:30:57 -0500 Original-Received: from mail-pb0-f43.google.com ([209.85.160.43]:40777) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzpfC-0007zs-It for 16346@debbugs.gnu.org; Sun, 05 Jan 2014 10:30:55 -0500 Original-Received: by mail-pb0-f43.google.com with SMTP id rq2so17459919pbb.16 for <16346@debbugs.gnu.org>; Sun, 05 Jan 2014 07:30:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=GQSaymL+kCKd145MbHu0/8CWVhAC7BKg98cUJtdxMJc=; b=BOA9aNcKq5C7ICl6JZJEIPmcurBmwvhQA8OW92ZKSq9+slgxVPWhk2dKILJ+sBwMRi 3HqSw6cmDyRhJQlkKeg9wN4YT2YhyzfU9ni0IV9hUZr2bln+6UCSZSqKspoNC3Diolcm K6cBgoV//rrl0o6oUwwooM3ODO1JLohLxSeX4kBl0+FTKaanItm1ea0iktzTzzGrC+/g 4H7OeDGQh2vR5tm8MSGmd9QuFYvrk9fs95wJei4Rs5rwc6wRqHOrNy6rYTGtWWawcazf JZaKWwC2vA9LXHYDCEL0/feXK7/y/ikedj2ZKnOQigkbE+lyUIRRc+BWB8JbIFpcy6fc cTIA== X-Received: by 10.68.241.134 with SMTP id wi6mr114870091pbc.44.1388935853427; Sun, 05 Jan 2014 07:30:53 -0800 (PST) Original-Received: from localhost ([221.220.128.204]) by mx.google.com with ESMTPSA id y9sm160602492pas.10.2014.01.05.07.30.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Jan 2014 07:30:52 -0800 (PST) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= In-Reply-To: <878uuuy7g1.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 05 Jan 2014 11:49:34 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83000 Archived-At: On 2014-01-05 19:49 +0800, Jo=E3o T=E1vora wrote: > Are you sure this is only with the new features? Yes. >> My impression is if a user didn't type ) it should not trigger >> post-self-insert-hook. WDYT? > > The idea of inserting matchers with > self-insert-command is to allow other hooks to run recursively, but it > has some problems as described by the FIXME's that I found before my > changes electric-pair-mode. But this may break the other half of stuff using post-self-insert-hook? > Indeed, it wasn't "self inserted" it, it was "electric > inserted". electric-pair--insert is this abstraction and it's used to > insert matchers. It does some rebinding of vars to keep other modes like > blink-matching-paren from interfering. Maybe eldoc-mode deserves a place > in there? > > (defun electric-pair--insert (char) > (let ((last-command-event char) > (blink-matching-paren nil) > (electric-pair-mode nil) > (eldoc-mode nil)) > (self-insert-command 1))) > > Haven't tested though... Will have little time the coming weeks, sorry. Add (eldoc-post-insert-mode nil) fixes this bug. Leo