From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert Date: Wed, 05 Jun 2024 07:24:04 +0200 Message-ID: References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> <8634pumezc.fsf@gnu.org> <86wmn4ky4k.fsf@gmail.com> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20087"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71313@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier To: "Elijah G." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 05 07:25:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEj96-00052Y-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jun 2024 07:25:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEj8k-0006N2-5x; Wed, 05 Jun 2024 01:24:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEj8i-0006MH-IJ for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 01:24:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEj8i-0004iN-29 for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 01:24:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEj8v-0000qq-RJ for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 01:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jun 2024 05:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71313-submit@debbugs.gnu.org id=B71313.17175650643176 (code B ref 71313); Wed, 05 Jun 2024 05:25:01 +0000 Original-Received: (at 71313) by debbugs.gnu.org; 5 Jun 2024 05:24:24 +0000 Original-Received: from localhost ([127.0.0.1]:56640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEj8J-0000pA-Ii for submit@debbugs.gnu.org; Wed, 05 Jun 2024 01:24:23 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:38406 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEj8H-0000ow-Rb for 71313@debbugs.gnu.org; Wed, 05 Jun 2024 01:24:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1717565047; bh=zq1fjWjNpMu2ccJW5BGgm5nj+B4laS04c2y6xmukVps=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Q5htcLUY45Yw22NvJcQEl3MXNs5OJHc/421AuUx0ivDZ0/HhFxxIwoxZwvD7QREkD R9u/8/P4gAFgNIrk0zBR42aL3eZfz9ktXRLvcGUxHYhrCASra3gu9mY17FMpIkUKd5 H7hisHTnQM+v+UdSp8P0i7aopJQsf+Y2cXIDUrYL2DWOCMvnyflWWSPjVkcVlRqErt QXBzVpJRS+KgI+wP+nLKbwbodP/99cklsQiSAHF6ZmKPXI46lwwJo6nVQQXMtUcNTJ KrjdG2TCeAxS/o5KirxMkkCaEt/Oy6ez2v6eRvl2ovtpmELj3sqDE4Lt+tPZeNfg1A rJ3geNV8jMUxA== In-Reply-To: <86wmn4ky4k.fsf@gmail.com> (Elijah G.'s message of "Tue, 04 Jun 2024 18:54:19 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286573 Archived-At: Hi Elijah, "Elijah G." writes: > Eli Zaretskii writes: > >>> From: "Elijah G." >>> Cc: 71313@debbugs.gnu.org >>> Date: Sun, 02 Jun 2024 21:14:34 -0600 >>> >>> >> From: "Elijah G." >>> >> Date: Sat, 01 Jun 2024 18:17:42 -0600 >>> >> >>> >> this little patch allow insert any package keywords when using >>> >> auto-insert for insert elisp header lines. >>> >> >>> >> This is more a bugfix, since there is a bug when using Vertico that get >>> >> stuck in the keywords part, that bug can also apply to other completion >>> >> UIs or frameworks. >>> >> >>> >> Also there are some packages that uses non-standard keywords, i think it >>> >> would be better allowing insert other keywords. >>> > >>> > I'm not sure why it makes sense to allow keywords that are not in >>> > finder-known-keywords. Such a keyword will never be used by any >>> > finder commands. >>> >>> You are right, I think I've found a better way for this bugfix. >>> Please see the new patch attached below, thanks. >> >> Thanks, but how will an empty string "fix bugs from 3rd-party >> completion UI"? What am I missing here? > > When using Completions UI such as Vertico or Helm, there is no way to > exit from Keyword Section to go to next auto-insert Sections unless the > user press a key sequense, for auto-insert input a empty string allow > close Keyword section without cancelling the next auto-insert actions. FWIW, I'm not sure I understand the problem: I just tried using Vertico to fill in a new .el file with auto-insert, and ISTM that in the Keywords step both C-M-m and C-M-c already work as expected and let you continue to the next step. Best, Eshel