unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
@ 2013-02-09 14:57 Leo Liu
  2013-02-10  2:04 ` Stefan Monnier
  0 siblings, 1 reply; 10+ messages in thread
From: Leo Liu @ 2013-02-09 14:57 UTC (permalink / raw)
  To: 13663

I am getting this when running emacs:

/usr/local/emacs/share/emacs/24.2.93/lisp/gnus/message.elc:Warning:
    `flet' is an obsolete macro (as of 24.3); use either `cl-flet' or
    `cl-letf'.

Why a user needs to care about this?

Leo





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
  2013-02-09 14:57 bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime? Leo Liu
@ 2013-02-10  2:04 ` Stefan Monnier
  2013-02-10  6:22   ` Leo Liu
  2013-02-11  4:18   ` Leo Liu
  0 siblings, 2 replies; 10+ messages in thread
From: Stefan Monnier @ 2013-02-10  2:04 UTC (permalink / raw)
  To: Leo Liu; +Cc: 13663

> I am getting this when running emacs:
> /usr/local/emacs/share/emacs/24.2.93/lisp/gnus/message.elc:Warning:
>     `flet' is an obsolete macro (as of 24.3); use either `cl-flet' or
>     `cl-letf'.

> Why a user needs to care about this?

Good question.  Basically, the question is: why is this flet
macro-expanded so late (instead of during byte-compilation)?


        Stefan





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
  2013-02-10  2:04 ` Stefan Monnier
@ 2013-02-10  6:22   ` Leo Liu
  2013-02-11  4:18   ` Leo Liu
  1 sibling, 0 replies; 10+ messages in thread
From: Leo Liu @ 2013-02-10  6:22 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 13663-done

On 2013-02-10 10:04 +0800, Stefan Monnier wrote:
[snipped 7 lines]
> Good question.  Basically, the question is: why is this flet
> macro-expanded so late (instead of during byte-compilation)?
>
>
>         Stefan

Looks like message.el needs recompilation. I have just done that and the
warning is gone.

Leo





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
  2013-02-10  2:04 ` Stefan Monnier
  2013-02-10  6:22   ` Leo Liu
@ 2013-02-11  4:18   ` Leo Liu
  2013-02-11 11:38     ` Andreas Schwab
  1 sibling, 1 reply; 10+ messages in thread
From: Leo Liu @ 2013-02-11  4:18 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 13663

On 2013-02-10 10:04 +0800, Stefan Monnier wrote:
> Good question.  Basically, the question is: why is this flet
> macro-expanded so late (instead of during byte-compilation)?

The problem can not be resolved by recompiling message.el. Looks more
serious.

Leo





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
  2013-02-11  4:18   ` Leo Liu
@ 2013-02-11 11:38     ` Andreas Schwab
  2013-02-11 12:09       ` Leo Liu
  0 siblings, 1 reply; 10+ messages in thread
From: Andreas Schwab @ 2013-02-11 11:38 UTC (permalink / raw)
  To: Leo Liu; +Cc: 13663

Leo Liu <sdl.web@gmail.com> writes:

> The problem can not be resolved by recompiling message.el. Looks more
> serious.

Perhaps the warning is actually triggered by some hook or advice?  There
is no use of flet anywhere in gnus.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
  2013-02-11 11:38     ` Andreas Schwab
@ 2013-02-11 12:09       ` Leo Liu
  2013-02-11 14:31         ` Andreas Schwab
  2013-02-11 17:10         ` Glenn Morris
  0 siblings, 2 replies; 10+ messages in thread
From: Leo Liu @ 2013-02-11 12:09 UTC (permalink / raw)
  To: 13663

On 2013-02-11 19:38 +0800, Andreas Schwab wrote:
> Perhaps the warning is actually triggered by some hook or advice?  There
> is no use of flet anywhere in gnus.
>
> Andreas.

But message.el uses it:

(defun message-read-from-minibuffer (prompt &optional initial-contents)
  "Read from the minibuffer while providing abbrev expansion."
  ......)

Leo






^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
  2013-02-11 12:09       ` Leo Liu
@ 2013-02-11 14:31         ` Andreas Schwab
  2013-02-11 17:10         ` Glenn Morris
  1 sibling, 0 replies; 10+ messages in thread
From: Andreas Schwab @ 2013-02-11 14:31 UTC (permalink / raw)
  To: Leo Liu; +Cc: 13663

Leo Liu <sdl.web@gmail.com> writes:

> But message.el uses it:
>
> (defun message-read-from-minibuffer (prompt &optional initial-contents)

Right, I was looking at trunk where it has been removed.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
  2013-02-11 12:09       ` Leo Liu
  2013-02-11 14:31         ` Andreas Schwab
@ 2013-02-11 17:10         ` Glenn Morris
  2013-02-11 17:25           ` Leo Liu
  2013-02-11 17:37           ` Leo Liu
  1 sibling, 2 replies; 10+ messages in thread
From: Glenn Morris @ 2013-02-11 17:10 UTC (permalink / raw)
  To: Leo Liu; +Cc: 13663


Where is the recipe starting from emacs -Q?





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
  2013-02-11 17:10         ` Glenn Morris
@ 2013-02-11 17:25           ` Leo Liu
  2013-02-11 17:37           ` Leo Liu
  1 sibling, 0 replies; 10+ messages in thread
From: Leo Liu @ 2013-02-11 17:25 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 13663

On 2013-02-12 01:10 +0800, Glenn Morris wrote:
> Where is the recipe starting from emacs -Q?

Unfortunately, I have no such recipe for this bug.

Leo





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime?
  2013-02-11 17:10         ` Glenn Morris
  2013-02-11 17:25           ` Leo Liu
@ 2013-02-11 17:37           ` Leo Liu
  1 sibling, 0 replies; 10+ messages in thread
From: Leo Liu @ 2013-02-11 17:37 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 13663-done

On 2013-02-12 01:10 +0800, Glenn Morris wrote:
> Where is the recipe starting from emacs -Q?

Seems as Andreas Schwab it is triggered by an advice I put on
message-bogus-recipient-p which has a flet.

Sorry for the noise. I have closed the bug.

Leo





^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2013-02-11 17:37 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-09 14:57 bug#13663: 24.2.93; Why warn `flet' is an obsolete macro at runtime? Leo Liu
2013-02-10  2:04 ` Stefan Monnier
2013-02-10  6:22   ` Leo Liu
2013-02-11  4:18   ` Leo Liu
2013-02-11 11:38     ` Andreas Schwab
2013-02-11 12:09       ` Leo Liu
2013-02-11 14:31         ` Andreas Schwab
2013-02-11 17:10         ` Glenn Morris
2013-02-11 17:25           ` Leo Liu
2013-02-11 17:37           ` Leo Liu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).