unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Morgan Willcock <morgan@ice9.digital>
Cc: 73234@debbugs.gnu.org
Subject: bug#73234: 30.0.91; completion-preview-mode doesn't trigger for case-insensitive capf
Date: Fri, 20 Sep 2024 12:34:47 +0200	[thread overview]
Message-ID: <m1v7yq62bc.fsf@re-byods-146-50-199-107.wireless.uva.nl> (raw)
In-Reply-To: <87ttead4i3.fsf@ice9.digital> (Morgan Willcock's message of "Fri,  20 Sep 2024 11:05:40 +0100")

Morgan Willcock <morgan@ice9.digital> writes:

> Eshel Yaron <me@eshelyaron.com> writes:
>
>> If :exit-function doesn't work for your use case, please explain why,
>> and if there's indeed a need for another hook, it's easy to add one :)
>
> My reasons for not using :exit-function would be:

Thanks, these make sense.

> - If the completion was inserted using a different interface then the
>   function would be running unnecessarily.

Right, although this needn't be significant in terms of performance.

> - For completion functions that I didn't write, :exit-function isn't
>   going to be set with the expectation that a particular completion
>   interface and case preference is used to insert the candidate.

The idea is that you use a capf wrapper that adds the :exit-function,
when needed, like cape-capf-case-fold in your example.

> That said, I am just trying to think of an easy mechanism to preserve
> the case of the candidate.  A hook may generally be useful, but adding a
> hook does not solve the underlying problem that I am describing here.
>
> Perhaps it is best to just pause for the moment while you get additional
> feedback from other users.

All right, let me know if you have further thoughts or a potential patch,
and thank you for your engagement!


Best,

Eshel





      reply	other threads:[~2024-09-20 10:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 19:23 bug#73234: 30.0.91; completion-preview-mode doesn't trigger for case-insensitive capf Morgan Willcock
2024-09-14  6:07 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14  9:53   ` Morgan Willcock
2024-09-14 16:23     ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14 20:46       ` Morgan Willcock
2024-09-15  6:40         ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-17 19:03           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-18 20:23             ` Morgan Willcock
2024-09-19  5:39               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-19 14:59                 ` Morgan Willcock
2024-09-20  9:27                   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-20 10:05                     ` Morgan Willcock
2024-09-20 10:34                       ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1v7yq62bc.fsf@re-byods-146-50-199-107.wireless.uva.nl \
    --to=bug-gnu-emacs@gnu.org \
    --cc=73234@debbugs.gnu.org \
    --cc=me@eshelyaron.com \
    --cc=morgan@ice9.digital \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).