From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60285: xref-query-replace-in-results could show an arrow pointing to the current item being replaced Date: Sun, 01 Jan 2023 12:23:23 +0100 Message-ID: References: Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24329"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) Cc: 60285@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 12:24:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBwRw-0006CQ-9q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 12:24:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBwRg-000555-DE; Sun, 01 Jan 2023 06:24:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBwRe-00054h-EJ for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 06:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBwRe-00084M-5b for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 06:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBwRe-0007u1-0e for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 06:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60285 X-GNU-PR-Package: emacs Original-Received: via spool by 60285-submit@debbugs.gnu.org id=B60285.167257222030339 (code B ref 60285); Sun, 01 Jan 2023 11:24:01 +0000 Original-Received: (at 60285) by debbugs.gnu.org; 1 Jan 2023 11:23:40 +0000 Original-Received: from localhost ([127.0.0.1]:40360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBwRI-0007tG-7L for submit@debbugs.gnu.org; Sun, 01 Jan 2023 06:23:40 -0500 Original-Received: from sonic306-19.consmr.mail.ir2.yahoo.com ([77.238.176.205]:37145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBwRF-0007t1-6M for 60285@debbugs.gnu.org; Sun, 01 Jan 2023 06:23:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1672572208; bh=jhsO90f2RvgLAzT9bUmfw5sTZsw3SMYaTsqxuPuChHM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Tv4589ZM2IsVwiyFGi+FASUq8lLDiz0+fX0AVVONTnM9MTu0R7GlSGIplwayXWkmtDY6VT0p0dreVb7wZcP2rFZNlH2joEaMhJGszk5rshjgEU0qSScGWvCvI23rU4GFRbq/Q68LzELqDz6XmBXxqw0o7i1pUJJoPeKFicu434b6nnGh/0FSwDs6DorOKrdoJIT2u99khGGPu0OIK5k2eapS3AbFYk4nxxNxGiTqIVYl7T6HcLknXRa4COIIFQVzJO6XykFKqp8agQ037s1lUMg+rtX2X7uuy42z2UFe8bg+C5mGdzzMipE6RrECgig5pO8gpuW5enBHTYndkgBQOg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672572208; bh=pB9xO3Gv4NxiV1PAK6IR2TfL3tpJ2L+ArXvr1vnC45g=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ihSbFzhvK21RilgipuSZwwNCGt6hgkZ/Ne8YL5cgO4uTGmOBBC15oImj96mWAotdA4cm0UBSw0YrU5RHeb89e6Wwocr2ZRQJJM5REMK6eEthsapxUzrxn/v1rlzSGnT4ppWTxwHUDNF/Byy2gyUXFX5WvX1KiTpu4fHDEitp1aTo0yaN9EOMJA+4v8EEN/XOW09OwVXP09ZwMnvk6dnk990fUxSwND3qZOSkq9U5r/KnoLLajuTb1Qk34WkiC2rqRoM6XbPYlMO0gEZhxZLHEPa5rPR4m69MS5c/r2ZCVnnhHvlIALFNCSC/pE+DMZS5B2FumG7HrRfNrloSMXBftQ== X-YMail-OSG: 0tgsssUVM1ko84ZoHy4FJG0yeaoerS7w.A1INiX.WUTNQMGFoEzUAM.LCfr5jIz TwsgdXixVPaNGc2EcRQCFRA1igcZOR6MW8yAWEdPnXe7dSk5VHCQlwkPzBveAIJP_R1dXrdMfsrr yhZCjScYIM28CN1nQ2W8kaPBq24OCS5FyZaE0pcfbNHDI0yelbLQt2avWOiWcrds3wkWt7L4q9ku UAqpOKxv6WdGwXL2LhqAy6i7L8GRHmxJaLcJlFuHxRQjUSryKRImMLJCPeIFAa5bcWoHYBx7NF2J gSSPX3rtgzKlALoeh1_slYyu0CLWFVvC1LayEqUp0RsE7ZpnHzgHfvnScPVNGLvR.lxbkk4KmbIU u5pxgF5ZMxSWLWzW2Y4y5GOYVcSOfw3sAObbR_JnqqSQ2xPa6SkgTX.eJpOrlLOEkMfQBXWG7kle 5tVTM7IPRmHOjti.GumA.NpIHk4hsIo0qtUdsF8fLqhs4zyGcP0vMLg.Xx7e6JdzM4zQWbnAu7Rb xK6nFN44_H2m7lEgEKUEGTXOTcLenA9vDhFk0c7MrYOpRocDKMDtQF4G2LrFTBbrgrqZZrQh8d76 NUIOJo5LJqF5vYLv9fNvAKFIWE5ki8CE1XX70Ccck4OmK4dC8DlT0ZVC1JK0ivKd8S7tBe9Zg2F5 gEKBsObcXEQ9NCTGmH_wfCUpO1Rh.ftHyqlQjKklDq1KajO3acS_1.HNvOkqhFYBMmX0qbiQXYIK 98cPWpx2m0QNnsPr6yZdsolkVB7D99tYXga6JgIM2VBB6Nndvzihp2bLZFje7ga7pvY9FFywGsWW uqVCdFiU.7ubwL2vHk6LmgPyCijmXSlvsnygdU.IxB X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ir2.yahoo.com with HTTP; Sun, 1 Jan 2023 11:23:28 +0000 Original-Received: by hermes--production-ir2-5795fc58c8-j5s6m (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8c1e491f5ba235233c0b4f9754bc2789; Sun, 01 Jan 2023 11:23:24 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Sat, 24 Dec 2022 19:45:01 +0200") X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252235 Archived-At: Dmitry Gutov writes: > On 23/12/2022 21:16, Daniel Mart=C3=ADn via Bug reports for GNU Emacs, the > Swiss army knife of text editors wrote: >> Severity: wishlist >> When you use xref-query-replace-in-results to replace some >> references, >> it'd be great if the xref buffer showed an overlay arrow (see >> xref--set-arrow) pointing to the reference being edited. That'd give >> better context about the reference that is being edited and the global >> progress of the query replace operation. > > SGTM. > > Here's a patch which seems to work. It's a little tricky, though, and > I'm at a loss with better variable names in some places. > > Wish we had some unit tests here. Thanks. It works well, but there are some corner cases. For example, as you can undo or go to the previous match during the query replace, the arrow should point to the previous result, if possible.