From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode Date: Wed, 29 Nov 2023 15:32:20 +0100 Message-ID: References: <83fs0o7l6a.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18054"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 67527@debbugs.gnu.org To: Eason Huang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 29 15:33:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8Lcp-0004Td-Mj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Nov 2023 15:33:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8LcW-0008Ay-0O; Wed, 29 Nov 2023 09:32:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8LcU-0008Ah-Gr for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 09:32:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8LcU-0002mD-6K for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 09:32:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r8Lcb-0002j0-Mc for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 09:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Nov 2023 14:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67527 X-GNU-PR-Package: emacs Original-Received: via spool by 67527-submit@debbugs.gnu.org id=B67527.170126835510439 (code B ref 67527); Wed, 29 Nov 2023 14:33:01 +0000 Original-Received: (at 67527) by debbugs.gnu.org; 29 Nov 2023 14:32:35 +0000 Original-Received: from localhost ([127.0.0.1]:49243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8LcA-0002iJ-M7 for submit@debbugs.gnu.org; Wed, 29 Nov 2023 09:32:35 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:58940 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8Lc7-0002iA-6m for 67527@debbugs.gnu.org; Wed, 29 Nov 2023 09:32:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1701268343; bh=Wj2dPMcyIThbme4F8Hzqmm9RIt4mxVGNWCV/IC5aB6o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kMa0ILKc69AIpLEqbHWLK5I8/JvkBMvc9juP4FYqF/NQ6B3RkW/odrB9WW6lpgxta hWhKxnbFXFeB8Ds6Oz4iWi6b12UdZZtVAJ65aDXjHi/w6yG3pEpRtCo6meACkVavls VIZj9aglvMOB65FrIhJGDEoLRt+BKWF7w/K8d4Nga23unSkmZ/tn3TGKPju7Tdd+Hk dbGZdWNp/J+sT24NAaOeh6KaemcTCHac15xP0jGru3NtSP7M9ES7Pu1znqNT5EHfIV iLOuHkW1r10AboBxa+DCqiYW7bPuXS0fizWNGIwIiem60tg30GyWLaoZGlZG2F3sa4 NYRWt0XyrcdUQ== In-Reply-To: (Eason Huang's message of "Wed, 29 Nov 2023 22:03:32 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275235 Archived-At: Eason Huang writes: > Eshel Yaron writes: > >> Eason Huang, IIUC, you've globally set up your completion selection UI >> to pop up automatically. Before this commit, there were no completion >> sources for text modes OOTB, so your global setting was equivalent in >> practice to something that only affects non-text mode buffers, and that >> was fine. Is that correct? > No. It's correct on the text file (.txt), but not in org-mode > files. Because org-mode also derived from text-mode. > ... > >> If so, my suggestion would be to change your global autocomplete setting >> such that it doesn't apply for text buffers, seeing as you don't seem to >> want such automatic behavior in these buffers, instead of disabling the >> completion source. >> >> So I'm not sure another user option is due here. I think your >> workaround is fine, if that works for you, of course. But you could >> just as well say `(setq-local corfu-auto nil)` in that hook, no? > > No. I need (setq-local corfu-auto t) on org-buffer Sure, and you can do that. Again, whatever solution works best for you. I just highlighted that the behavior that you want to avoid seems to be a consequence of a global setting that you don't in fact want to apply it in all buffers. Makes sense?