unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Aaron Gonzales <aarongonzales1@gmail.com>,
	59797@debbugs.gnu.org, Filipp Gunbin <fgunbin@fastmail.fm>,
	Warren Lynn <wrn.lynn@gmail.com>
Subject: bug#59797: 30.0.50; [wishlist] Using namespaces in Tramp's kubernetes integration
Date: Wed, 24 Jul 2024 19:30:29 +0200	[thread overview]
Message-ID: <m1ttgeu28a.fsf@dazzs-mbp.home> (raw)
In-Reply-To: <87plr2ka7v.fsf@gmx.de> (Michael Albinus's message of "Wed, 24 Jul 2024 18:48:04 +0200")

Hi Michael,

Michael Albinus <michael.albinus@gmx.de> writes:

> I gave it a first try. It turns out, that "+" is a bad choice, because
> it doesn't belong to tramp-host-regexp. I would need to rewrite host
> name handling in Tramp just for that, which is not desirable.
>
> tramp-host-regexp is "[%._[:alnum:]-]+". So we could take either "%" or
> "_" as namespace delimiter. I've decided for "%"; a complete remote file
> name for kubernetes is now "/kubernetes:[CONTAINER.]POD[%NAMESPACE]:/path/to/file".

Makes sense.  Thank you for tackling it so promptly!

> It works OK acc to my basic tests. I have appended the patch; I would
> really appreciate if you could give it more testing in your production
> environment. Please sync first with the Emacs or Tramp git repo; this
> morning I've pushed other changes there.

From a quick test, this mostly works fine.  There's one issue (typo?) in
tramp-kubernetes--namespace that causes a regression when there's no
explicit namespace and tramp-kubernetes-namespace is nil, it returns an
empty string instead of nil.

> What's left is file name completion for namespaces. I'm undecided
> whether we need this in practice; let's see how it goes as-it-is.

It's not very crucial for me, FWIW.


Cheers,

Eshel





  reply	other threads:[~2024-07-24 17:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-03  9:20 bug#59797: 30.0.50; [wishlist] Using namespaces in Tramp's kubernetes integration Michael Albinus
2022-12-05 14:05 ` Filipp Gunbin
2022-12-05 15:54   ` Michael Albinus
2022-12-06 13:56     ` Filipp Gunbin
2022-12-06 15:13       ` Michael Albinus
2023-06-23 19:47         ` Michael Albinus
2023-07-02  8:37           ` Michael Albinus
     [not found]           ` <m1cyn4cq38.fsf@eshelyaron.com>
2024-07-23 12:29             ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-23 12:59               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-23 14:13                 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-24 16:48                   ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-24 17:30                     ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-07-25  8:20                       ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25 10:48                         ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25 11:42                           ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ttgeu28a.fsf@dazzs-mbp.home \
    --to=bug-gnu-emacs@gnu.org \
    --cc=59797@debbugs.gnu.org \
    --cc=aarongonzales1@gmail.com \
    --cc=fgunbin@fastmail.fm \
    --cc=me@eshelyaron.com \
    --cc=michael.albinus@gmx.de \
    --cc=wrn.lynn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).