From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Unknown Newsgroups: gmane.emacs.bugs Subject: bug#45502: [PATCH] Prettier key bindings in NS menu entries Date: Mon, 28 Dec 2020 23:46:36 +0100 Message-ID: References: Reply-To: =?UTF-8?Q?Reply-to=3A_Daniel_Mart=C3=83=C2=ADn_=3Cmardani29=40yahoo=2Ees?= =?UTF-8?Q?=3E=0A?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11444"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: 45502@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 28 23:47:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ku1IM-0002tY-60 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Dec 2020 23:47:18 +0100 Original-Received: from localhost ([::1]:59254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ku1IK-0003Mr-LX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Dec 2020 17:47:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ku1I6-0003Md-4q for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2020 17:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ku1I5-0005MQ-Tu for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2020 17:47:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ku1I5-0000bo-RE for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2020 17:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2020 22:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45502-submit@debbugs.gnu.org id=B45502.16091956142325 (code B ref 45502); Mon, 28 Dec 2020 22:47:01 +0000 Original-Received: (at 45502) by debbugs.gnu.org; 28 Dec 2020 22:46:54 +0000 Original-Received: from localhost ([127.0.0.1]:37145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ku1Hy-0000bR-7T for submit@debbugs.gnu.org; Mon, 28 Dec 2020 17:46:54 -0500 Original-Received: from sonic313-21.consmr.mail.ir2.yahoo.com ([77.238.179.188]:38120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ku1Hs-0000b5-Ic for 45502@debbugs.gnu.org; Mon, 28 Dec 2020 17:46:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1609195599; bh=nw7BgoGuPVYThUzkoO+meF/QXHlBNwD9fT/YC0x6dcA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=iECZIcbq/tngBlAbBfnmKuRZIIeqaCngZXrpzSg7VETO9ewsfxUJYs22lHMBcjDEGQRoppb9hVxNMa14+8Z4oohlMP79DADwTuGD73N2UT/WmxwAQ46YZIb9WIUGiryzwPcM7NiPrYGhnEPT9a/zS6eO5fhMkylZTI7Ht1gXayiMd0n5Z69xTY1vreG64Ksfvn+oBLf3S9v7EVv7/WX0FSYkAWVPC2xgiDk0o3TvoH5/QJEYfyldn0L6rCjH/CGFEHad3iQCuJTZu3aHXwOrTmvQmUYh31q0g/J+2cH3XKqWG9CvZqjIUSp9Ck/lTWV2tvJz9x2MKOj591TUOQIYhQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1609195599; bh=ckjccoDzvP8mBXIXrqwRpeA6UIrhpPnlpyVxE88QZhq=; h=From:To:Subject:Date:From:Subject; b=LOrmFHcb0lW9QL5AdeR7PKwBne9dbLhMZ75sXJNsvrfHnZP5k6Ck6X7O3936DdhCTtUxzRl/UVCC8Y2zxtpO8F1OZrgkquNaXzlEGwhkKsvQ9tLeQrEibNhwqdko1k5Zd6MdGmpxRGU0e631q1uTkUGAs/EImGkfwp+w279V1ZhTlKDI5jP56iIL6Dyir/ThpZ3NYWw58L+16crvpkIcka0X+lWPlHkB4sPo48paLmCL8N4AFQX74wF/yiiu/wlKvGsCQJ1ftjpxhUUQZuZk8xTrFxjo3AMnnNUI8t/wnxViDr1RVlNB80mS2iCacOstg5AbGHGHgREO+RAwIHwfQA== X-YMail-OSG: 4pGWJgYVM1np9zTBrLbwmYi.Ya1_MqjrnySesCUkIen3kFhUPBtgJm7qLKRybF. hpI2MyPMqxN.072UaB0wprFGS6HaKtcvdt_TsXtEYGlr7pqUNqa5HMltqqCrPm.RekqqdGMOdSl6 FiW3Tp0Ea8ii7gQM.aKSnA4AyNKZfCqjfv1nS1qnB0eCJyBJyxF1BtxQ0Nq.LKdAqUP8sn5jSGgd F4qlh92aH8MVzs.PsvC5AJODJqrTjU.BPL3hSIoIo82aB.Q8AIhFTx5fbu1bO7KCkW2x92CmBXLm ktLNcCbIDeWp8GkfTjLpNBYa73YZXx76X9UWxa2BJAvNvZHukv8npMuvMB.cioEDn45UefNspihO cBzsa2DQO3xJG1xnP79l9doMCCpBl8SAvk2lXoMuh1_UB.OSqfJo8sY6W6e5Jdv0Lv4WbtBfwe0k xSr4tlpYOHds3nj.j7fBozUHXn0EjUcr8s4FEmdUGYNnufs1yG2hTHyXNITu6qQN1IShbSAO9rVY Ym8I.HTpC03Aauw.evz8IHao8gz5KOU9D7X_0UGQ2Z9Bw0dH1H4VCEP5_h5aMzdW2ttvjH8ARD1O 4sd93z6OAUllk.361xVYbGlmuJaj90N1kI1NUgQezqPt3pKFzs9ssuNLqRZaECQ.oNMs_ud7p8A9 yu5SCH8ztPuTKuBu1tnXmIExBtmtpq7fq1WQ2lpEhSxWE_1g.T4NZyzX.NVpPNployPjlEvu9lMd ZpOQ_0jfaGXnmIDZni7XbznlC2uF2H3CujBuJDVIxRyGz39LIafkfXfzmQHAfV93hZZv7TkzEX1p s9g9iVn9dkTEnJn.0keCWTW41mNwySQS85qkiTbKy0 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Mon, 28 Dec 2020 22:46:39 +0000 Original-Received: by smtp417.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 8b167f99a6a89ee96fd4aa545abe9443; Mon, 28 Dec 2020 22:46:37 +0000 (UTC) In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 28 Dec 2020 15:23:25 +0100") X-Mailer: WebService/1.1.17278 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Original-From: Xref: news.gmane.io gmane.emacs.bugs:196899 Archived-At: Mattias Engdeg=C3=A5rd writes: > The NS port shows key bindings in a rather cluttered way, with the key > in brackets directly after the menu entry. The Mac port of Emacs is > much neater with the bindings all aligned at a common tab position. We > could do the same, but having done some experiments I actually prefer > a right-alignment of the keys. Proof-of-concept patch attached. > > The alignment is made by padding with spaces, and then with hair > spaces for extra precision; the result is not perfect but probably > better than what we have now. If I get some time, I might do an > experiment with more precise formatting. Thanks for the patch! It crashed Emacs when I tried to open the Gnus menu bar (the Gnus menu bar is an extreme case with lots of bindings). I'm not sure if left-alignment or right-alignment would be better. To improve visuals, Apple seems to align with respect to the =E2=8C=98 symbol,= but that doesn't fit Emacs well because there's no single modifier that is used in almost every keybinding (some use Control, some Meta). Also, it's not uncommon in Emacs to have keybindings that are a couple of keymaps deep.