* bug#8309: 24.0.50; Remove leftover (require 'wid-edit)
@ 2011-03-21 6:35 Leo
2011-03-21 14:51 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Leo @ 2011-03-21 6:35 UTC (permalink / raw)
To: 8309; +Cc: Chong Yidong
It looks to me since revno: 103251:
,----[ 103251 ]
| message:
| Use simple buttons, instead of widget buttons, in vc-log.
|
| * lisp/vc/vc.el (vc-print-log-setup-buttons): Instead of using the
| widget library for buttons, just use button.el.
|
| * lisp/vc/log-view.el (log-view-mode-map): Don't inherit from
| widget-keymap.
`----
(require 'wid-edit) is no longer needed for log-view.el. Any objection
to this patch:
=== modified file 'lisp/vc/log-view.el'
--- lisp/vc/log-view.el 2011-02-14 01:49:24 +0000
+++ lisp/vc/log-view.el 2011-03-21 06:34:34 +0000
@@ -121,9 +121,6 @@
:group 'pcl-cvs
:prefix "log-view-")
-;; Needed because log-view-mode-map inherits from widget-keymap. (Bug#5311)
-(require 'wid-edit)
-
(easy-mmode-defmap log-view-mode-map
'(
;; FIXME: (copy-keymap special-mode-map) instead
Leo
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#8309: 24.0.50; Remove leftover (require 'wid-edit)
2011-03-21 6:35 bug#8309: 24.0.50; Remove leftover (require 'wid-edit) Leo
@ 2011-03-21 14:51 ` Stefan Monnier
2011-03-21 15:28 ` Leo
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2011-03-21 14:51 UTC (permalink / raw)
To: Leo; +Cc: Chong Yidong, 8309
> === modified file 'lisp/vc/log-view.el'
> --- lisp/vc/log-view.el 2011-02-14 01:49:24 +0000
> +++ lisp/vc/log-view.el 2011-03-21 06:34:34 +0000
> @@ -121,9 +121,6 @@
> :group 'pcl-cvs
> :prefix "log-view-")
> -;; Needed because log-view-mode-map inherits from widget-keymap. (Bug#5311)
> -(require 'wid-edit)
> -
> (easy-mmode-defmap log-view-mode-map
> '(
> ;; FIXME: (copy-keymap special-mode-map) instead
Please install, yes, thanks,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#8309: 24.0.50; Remove leftover (require 'wid-edit)
2011-03-21 14:51 ` Stefan Monnier
@ 2011-03-21 15:28 ` Leo
0 siblings, 0 replies; 3+ messages in thread
From: Leo @ 2011-03-21 15:28 UTC (permalink / raw)
To: 8309-done
Version: 24.1.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-21 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-21 6:35 bug#8309: 24.0.50; Remove leftover (require 'wid-edit) Leo
2011-03-21 14:51 ` Stefan Monnier
2011-03-21 15:28 ` Leo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).