From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#5725: 23.1.94; list_system_processes for BSD_SYSTEM (with patch) Date: Sat, 21 Apr 2012 23:29:09 +0800 Message-ID: References: <87mx65o00f.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1335022183 27538 80.91.229.3 (21 Apr 2012 15:29:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 21 Apr 2012 15:29:43 +0000 (UTC) Cc: 5725@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 21 17:29:40 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SLcFn-0005HM-Pt for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Apr 2012 17:29:40 +0200 Original-Received: from localhost ([::1]:55278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLcFn-0000an-4Y for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Apr 2012 11:29:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLcFk-0000Y1-Ax for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2012 11:29:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SLcFi-0003NG-9i for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2012 11:29:35 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLcFi-0003NC-3w for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2012 11:29:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SLcGC-00030f-IH for bug-gnu-emacs@gnu.org; Sat, 21 Apr 2012 11:30:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Apr 2012 15:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 5725-submit@debbugs.gnu.org id=B5725.133502220211528 (code B ref 5725); Sat, 21 Apr 2012 15:30:04 +0000 Original-Received: (at 5725) by debbugs.gnu.org; 21 Apr 2012 15:30:02 +0000 Original-Received: from localhost ([127.0.0.1]:45827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SLcG9-0002za-1R for submit@debbugs.gnu.org; Sat, 21 Apr 2012 11:30:01 -0400 Original-Received: from mail-pb0-f44.google.com ([209.85.160.44]:65221) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SLcG6-0002yd-MC for 5725@debbugs.gnu.org; Sat, 21 Apr 2012 11:29:59 -0400 Original-Received: by mail-pb0-f44.google.com with SMTP id rp16so1852277pbb.3 for <5725@debbugs.gnu.org>; Sat, 21 Apr 2012 08:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=PvqVSfDh8P9h2MGAp19Kdl4fZKxvVq1cGUtYLsnXElE=; b=xXVVcZO0kzyCvZgStGL2ncVkM/lHu3CaMy9tDaj/zSGwlSJqk+MQdkheYv5JVQ4PAW TqCZf5VQU03OseAkJQYZCXW1aq52+SCAJwSXiMtpdgx+OkbbAG0/tI3BlmYqszjdGDmT yNc4JWUMPo6s/Ed8C8qZfeB17w0QjTlRJzVJjjVDLvJWgEGKuPPjQGHJAHA/0sMBPWhZ xKHAPo/o89iLrtRPI7/nxd/hRLgNF67nc3CfU3ImDAaGmoZxqf9G68/a0/AQiy6DUVmH ryvLHOV3UjoedDMxQ61Fp72sUbFiUrT/c73HpgUwPkHCNh882np47nsMcifdheJMgMKr hLbw== Original-Received: by 10.68.195.232 with SMTP id ih8mr21770821pbc.118.1335022167516; Sat, 21 Apr 2012 08:29:27 -0700 (PDT) Original-Received: from localhost ([222.130.130.197]) by mx.google.com with ESMTPS id wg9sm1535787pbc.51.2012.04.21.08.29.19 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 Apr 2012 08:29:25 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= In-Reply-To: <87mx65o00f.fsf@gnu.org> (Chong Yidong's message of "Sat, 21 Apr 2012 18:24:48 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (Mac OS X 10.6.8) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59359 Archived-At: On 2012-04-21 18:24 +0800, Chong Yidong wrote: > [Disconnecting Bug#5725 from Bug#5243] > > I committed Eduard Wiebe's patch in Bug#5243 to trunk. If his > implementation of system_process_attributes does not compile on Darwin, > and you have a separate one that works, could you add yours under a > different #elif? > > Also, if the list_system_processes part works on Darwin, the relevant > #elif, from his patch, should be changed to BSD_SYSTEM; please check > that if you can, and amend as necessary. > > Thanks. The difference is small. Are you happy with this change? I have tested it in Snow Leopard 10.6.8. === modified file 'src/sysdep.c' --- src/sysdep.c 2012-04-21 10:11:51 +0000 +++ src/sysdep.c 2012-04-21 15:25:18 +0000 @@ -44,6 +44,10 @@ #include #endif +#ifdef DARWIN_OS +#include +#endif + #ifdef WINDOWSNT #define read sys_read #define write sys_write @@ -2536,7 +2540,11 @@ return proclist; } -#elif defined (__FreeBSD__) +#elif defined (BSD_SYSTEM) + +#ifdef DARWIN_OS +#define KERN_PROC_PROC KERN_PROC_ALL +#endif Lisp_Object list_system_processes () @@ -2562,7 +2570,13 @@ GCPRO1 (proclist); len /= sizeof (struct kinfo_proc); for (i = 0; i < len; i++) - proclist = Fcons (make_fixnum_or_float (procs[i].ki_pid), proclist); + { +#ifdef DARWIN_OS + proclist = Fcons (make_fixnum_or_float (procs[i].kp_proc.p_pid), proclist); +#else + proclist = Fcons (make_fixnum_or_float (procs[i].ki_pid), proclist); +#endif + } UNGCPRO; xfree (procs);