bug#25566: 26.0.50; Crash on C-g with master as of d12e1ddf42

bug#25566: 26.0.50; Crash on C-g with master as of d12e1ddf42

[Andreas Seltenreich]

Hi,

just updated my bleeding edge emacs from f5543ffcf5..d12e1ddf42, and it
triggers an abort with the following recipe:

emacs -Q

- Start keyboard input, e.g. C-x
- Wait a second +/- some fraction (waiting longer or shorter won't trigger it)
- Hit C-g

The bug disappears when I revert commits b3a3ed526d and 1392ec7420.

regards,
Andreas


In GNU Emacs 26.0.50.1 (x86_64-pc-linux-gnu)
 of 2017-01-28 built on moll
Repository revision: f428c6e664e76b94ee38a4ddc15bf183115548b0
Windowing system distributor 'The X.Org Foundation', version 11.0.11900000
System Description:	Debian GNU/Linux testing (stretch)

Configured using:
 'configure -C --with-modules --with-x-toolkit=no
 --prefix=/home/andreas/usr/ --with-x 'CFLAGS=-g -O2 -fno-crossjumping''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS NOTIFY
GNUTLS LIBXML2 FREETYPE XFT ZLIB X11 MODULES

Important settings:
  value of $LC_COLLATE: C
  value of $LC_MESSAGES: C
  value of $LC_NUMERIC: C
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Shell

Minor modes in effect:
  dirtrack-mode: t
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  rcirc-track-minor-mode: t
  global-hi-lock-mode: t
  hi-lock-mode: t
  display-time-mode: t
  winner-mode: t
  savehist-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/usr/share/emacs/site-lisp/flim/hex-util hides /home/andreas/ext/emacs/lisp/hex-util
/usr/share/emacs/site-lisp/flim/md4 hides /home/andreas/ext/emacs/lisp/md4
~/src/elisp/savehist hides /home/andreas/ext/emacs/lisp/savehist
/usr/share/emacs/site-lisp/flim/sasl-digest hides /home/andreas/ext/emacs/lisp/net/sasl-digest
/usr/share/emacs/site-lisp/flim/sasl-ntlm hides /home/andreas/ext/emacs/lisp/net/sasl-ntlm
/usr/share/emacs/site-lisp/flim/sasl-cram hides /home/andreas/ext/emacs/lisp/net/sasl-cram
/usr/share/emacs/site-lisp/flim/hmac-md5 hides /home/andreas/ext/emacs/lisp/net/hmac-md5
/usr/share/emacs/site-lisp/flim/hmac-def hides /home/andreas/ext/emacs/lisp/net/hmac-def
/usr/share/emacs/site-lisp/flim/sasl hides /home/andreas/ext/emacs/lisp/net/sasl
/usr/share/emacs/site-lisp/flim/ntlm hides /home/andreas/ext/emacs/lisp/net/ntlm

Features:
(shadow sort mail-extr gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime
smime dig mailcap gnus-sum gnus-group gnus-undo gnus-start gnus-cloud
nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int
gnus-range gnus-win gnus nnheader wid-edit vc vc-dispatcher smerge-mode
cc-mode cc-fonts cc-guess cc-menus cc-cmds pcmpl-unix dirtrack shell
emacsbug message rfc822 mml mml-sec gnus-util rmail rmail-loaddefs
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader misearch multi-isearch vc-git diff-mode autoinsert morse
disp-table network-stream puny nsm starttls tls gnutls my-rcirc
my-rcirc-notify rcirc term/screen term/xterm xterm ido morsekoch
epa-file epa derived epg warnings hi-lock my-git-annex json map
emms-playlist-mode emms-player-vlc emms-player-mplayer
emms-player-simple emms-source-playlist emms-source-file locate dired-x
dired dired-loaddefs emms-setup emms emms-compat info-look subr-x
lido-mode myorg org-clock remember org org-macro org-footnote
org-pcomplete pcomplete org-list org-faces org-entities time-date
noutline outline easy-mmode org-version ob-emacs-lisp ob ob-tangle
ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint comint
ansi-color ob-core ob-eval org-compat org-macs org-loaddefs format-spec
find-func cal-menu calendar cal-loaddefs battery cc-styles cc-align
cc-engine cc-vars cc-defs my-keys boxquote rect ffap thingatpt advice
repeatable time sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils ispell server jka-compr edmacro kmacro winner ring cl
savehist info finder-inf package epg-config url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache url-vars seq byte-opt gv bytecomp byte-compile cl-extra
help-mode easymenu cconv cl-loaddefs pcase cl-lib mule-util tooltip
eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript case-table epa-hook jka-cmpr-hook help
simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind inotify dynamic-setting system-font-setting
font-render-setting x multi-tty make-network-process emacs)

Memory information:
((conses 16 344373 288558)
 (symbols 48 39510 7)
 (miscs 40 1354 7053)
 (strings 32 92392 170209)
 (string-bytes 1 3055107)
 (vectors 16 36055)
 (vector-slots 8 730306 51086)
 (floats 8 478 1253)
 (intervals 56 6314 6028)
 (buffers 976 39))

bug#25566: 26.0.50; Crash on C-g with master as of d12e1ddf42

[Sébastien Le Callonnec]

I am experiencing the same issue on master on OSX 10.11.6.

A bisect points to this commit:

1392ec7420ee23238a1588b759c631d87a677483 is the first bad commit
commit 1392ec7420ee23238a1588b759c631d87a677483
Author: Paul Eggert <eggert@cs.ucla.edu>
Date:   Wed Jan 25 20:27:45 2017 -0800

    A quicker check for quit

    On some microbenchmarks this lets Emacs run 60% faster on my
    platform (AMD Phenom II X4 910e, Fedora 25 x86-64).
    * src/atimer.c: Include keyboard.h, for pending_signals.
    * src/editfns.c (Fcompare_buffer_substrings):
    * src/fns.c (Fnthcdr, Fmemq, Fmemql, Fassq, Frassq, Fplist_put)
    (Fnconc, Fplist_member):
    Set and clear immediate_quit before and after loop instead of
    executing QUIT each time through the loop.  This is OK for loops
    that affect only locals.
    * src/eval.c (process_quit_flag): Now static.
    (maybe_quit): New function, containing QUIT’s old body.
    * src/fns.c (rarely_quit): New function.
    (Fmember, Fassoc, Frassoc, Fdelete, Fnreverse, Freverse)
    (Flax_plist_get, Flax_plist_put, internal_equal, Fnconc):
    Use it instead of QUIT, for
    speed in tight loops that might modify non-locals.
    * src/keyboard.h (pending_signals, process_pending_signals):
    These belong to keyboard.c, so move them here ...
    * src/lisp.h: ... from here.
    (QUIT): Redefine in terms of the new maybe_quit function, which
    contains this macro’s old definiens.  This works well with branch
    prediction on processors with return stack buffers, e.g., x86
    other than the original Pentium.

:040000 040000 87d5a840fab3795a0ac0ddf3172aa487d2636e7f 3f764784c5b6b1ad19164a3d7997a66542aa7a3e M	src


Here is an excerpt of the crash report:


Process:               Emacs [23793]
Path:                  /Applications/Emacs.app/Contents/MacOS/Emacs
Identifier:            org.gnu.Emacs
Version:               Version 26.0.50 (9.0)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Emacs [23793]
User ID:               502

Date/Time:             2017-01-30 16:27:20.715 +0000
OS Version:            Mac OS X 10.11.6 (15G1212)

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fff898c68ea __kill + 10
1   org.gnu.Emacs                 	0x00000001000bac99 terminate_due_to_signal + 153 (emacs.c:398)
2   org.gnu.Emacs                 	0x00000001000d76f3 emacs_abort + 19
3   org.gnu.Emacs                 	0x00000001001b3e3a ns_term_shutdown + 122
4   org.gnu.Emacs                 	0x00000001000bae75 shut_down_emacs + 261 (emacs.c:2094)
5   org.gnu.Emacs                 	0x00000001000bac66 terminate_due_to_signal + 102 (emacs.c:379)
6   org.gnu.Emacs                 	0x00000001000d76f3 emacs_abort + 19
7   org.gnu.Emacs                 	0x000000010013c93f signal_or_quit + 1391 (eval.c:1522)
8   org.gnu.Emacs                 	0x00000001000c6784 handle_interrupt + 340 (keyboard.c:10459)
9   org.gnu.Emacs                 	0x00000001000c1a48 gobble_input + 472 (.keyboard.h:472)
10  org.gnu.Emacs                 	0x00000001000c81b5 unblock_input + 69 (keyboard.c:7143)
11  org.gnu.Emacs                 	0x00000001001b2c87 ns_select + 903 (nsterm.m:4194)
12  org.gnu.Emacs                 	0x000000010019f5f8 really_call_select + 88 (thread.c:566)
13  org.gnu.Emacs                 	0x000000010011d81c flush_stack_call_func + 44 (alloc.c:5110)
14  org.gnu.Emacs                 	0x000000010019f597 thread_select + 55 (thread.c:590)
15  org.gnu.Emacs                 	0x00000001001832cd wait_reading_process_output + 4093 (process.c:5367)
16  org.gnu.Emacs                 	0x0000000100007e25 sit_for + 261 (dispnew.c:5766)
17  org.gnu.Emacs                 	0x00000001000c3202 read_char + 4802 (keyboard.c:2651)
18  org.gnu.Emacs                 	0x00000001000bffcb read_key_sequence + 1787 (keyboard.c:9139)
19  org.gnu.Emacs                 	0x00000001000be76d command_loop_1 + 1229 (keyboard.c:1373)
20  org.gnu.Emacs                 	0x000000010013c0f7 internal_condition_case + 87 (eval.c:1327)
21  org.gnu.Emacs                 	0x00000001000cd7a0 command_loop_2 + 48 (keyboard.c:1115)
22  org.gnu.Emacs                 	0x000000010013b9ae internal_catch + 78 (eval.c:1093)
23  org.gnu.Emacs                 	0x00000001000bd99e command_loop + 158 (keyboard.c:1095)
24  org.gnu.Emacs                 	0x00000001000bd8af recursive_edit_1 + 111 (keyboard.c:701)
25  org.gnu.Emacs                 	0x00000001000bdae3 Frecursive_edit + 227 (keyboard.c:772)
26  org.gnu.Emacs                 	0x00000001000bc6bd main + 6109 (emacs.c:1688)
27  libdyld.dylib                 	0x00007fff8ecf85ad start + 1

Thread 1:
0   libsystem_kernel.dylib        	0x00007fff898c75e2 __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff899f0578 _pthread_wqthread + 1283
2   libsystem_pthread.dylib       	0x00007fff899ee341 start_wqthread + 13

Thread 2:: Dispatch queue: com.apple.libdispatch-manager
0   libsystem_kernel.dylib        	0x00007fff898c7efa kevent_qos + 10
1   libdispatch.dylib             	0x00007fff8969f165 _dispatch_mgr_invoke + 216
2   libdispatch.dylib             	0x00007fff8969edcd _dispatch_mgr_thread + 52

Thread 3:
0   libsystem_kernel.dylib        	0x00007fff898c75e2 __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff899f0578 _pthread_wqthread + 1283
2   libsystem_pthread.dylib       	0x00007fff899ee341 start_wqthread + 13

Thread 4:
0   libsystem_kernel.dylib        	0x00007fff898c75e2 __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff899f0578 _pthread_wqthread + 1283
2   libsystem_pthread.dylib       	0x00007fff899ee341 start_wqthread + 13

Thread 5:
0   libsystem_kernel.dylib        	0x00007fff898c75e2 __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff899f0578 _pthread_wqthread + 1283
2   libsystem_pthread.dylib       	0x00007fff899ee341 start_wqthread + 13

Thread 6:
0   libsystem_kernel.dylib        	0x00007fff898c707a __select + 10
1   org.gnu.Emacs                 	0x00000001001b550e -[EmacsApp fd_handler:] + 286 (nsterm.m:5486)
2   com.apple.Foundation          	0x00007fff868f8e64 __NSThread__start__ + 1351
3   libsystem_pthread.dylib       	0x00007fff899f099d _pthread_body + 131
4   libsystem_pthread.dylib       	0x00007fff899f091a _pthread_start + 168
5   libsystem_pthread.dylib       	0x00007fff899ee351 thread_start + 13

Thread 7:
0   libsystem_kernel.dylib        	0x00007fff898c75e2 __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff899f0578 _pthread_wqthread + 1283
2   libsystem_pthread.dylib       	0x00007fff899ee341 start_wqthread + 13

Thread 8:
0   libsystem_kernel.dylib        	0x00007fff898c75e2 __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff899f0578 _pthread_wqthread + 1283
2   libsystem_pthread.dylib       	0x00007fff899ee341 start_wqthread + 13

Thread 9:
0   libsystem_kernel.dylib        	0x00007fff898c75e2 __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff899f0578 _pthread_wqthread + 1283
2   libsystem_pthread.dylib       	0x00007fff899ee341 start_wqthread + 13

Thread 10:
0   libsystem_kernel.dylib        	0x00007fff898c75e2 __workq_kernreturn + 10
1   libsystem_pthread.dylib       	0x00007fff899f0578 _pthread_wqthread + 1283
2   libsystem_pthread.dylib       	0x00007fff899ee341 start_wqthread + 13

Thread 11:: com.apple.NSEventThread
0   libsystem_kernel.dylib        	0x00007fff898c0f72 mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x00007fff898c03b3 mach_msg + 55
2   com.apple.CoreFoundation      	0x00007fff97843124 __CFRunLoopServiceMachPort + 212
3   com.apple.CoreFoundation      	0x00007fff978425ec __CFRunLoopRun + 1356
4   com.apple.CoreFoundation      	0x00007fff97841e38 CFRunLoopRunSpecific + 296
5   com.apple.AppKit              	0x00007fff8f195d95 _NSEventThread + 149
6   libsystem_pthread.dylib       	0x00007fff899f099d _pthread_body + 131
7   libsystem_pthread.dylib       	0x00007fff899f091a _pthread_start + 168
8   libsystem_pthread.dylib       	0x00007fff899ee351 thread_start + 13



HTH,
Sébastien.

bug#25566: 26.0.50; Crash on C-g with master as of d12e1ddf42

[Eli Zaretskii]

> From: Sébastien Le Callonnec <sebastien@weblogism.com>
> Date: Mon, 30 Jan 2017 16:35:45 +0000
> 
> I am experiencing the same issue on master on OSX 10.11.6.
> 
> A bisect points to this commit:
> 
> 1392ec7420ee23238a1588b759c631d87a677483 is the first bad commit
> commit 1392ec7420ee23238a1588b759c631d87a677483
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Date:   Wed Jan 25 20:27:45 2017 -0800

Please try the current master, I think I fixed this.

Thanks.

bug#25566: 26.0.50; Crash on C-g with master as of d12e1ddf42

[Sébastien Le Callonnec]

Hi Eli,

On 2017-01-30 17:11:35, Eli Zaretskii wrote:
> Please try the current master, I think I fixed this.
>
> Thanks.

This indeed fixes the problem for me.  Thanks!


Regards,
Sébastien

bug#25566: 26.0.50; Crash on C-g with master as of d12e1ddf42

[Eli Zaretskii]

> From: Sébastien Le Callonnec <sebastien@weblogism.com>
> Cc: 25566@debbugs.gnu.org
> Date: Mon, 30 Jan 2017 17:54:25 +0000
> 
> On 2017-01-30 17:11:35, Eli Zaretskii wrote:
> > Please try the current master, I think I fixed this.
> >
> > Thanks.
> 
> This indeed fixes the problem for me.  Thanks!

Thanks, closing.