From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sun, 08 Dec 2024 15:11:07 +0100 Message-ID: References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> <86jzcey3cu.fsf@gnu.org> <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> <86r06jgv1j.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="771"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: trevor.m.murphy@gmail.com, monnier@iro.umontreal.ca, Aaron Jensen , 73862@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 08 15:12:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tKI1F-000Abr-AH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Dec 2024 15:12:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKI0z-0007h0-SM; Sun, 08 Dec 2024 09:12:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKI0w-0007gX-OD for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 09:12:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKI0w-0002Mv-Ds for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 09:12:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=3RJBhE2tNe9rgttb0AZWci4Sbclf+/YexEWDYyoT9ec=; b=itXRRs4rUc9jCz3hwVVgEOJPJotJ5eK71RcMpgJfuMK+H33BPgIlwv6319rw61iRbG1QMfYBc2hSEYbUsctAlTaDGqC8HciF8zrNiwSjinJ14eRE464uIMquHFKIT7PkxLfBopWH14PDqZSbJydrQp5CxvRnt5WYZWAG2XTmqltaBf65yORqqhEqHtnyyqlnQvHTnhxTGtt24RxGnQ4uJ6XrAxv/zh3uHNj5aVRtfDT/1BcvtBmND8xLSxqIGpPRGqoZE+GekBzp76BW0c0ydp+2UXiiEwfylx1uoImzTRpMFXbrKjgAVvQZf+gvZjMke/Ji/q7oshliSNKyBr7C5w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tKI0v-0003EW-UA for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 09:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2024 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173366707412355 (code B ref 73862); Sun, 08 Dec 2024 14:12:01 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 8 Dec 2024 14:11:14 +0000 Original-Received: from localhost ([127.0.0.1]:50116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKI09-0003DC-HG for submit@debbugs.gnu.org; Sun, 08 Dec 2024 09:11:13 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:46646 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKI06-0003D2-JL for 73862@debbugs.gnu.org; Sun, 08 Dec 2024 09:11:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1733667070; bh=+I1UU7G7GEpOe2WFxpojsJy2KTpnElphP21XWLEG5TM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YyvcwJv+q1H9j7jrcnUpoeNtnjFjubWCgf4AYIq4Z2JUp57uLcHSEU05O8MtIRmFi vxamzM7J0Nx8h9dbBS+1uCAKwRzXtueU4k4OX/c+TEPJ9GrltfygjMNWGYRitwf5Vr +iDlpIBUA110AoLuFUaaS9CdTrLlBc55rhY6jefnagI8CmfodsF+DcRfr1PmX5Aa8W l8D1r/TK7dsan3T2CwkzJYwjtQ4AKystUqzqN7gvsusckPK27Sx877PB2XqHL8esN0 oxnb984PP8V8cwOtuTHWAuO62d1cnh7d/AlDeVnB/nzDUoPhOcsBHbMI6YGHMK+Z6f AR7vzXlLUm2WQ== In-Reply-To: <86r06jgv1j.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Dec 2024 21:19:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296638 Archived-At: Hi, Eli Zaretskii writes: >> From: Aaron Jensen >> Date: Sat, 7 Dec 2024 14:06:35 -0500 >> Cc: monnier@iro.umontreal.ca, trevor.m.murphy@gmail.com, me@eshelyaron.com, >> 73862@debbugs.gnu.org >> >> Would it make sense to extend the face doc strings that should not use >> inheritance to indicate that? > > I'm not sure. Inheritance does work for the basic faces, it's just > that face-remapping doesn't get passed by inheritance. > >> Alternatively, if there were a path to deprecating header-line and >> mode-line then the compatibility fix could be skipped. > > Let's see what Stefan and others think about this. > > We also haven't yet heard from Eshel. I don't have any concrete suggestions at this point. It's surely a complicated situation. The workaround of remapping both header-line-active and header-line-inactive instead of header-line seems to work. The way I see it, the essence of the issue is that the "face" abstraction is leaky, in the sense that some faces (these "basic faces") behave differently from other faces in some cases that involve inheritance and remapping. I think this calls for either changing the way basic faces are handled so they do behave like any other face, or clearly documenting their subtleties. Eshel